Re: [PATCH, PR43920, 3/9] Cleanup.

2011-04-04 Thread Jeff Law 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 04/01/11 09:15, Tom de Vries wrote:
 On 04/01/2011 05:01 PM, Jakub Jelinek wrote:
 On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote:
 Reposting, with ChangeLog.

 Similarly one of your patches had
  * gcc/cfgcleanup.c (whatever): Whatever.
 in the ChangeLog, should be just
  * cfgcleanup.c (whatever): Whatever.

  Jakub
 
 Fixed ChangeLog.
OK.  Though I don't think you need to mention 43920 in this specific
hunk.  It's a mere cleanup and won't effect the PR at all.

Anyway, please go ahead and install this patch.

Thanks,
jeff
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNmg0pAAoJEBRtltQi2kC7ex8H/3M0G8uXjO7kVhQpuF9RN4sE
4MZ/+0+pYH+mQ8UPzBp7+/YexyDcF5pJErZS3kp9J45JZhm+iWT5sUT5JDs8XeXb
Ye4tBvyCItPGy1M6/Vi7ycSm84dCLK1SKsZcA9Nggjy/C6BIuHNKB0B3Lw+ljOtc
gOXlIJZZH7DT1pIOR2j1Lh7FcuuESxE718kvW+Jakp6vTB454ZJz1yzcvoSC66bK
Y74zqjO0JyZVt+iNx/pfsqPvhhmKVp0M6+J6vLZKQx/4VIQOTKC4fi0bSyJK94ec
4JG3idbM0K6lhr/xNxq4IWNutwDsiitYEZw8fb4wA+l8yoTGxuyR5fFa1qQIjNw=
=iXl3
-END PGP SIGNATURE-

Re: [PATCH, PR43920, 3/9] Cleanup.

2011-04-01 Thread Tom de Vries 
On 04/01/2011 05:01 PM, Jakub Jelinek wrote:
 On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote:
 Reposting, with ChangeLog.

 Similarly one of your patches had
   * gcc/cfgcleanup.c (whatever): Whatever.
 in the ChangeLog, should be just
   * cfgcleanup.c (whatever): Whatever.

   Jakub

Fixed ChangeLog.

Thanks,
- Tom
2011-04-01  Tom de Vries  t...@codesourcery.com

	PR target/43920
	* cfgcleanup.c (try_crossjump_bb): Remove 2 superfluous variables.

diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c
--- gcc/cfgcleanup.c	(working copy)
+++ gcc/cfgcleanup.c	(working copy)
@@ -1961,7 +1961,6 @@
   edge e, e2, fallthru;
   bool changed;
   unsigned max, ix, ix2;
-  basic_block ev, ev2;
 
   /* Nothing to do if there is not at least two incoming edges.  */
   if (EDGE_COUNT (bb-preds)  2)
@@ -2001,9 +2000,9 @@
   fallthru = find_fallthru_edge (bb-preds);
 
   changed = false;
-  for (ix = 0, ev = bb; ix  EDGE_COUNT (ev-preds); )
+  for (ix = 0; ix  EDGE_COUNT (bb-preds);)
 {
-  e = EDGE_PRED (ev, ix);
+  e = EDGE_PRED (bb, ix);
   ix++;
 
   /* As noted above, first try with the fallthru predecessor (or, a
@@ -2021,7 +2020,6 @@
 	{
 	  changed = true;
 	  ix = 0;
-	  ev = bb;
 	  continue;
 	}
 	}
@@ -2045,10 +2043,9 @@
   if (EDGE_SUCC (e-src, 0) != e)
 	continue;
 
-  for (ix2 = 0, ev2 = bb; ix2  EDGE_COUNT (ev2-preds); )
+  for (ix2 = 0; ix2  EDGE_COUNT (bb-preds); ix2++)
 	{
-	  e2 = EDGE_PRED (ev2, ix2);
-	  ix2++;
+	  e2 = EDGE_PRED (bb, ix2);
 
 	  if (e2 == e)
 	continue;
@@ -2071,7 +2068,6 @@
 	  if (try_crossjump_to_edge (mode, e, e2))
 	{
 	  changed = true;
-	  ev2 = bb;
 	  ix = 0;
 	  break;
 	}

Re: [PATCH, PR43920, 3/9] Cleanup.

2011-03-31 Thread Jeff Law 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 03/31/11 12:29, Tom de Vries wrote:
 Cleans up some code.
OK.  Note that it would have helped if you mentioned that bb was a
loop invariant and thus ev and ev2 were loop invariants that could
be replaced by bb.

Please install..  Thanks,

jeff
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNlMqtAAoJEBRtltQi2kC7AVYIAIWNzXn/51nk+xp4ZE+PS3T6
NU/y9m0q3x/hU+SpSzFX5l+hw/+mT+WQou9fU/Gzf9CQlWLk4i+6cXLbG60vGmFo
b38R4R7qnPpAI1OiHddaoh5eGzYHWkZQdgtYxLkJv6oqwF0EzSMg7/F7lXkaPsZK
agSSQBNFNTWFV3jD+YeplioAWphzbWeQf+d5glNuc5sP+ImUU/Mpg5Sh1WC3n1C3
i9XBwSczwzikHyvrmGJQcdcv3NL9MkazcMSbCD7jg32Zx/bXqdtlJ+qzkQGv1PAt
VQMzna8mqm3YDd4yOUo3xzJBA1SQM8Ff8xd1dVm4QL8WUPDBNZztobQ5f2U4Zi4=
=bDHO
-END PGP SIGNATURE-