Re: [PATCH, testsuite]: Fix timeout in simulate-thread.exp
On 11/17/2011 02:33 PM, Mike Stump wrote: The patch also sets timeout to 10 seconds, due to huge amount of produced log and improves fail messages a bit. 10 might be a bit low... (slow targets, simulators, complex remote target setup) but we can go with that for now until someone has a need for a larger value. I expect the log size could be dramatically reduced. I think Aldy had it set to really verbose so there is a bunch of stuff spit out at each instruction. Much of that probably isn't needed for a normal day to day run. At least I would guess it isn't. All I was ever looking for was whether the run was successful or not.One could go run it later to create the log if there was a failure... the rest of the time we dont care. if the log was a lot smaller, increasing the timeout time wouldn't be as big a deal. Andrew
Re: [PATCH, testsuite]: Fix timeout in simulate-thread.exp
On Nov 17, 2011, at 1:54 AM, Uros Bizjak wrote: > The problem was, that dejagnu didn't kill gdb in case of timeout (i.e. > broken LL/SC sequences for alpha). > The patch also sets timeout to 10 seconds, due to huge amount of > produced log and improves fail messages a bit. 10 might be a bit low... (slow targets, simulators, complex remote target setup) but we can go with that for now until someone has a need for a larger value. > OK for mainline? Ok.
Re: [PATCH, testsuite]: Fix timeout in simulate-thread.exp
Hi Uros, On 17 Nov 2011, at 14:02, Uros Bizjak wrote: On Thu, Nov 17, 2011 at 2:22 PM, Iain Sandoe wrote: On 17 Nov 2011, at 10:49, Alan Modra wrote: On Thu, Nov 17, 2011 at 10:54:23AM +0100, Uros Bizjak wrote: The solution for this problem is to search for "simulate_thread_done" in gdb log. Thanks! I like this for another reason too: I've seen these tests fail due to gdb never reporting simulate_thread_main on any instruction in that function. ... works for me on powerpc-darwin9 ... with a local experimental 7.3.1 port to powerpc-darwin9, some more tests pass, but not all ... ... what base version/patch is needed to get all the tests to pass for you? It looks to me that you will also need following rs6000 gdb patch, otherwise relative addresses of a conditional branch will be calculated against opening lwarx/ldarx instruction: --- rs6000-tdep.c 2011-03-18 19:52:31.0 +0100 +++ rs6000-tdep.c.ub2011-11-17 14:58:46.0 +0100 @@ -1126,7 +1126,7 @@ ppc_deal_with_atomic_sequence (struct fr if (absolute) breaks[1] = immediate; else - breaks[1] = pc + immediate; + breaks[1] = loc + immediate; bc_insn_count++; last_breakpoint++; Excellent!!! Native configuration is powerpc-apple-darwin9 Running target unix/-m32 Using /usr/local/dejagnu-1-4-4/share/dejagnu/baseboards/unix.exp as board description file for target. Using /usr/local/dejagnu-1-4-4/share/dejagnu/config/unix.exp as generic interface file for target. Using /GCC/gcc-live-trunk/gcc/testsuite/config/default.exp as tool-and- target-specific interface file. Running /GCC/gcc-live-trunk/gcc/testsuite/gcc.dg/simulate-thread/ simulate-thread.exp ... === gcc Summary === # of expected passes108 # of unsupported tests 22 /Volumes/ScratchCS/gcc-4-7-trunk-build/gcc/xgcc version 4.7.0 2017 (experimental) [trunk revision 181436] (GCC) (I haven't finished the m64 gdb port yet, so can't try that at the moment). :-) Iain
Re: [PATCH, testsuite]: Fix timeout in simulate-thread.exp
On Thu, Nov 17, 2011 at 2:22 PM, Iain Sandoe wrote: > > On 17 Nov 2011, at 10:49, Alan Modra wrote: > >> On Thu, Nov 17, 2011 at 10:54:23AM +0100, Uros Bizjak wrote: >>> >>> The solution for this problem is to search for "simulate_thread_done" >>> in gdb log. >> >> Thanks! I like this for another reason too: I've seen these tests >> fail due to gdb never reporting simulate_thread_main on any >> instruction in that function. > > ... works for me on powerpc-darwin9 ... > > with a local experimental 7.3.1 port to powerpc-darwin9, some more tests > pass, but not all ... > ... what base version/patch is needed to get all the tests to pass for you? It looks to me that you will also need following rs6000 gdb patch, otherwise relative addresses of a conditional branch will be calculated against opening lwarx/ldarx instruction: --- rs6000-tdep.c 2011-03-18 19:52:31.0 +0100 +++ rs6000-tdep.c.ub2011-11-17 14:58:46.0 +0100 @@ -1126,7 +1126,7 @@ ppc_deal_with_atomic_sequence (struct fr if (absolute) breaks[1] = immediate; else - breaks[1] = pc + immediate; + breaks[1] = loc + immediate; bc_insn_count++; last_breakpoint++; Uros.
Re: [PATCH, testsuite]: Fix timeout in simulate-thread.exp
On 17 Nov 2011, at 10:49, Alan Modra wrote: On Thu, Nov 17, 2011 at 10:54:23AM +0100, Uros Bizjak wrote: The solution for this problem is to search for "simulate_thread_done" in gdb log. Thanks! I like this for another reason too: I've seen these tests fail due to gdb never reporting simulate_thread_main on any instruction in that function. ... works for me on powerpc-darwin9 ... with a local experimental 7.3.1 port to powerpc-darwin9, some more tests pass, but not all ... ... what base version/patch is needed to get all the tests to pass for you? thanks Iain
Re: [PATCH, testsuite]: Fix timeout in simulate-thread.exp
On Thu, Nov 17, 2011 at 10:54:23AM +0100, Uros Bizjak wrote: > The solution for this problem is to search for "simulate_thread_done" > in gdb log. Thanks! I like this for another reason too: I've seen these tests fail due to gdb never reporting simulate_thread_main on any instruction in that function. -- Alan Modra Australia Development Lab, IBM
