Re: [PATCH][DOC][OBVIOUS] Document default value for use-after-scope-direct-emission-threshold

[Martin Liška]

On 02/18/2017 09:48 AM, Gerald Pfeifer wrote:
> Let me know whether this looks fine to you, and I'll commit.
> 
> Gerald

I'm fine with that! Thanks.

Martin

Re: [PATCH][DOC][OBVIOUS] Document default value for use-after-scope-direct-emission-threshold

[Gerald Pfeifer]

On Fri, 3 Feb 2017, Martin Liška wrote:
>> Yes, but...

>> (I'm still not quite sure what this option does, and whether we 
>> could say "poison and unpoison it", for example?  Can you advise?)
> I'm sending enhancement of that. Basically: direct poisoning = emitting
> instructions that touch shadow memory vs. runtime callbacks = function
> that does that :)
>
> I welcome help with that.

How about the following, Martin, which tries to combine our two
sets of changes (and adds some editorial changes)?

Let me know whether this looks fine to you, and I'll commit.

Gerald


2017-02-05  Gerald Pfeifer  
Martin Liška  

* doc/invoke.texi (use-after-scope-direct-emission-threshold):
Fix typos and grammar, use active voice, and clarify.

Index: doc/invoke.texi
===
--- doc/invoke.texi (revision 245559)
+++ doc/invoke.texi (working copy)
@@ -10478,9 +10478,9 @@
 @option{--param asan-instrumentation-with-call-threshold=0}.
 
 @item use-after-scope-direct-emission-threshold
-If size of a local variable in bytes is smaller or equal to this number,
-direct instruction emission is utilized to poison and unpoison local variables.
-Default value in 256.
+If the size of a local variable in bytes is smaller or equal to this
+number, directly poison (or unpoison) shadow memory instead of using
+run-time callbacks.  The default value is 256.
 
 @item chkp-max-ctor-size
 Static constructors generated by Pointer Bounds Checker may become very

Re: [PATCH][DOC][OBVIOUS] Document default value for use-after-scope-direct-emission-threshold

[Martin Liška]

On 02/03/2017 10:45 AM, Gerald Pfeifer wrote:
> On Fri, 3 Feb 2017, Martin Liška wrote:
>> Installed as obvious as r245147.
> 
> Yes, but...

Hi.

Thanks for that, stupid typos.

> 
> I think you wanted to say "is 256", not "in 256" and make this a
> full sentence?  Looking at the entire entry I noticed a few other
> issues ("smaller of equal" instead of "smaller or equal", missing
> articles, passive voice,...) which I believe the patch below addresses.
> 
> (I'm still not quite sure what this option does, and whether we 
> could say "poison and unpoison it", for example?  Can you advise?)

I'm sending enhancement of that. Basically: direct poisoning = emitting
instructions that touch shadow memory vs. runtime callbacks = function
that does that :)

I welcome help with that.

Martin

> 
> Gerald
> 
> 2017-02-03  Gerald Pfeifer  
> 
>   * doc/invoke.texi (use-after-scope-direct-emission-threshold):
>   Fix typos and grammar; use active voice.
> 
> Index: doc/invoke.texi
> ===
> --- doc/invoke.texi   (revision 245148)
> +++ doc/invoke.texi   (working copy)
> @@ -10469,9 +10469,9 @@
>  @option{--param asan-instrumentation-with-call-threshold=0}.
>  
>  @item use-after-scope-direct-emission-threshold
> -If size of a local variables in bytes is smaller of equal to this number,
> -direct instruction emission is utilized to poison and unpoison local 
> variables.
> -Default value in 256.
> +If the size of a local variable in bytes is smaller or equal to this number,
> +utilize direct instruction emission to poison and unpoison local variables.
> +The default value is 256.
>  
>  @item chkp-max-ctor-size
>  Static constructors generated by Pointer Bounds Checker may become very
> 

>From 685cf7e8e22380916ac2b020f03d517cc2ae3a9a Mon Sep 17 00:00:00 2001
From: marxin 
Date: Fri, 3 Feb 2017 12:29:35 +0100
Subject: [PATCH] v2

---
 gcc/doc/invoke.texi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 08d26a1d858..1dd26ad11c7 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10469,9 +10469,9 @@ E.g. to disable inline code use
 @option{--param asan-instrumentation-with-call-threshold=0}.
 
 @item use-after-scope-direct-emission-threshold
-If size of a local variables in bytes is smaller of equal to this number,
-direct instruction emission is utilized to poison and unpoison local variables.
-Default value in 256.
+If size of a local variable in bytes is smaller or equal to this number,
+directly poison (or unpoison) shadow memory.  Otherwise runtime callbacks
+are used.  The default value is 256.
 
 @item chkp-max-ctor-size
 Static constructors generated by Pointer Bounds Checker may become very
-- 
2.11.0

Re: [PATCH][DOC][OBVIOUS] Document default value for use-after-scope-direct-emission-threshold

[Gerald Pfeifer]

On Fri, 3 Feb 2017, Martin Liška wrote:
> Installed as obvious as r245147.

Yes, but...

I think you wanted to say "is 256", not "in 256" and make this a
full sentence?  Looking at the entire entry I noticed a few other
issues ("smaller of equal" instead of "smaller or equal", missing
articles, passive voice,...) which I believe the patch below addresses.

(I'm still not quite sure what this option does, and whether we 
could say "poison and unpoison it", for example?  Can you advise?)

Gerald

2017-02-03  Gerald Pfeifer  

* doc/invoke.texi (use-after-scope-direct-emission-threshold):
Fix typos and grammar; use active voice.

Index: doc/invoke.texi
===
--- doc/invoke.texi (revision 245148)
+++ doc/invoke.texi (working copy)
@@ -10469,9 +10469,9 @@
 @option{--param asan-instrumentation-with-call-threshold=0}.
 
 @item use-after-scope-direct-emission-threshold
-If size of a local variables in bytes is smaller of equal to this number,
-direct instruction emission is utilized to poison and unpoison local variables.
-Default value in 256.
+If the size of a local variable in bytes is smaller or equal to this number,
+utilize direct instruction emission to poison and unpoison local variables.
+The default value is 256.
 
 @item chkp-max-ctor-size
 Static constructors generated by Pointer Bounds Checker may become very