Re: [PATCH] [libstdc++] Remove unused hasher instance.

2021-06-08 Thread Thomas Rodgers via Gcc-patches
Tested x86_64-pc-linux-gnu, committed to master, backported to
releases/gcc-11.

On Fri, Jun 4, 2021 at 1:30 PM Jonathan Wakely  wrote:

>
>
> On Fri, 4 Jun 2021 at 20:54, Thomas Rodgers wrote:
>
>> This is a remnant of poorly executed refactoring.
>>
>
> OK for trunk and gcc-11, thanks.
>
>
>
>> libstdc++-v3/ChangeLog:
>>
>> * include/std/barrier (__tree_barrier::_M_arrive): Remove
>> unnecessary hasher instantiation.
>> ---
>>  libstdc++-v3/include/std/barrier | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/libstdc++-v3/include/std/barrier
>> b/libstdc++-v3/include/std/barrier
>> index fd61fb4f9da..4210e30d1ce 100644
>> --- a/libstdc++-v3/include/std/barrier
>> +++ b/libstdc++-v3/include/std/barrier
>> @@ -103,7 +103,6 @@ It looks different from literature pseudocode for two
>> main reasons:
>>static_cast<__barrier_phase_t>(__old_phase_val
>> + 2);
>>
>> size_t __current_expected = _M_expected;
>> -   std::hash __hasher;
>> __current %= ((_M_expected + 1) >> 1);
>>
>> for (int __round = 0; ; ++__round)
>> --
>> 2.26.2
>>
>>


Re: [PATCH] [libstdc++] Remove unused hasher instance.

2021-06-04 Thread Jonathan Wakely via Gcc-patches
On Fri, 4 Jun 2021 at 20:54, Thomas Rodgers wrote:

> This is a remnant of poorly executed refactoring.
>

OK for trunk and gcc-11, thanks.



> libstdc++-v3/ChangeLog:
>
> * include/std/barrier (__tree_barrier::_M_arrive): Remove
> unnecessary hasher instantiation.
> ---
>  libstdc++-v3/include/std/barrier | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/libstdc++-v3/include/std/barrier
> b/libstdc++-v3/include/std/barrier
> index fd61fb4f9da..4210e30d1ce 100644
> --- a/libstdc++-v3/include/std/barrier
> +++ b/libstdc++-v3/include/std/barrier
> @@ -103,7 +103,6 @@ It looks different from literature pseudocode for two
> main reasons:
>static_cast<__barrier_phase_t>(__old_phase_val
> + 2);
>
> size_t __current_expected = _M_expected;
> -   std::hash __hasher;
> __current %= ((_M_expected + 1) >> 1);
>
> for (int __round = 0; ; ++__round)
> --
> 2.26.2
>
>