Re: [PATCH] AARCH64: Remove spurious attribute __unused__ from NEON intrinsic
On Mon, Apr 25, 2016 at 05:47:57PM +0100, James Greenhalgh wrote: > On Mon, Apr 25, 2016 at 05:39:45PM +0200, Wladimir J. van der Laan wrote: > > > > Thanks for the info with regard to contributing, > > > > On Fri, Apr 22, 2016 at 09:40:11AM +0100, James Greenhalgh wrote: > > > This patch will need a ChangeLog entry [1], please draft one that I can > > > use when I apply the patch. > > > > * gcc/config/aarch64/arm_neon.h: Remove spurious attribute __unused__ from > > parameter of vdupb_laneq_s intrinsic > > Close... This should look like: > > 2016-04-25 Wladimir J. van der Laan > > * config/aarch64/arm_neon.h (vdupb_laneq_s): Remove spurious > attribute __unused__ > > Can you confirm that this is how you want your name and email address > to appear in the ChangeLog. If so, I'll commit the patch for you. I've been out-of-office for a while. While I was away, Wladimir contacted me off-list to confirm that this was correct. I've committed the patch as revision r236914. Thanks for the patch Wladimir! James
Re: [PATCH] AARCH64: Remove spurious attribute __unused__ from NEON intrinsic
On Mon, Apr 25, 2016 at 05:39:45PM +0200, Wladimir J. van der Laan wrote: > > Thanks for the info with regard to contributing, > > On Fri, Apr 22, 2016 at 09:40:11AM +0100, James Greenhalgh wrote: > > This patch will need a ChangeLog entry [1], please draft one that I can > > use when I apply the patch. > > * gcc/config/aarch64/arm_neon.h: Remove spurious attribute __unused__ from > parameter of vdupb_laneq_s intrinsic Close... This should look like: 2016-04-25 Wladimir J. van der Laan * config/aarch64/arm_neon.h (vdupb_laneq_s): Remove spurious attribute __unused__ Can you confirm that this is how you want your name and email address to appear in the ChangeLog. If so, I'll commit the patch for you. > > I'm guessing that you don't have a copyright assignment on file with the > > FSF. While trivial changes like this don't generally need one, if you plan > > to contribute more substantial changed to GCC in future, you may want to > > start the process (see [2]). > > I intend to do this, but indeed let's not hold this two-word change up > on that. Thanks, James
Re: [PATCH] AARCH64: Remove spurious attribute __unused__ from NEON intrinsic
Thanks for the info with regard to contributing, On Fri, Apr 22, 2016 at 09:40:11AM +0100, James Greenhalgh wrote: > This patch will need a ChangeLog entry [1], please draft one that I can > use when I apply the patch. * gcc/config/aarch64/arm_neon.h: Remove spurious attribute __unused__ from parameter of vdupb_laneq_s intrinsic > I'm guessing that you don't have a copyright assignment on file with the > FSF. While trivial changes like this don't generally need one, if you plan > to contribute more substantial changed to GCC in future, you may want to > start the process (see [2]). I intend to do this, but indeed let's not hold this two-word change up on that. Regards, Wladimir van der Laan
Re: [PATCH] AARCH64: Remove spurious attribute __unused__ from NEON intrinsic
On Fri, Apr 22, 2016 at 07:59:41AM +0200, Wladimir J. van der Laan wrote:
> The lane parameter is not unused, so should not be marked as such.
>
> The others were removed in https://patchwork.ozlabs.org/patch/272912/,
> but this one appears to have been missed.
The patch looks good to me, and is OK for trunk... Now for all the
administration!
This patch will need a ChangeLog entry [1], please draft one that I can
use when I apply the patch.
I'm guessing that you don't have a copyright assignment on file with the
FSF. While trivial changes like this don't generally need one, if you plan
to contribute more substantial changed to GCC in future, you may want to
start the process (see [2]).
Thanks for the contribution, if you provide a ChangeLog, I'd be happy to
apply the patch.
Thanks,
James
---
[1]: http://www.gnu.org/prep/standards/standards.html#Change-Logs
[2]: https://gcc.gnu.org/contribute.html
> ---
> gcc/config/aarch64/arm_neon.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/aarch64/arm_neon.h b/gcc/config/aarch64/arm_neon.h
> index 2612a32..0a2aa7b 100644
> --- a/gcc/config/aarch64/arm_neon.h
> +++ b/gcc/config/aarch64/arm_neon.h
> @@ -14070,7 +14070,7 @@ vdupb_laneq_p8 (poly8x16_t __a, const int __b)
> }
>
> __extension__ static __inline int8_t __attribute__ ((__always_inline__))
> -vdupb_laneq_s8 (int8x16_t __a, const int __attribute__ ((unused)) __b)
> +vdupb_laneq_s8 (int8x16_t __a, const int __b)
> {
>return __aarch64_vget_lane_any (__a, __b);
> }
> --
> 1.9.1
>
