Re: [PATCH] Fix PR c++/60764

2014-04-16 Thread Patrick Palka 
Could someone install this for me?

Re: [PATCH] Fix PR c++/60764

2014-04-10 Thread Jason Merrill 

On 04/09/2014 05:27 PM, Marc Glisse wrote:

The doc for the "format" attribute says clearly:

"Since non-static C++ methods have an implicit this argument, the
arguments of such methods should be counted from two, not one, when
giving values for string-index and first-to-check."


Ah.  That seems wrong to me, but if it's already documented that way I 
guess we shouldn't change it.



It would be strange to count arguments differently for different
attributes.


Agreed.

The patch is OK for after 4.9 branches.

Jason

Re: [PATCH] Fix PR c++/60764

2014-04-09 Thread Marc Glisse 

On Wed, 9 Apr 2014, Jason Merrill wrote:

Hmm, I would expect the parameter numbering for attribute nonnull and such to 
ignore the 'this' parameter.


The doc for the "format" attribute says clearly:

"Since non-static C++ methods have an implicit this argument, the 
arguments of such methods should be counted from two, not one, when giving 
values for string-index and first-to-check."


It would be strange to count arguments differently for different 
attributes.


--
Marc Glisse

Re: [PATCH] Fix PR c++/60764

2014-04-09 Thread Jason Merrill 
Hmm, I would expect the parameter numbering for attribute nonnull and 
such to ignore the 'this' parameter.


Jason