Re: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread 钟居哲 
Ok. Comments added:
in V2:
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624476.html 




juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-07-13 23:25
To: juzhe.zhong; Kito Cheng
CC: rdapp.gcc; gcc-patches; jeffreyalaw; kito.cheng; palmer; palmer
Subject: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization
 
> Is COND _LEN FMA ok for trunk?  I can commit it without changing
> scatter store testcase fix.
> 
> It makes no sense block cond Len fma support. The middle end support
> has already been merged.
 
Then just add a TODO or so that says e.g. "For some reason we exceed
the default code model's +-2 GiB limits.  We should investigate why and
add a proper description here.  For now just make sure the test case
compiles properly".
 
Regards
Robin

Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread Robin Dapp via Gcc-patches 


> Is COND _LEN FMA ok for trunk?  I can commit it without changing
> scatter store testcase fix.
> 
> It makes no sense block cond Len fma support. The middle end support
> has already been merged.

Then just add a TODO or so that says e.g. "For some reason we exceed
the default code model's +-2 GiB limits.  We should investigate why and
add a proper description here.  For now just make sure the test case
compiles properly".

Regards
 Robin

Re: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread 钟居哲 
Yes. Not always fail.



juzhe.zh...@rivai.ai
 
From: Kito Cheng
Date: 2023-07-13 22:39
To: juzhe.zh...@rivai.ai
CC: Robin Dapp; gcc-patches; jeffreyalaw; kito.cheng; palmer; palmer
Subject: Re: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization
I didn’t try on local yet, but it sounds like …the code size might larger than 
normal case?

juzhe.zh...@rivai.ai 於 2023年7月13日 週四，19:50寫道：
Could you tell me how to add the comment?
I am not familiar with link/binutils stuff.



juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-07-13 19:40
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw
Subject: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization
Hi Juzhe,
 
thanks, no complaints from my side apart from one:
 
> +/* { dg-additional-options "-mcmodel=medany" } */
 
Please add a comment why we need this.
 
Regards
Robin

Re: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread Kito Cheng via Gcc-patches 
I didn’t try on local yet, but it sounds like …the code size might larger
than normal case?

juzhe.zh...@rivai.ai 於 2023年7月13日 週四，19:50寫道：

> Could you tell me how to add the comment?
> I am not familiar with link/binutils stuff.
>
> --
> juzhe.zh...@rivai.ai
>
>
> *From:* Robin Dapp 
> *Date:* 2023-07-13 19:40
> *To:* Juzhe-Zhong ; gcc-patches
> 
> *CC:* rdapp.gcc ; kito.cheng ;
> kito.cheng ; palmer ; palmer
> ; jeffreyalaw 
> *Subject:* Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization
> Hi Juzhe,
>
> thanks, no complaints from my side apart from one:
>
> > +/* { dg-additional-options "-mcmodel=medany" } */
>
> Please add a comment why we need this.
>
> Regards
> Robin
>
>
>

Re: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread juzhe.zh...@rivai.ai 
Could you tell me how to add the comment?
I am not familiar with link/binutils stuff.



juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-07-13 19:40
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw
Subject: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization
Hi Juzhe,
 
thanks, no complaints from my side apart from one:
 
> +/* { dg-additional-options "-mcmodel=medany" } */
 
Please add a comment why we need this.
 
Regards
Robin

Re: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread juzhe.zh...@rivai.ai 
I have no ideal.

This testcase cause link ICE:
FAIL: gcc.target/riscv/rvv/autovec/gather-scatter/scatter_store_run-7.c (test 
for excess errors)
Excess errors:
scatter_store_run-7.c:(.text.startup+0xc8e): relocation truncated to fit: 
R_RISCV_GPREL_I against `.LANCHOR1'

only LMUL = M8 will cause such issue.



juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-07-13 19:40
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw
Subject: Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization
Hi Juzhe,
 
thanks, no complaints from my side apart from one:
 
> +/* { dg-additional-options "-mcmodel=medany" } */
 
Please add a comment why we need this.
 
Regards
Robin

Re: [PATCH] RISC-V: Enable COND_LEN_FMA auto-vectorization

2023-07-13 Thread Robin Dapp via Gcc-patches 
Hi Juzhe,

thanks, no complaints from my side apart from one:

> +/* { dg-additional-options "-mcmodel=medany" } */

Please add a comment why we need this.

Regards
 Robin