Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with decompress operation
On 6/12/23 08:54, Kito Cheng wrote: I didn't take a close review yet, (and I suspect I can't find time before I start my vacation :P), but I am thinking we may adding selftests for expand_const_vector in *future*, again, not blocker for this patch :) I'll take this one. Go enjoy your vacation! jeff
Re: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with decompress operation
I didn't take a close review yet, (and I suspect I can't find time before I start my vacation :P), but I am thinking we may adding selftests for expand_const_vector in *future*, again, not blocker for this patch :) On Mon, Jun 12, 2023 at 10:51 PM 钟居哲 wrote: > > No. Such pattern you pointed I already supported. > The operation is very simple. > Just use a single vmv.v.i but larger SEW is enough. No need vzext. > > > juzhe.zh...@rivai.ai > > > From: Robin Dapp > Date: 2023-06-12 22:43 > To: juzhe.zhong; gcc-patches > CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw > Subject: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with > decompress operation > Hi Juzhe, > > seems a nice improvement, looks good to me. While reading I was wondering > if vzext could help synthesize some (zero-based) patterns as well > (e.g. 0 3 0 3...). > However the sequences I could come up with were not shorter than what we > are already emitting, so probably not. > > Regards > Robin >
Re: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with decompress operation
No. Such pattern you pointed I already supported. The operation is very simple. Just use a single vmv.v.i but larger SEW is enough. No need vzext. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-06-12 22:43 To: juzhe.zhong; gcc-patches CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw Subject: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with decompress operation Hi Juzhe, seems a nice improvement, looks good to me. While reading I was wondering if vzext could help synthesize some (zero-based) patterns as well (e.g. 0 3 0 3...). However the sequences I could come up with were not shorter than what we are already emitting, so probably not. Regards Robin
Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with decompress operation
Hi Juzhe, seems a nice improvement, looks good to me. While reading I was wondering if vzext could help synthesize some (zero-based) patterns as well (e.g. 0 3 0 3...). However the sequences I could come up with were not shorter than what we are already emitting, so probably not. Regards Robin
