Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]
* Jakub Jelinek: > On Thu, Nov 24, 2022 at 11:01:40AM +0100, Florian Weimer via Gcc-patches > wrote: >> * Joseph Myers: >> >> > On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: >> > >> >> Without this change, finish_declspecs cannot tell that whether there >> >> was an erroneous type specified, or no type at all. This may result >> >> in additional diagnostics for implicit ints, or missing diagnostics >> >> for multiple types. >> >> >> >> PR c/107805 >> >> >> >> gcc/c/ >> >> * c-decl.cc (declspecs_add_type): Propagate error_mark_bode >> >> from type to specs. >> >> >> >> gcc/testsuite/ >> >> * gcc.dg/pr107805-1.c: New test. >> >> * gcc.dg/pr107805-1.c: Likewise. >> > >> > OK. >> >> Thanks. Permission to backport this to GCC 12 after a week or two? > > In this case I'd wait a month, it will take some time until possible > error recovery bugs are discovered. Okay, I have made a note to backport it in the new year. Hopefully any regressions will be flagged on the PR or linked to it. Thanks, Florian
Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]
On Thu, Nov 24, 2022 at 11:01:40AM +0100, Florian Weimer via Gcc-patches wrote: > * Joseph Myers: > > > On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: > > > >> Without this change, finish_declspecs cannot tell that whether there > >> was an erroneous type specified, or no type at all. This may result > >> in additional diagnostics for implicit ints, or missing diagnostics > >> for multiple types. > >> > >>PR c/107805 > >> > >> gcc/c/ > >>* c-decl.cc (declspecs_add_type): Propagate error_mark_bode > >>from type to specs. > >> > >> gcc/testsuite/ > >>* gcc.dg/pr107805-1.c: New test. > >>* gcc.dg/pr107805-1.c: Likewise. > > > > OK. > > Thanks. Permission to backport this to GCC 12 after a week or two? In this case I'd wait a month, it will take some time until possible error recovery bugs are discovered. Jakub
Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]
* Joseph Myers: > On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: > >> Without this change, finish_declspecs cannot tell that whether there >> was an erroneous type specified, or no type at all. This may result >> in additional diagnostics for implicit ints, or missing diagnostics >> for multiple types. >> >> PR c/107805 >> >> gcc/c/ >> * c-decl.cc (declspecs_add_type): Propagate error_mark_bode >> from type to specs. >> >> gcc/testsuite/ >> * gcc.dg/pr107805-1.c: New test. >> * gcc.dg/pr107805-1.c: Likewise. > > OK. Thanks. Permission to backport this to GCC 12 after a week or two? Florian
Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]
On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: > Without this change, finish_declspecs cannot tell that whether there > was an erroneous type specified, or no type at all. This may result > in additional diagnostics for implicit ints, or missing diagnostics > for multiple types. > > PR c/107805 > > gcc/c/ > * c-decl.cc (declspecs_add_type): Propagate error_mark_bode > from type to specs. > > gcc/testsuite/ > * gcc.dg/pr107805-1.c: New test. > * gcc.dg/pr107805-1.c: Likewise. OK. -- Joseph S. Myers jos...@codesourcery.com
