Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
El 12 de febrer de 2012 1:09, Gerald Pfeifer ha escrit: > Given that both Mike and me considered this patch on the obvious > side, I now committed the following variation thereof on trunk. Thanks! -- Robert Millan
Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
Given that both Mike and me considered this patch on the obvious side, I now committed the following variation thereof on trunk. (Note the line break and comment change. 5! = 120 did not seem like a useful version number. ;-) Gerald Index: ginclude/stddef.h === --- ginclude/stddef.h (revision 184130) +++ ginclude/stddef.h (working copy) @@ -200,8 +200,9 @@ #define ___int_size_t_h #define _GCC_SIZE_T #define _SIZET_ -#if defined (__FreeBSD__) && (__FreeBSD__ >= 5) -/* __size_t is a typedef on FreeBSD 5!, must not trash it. */ +#if (defined (__FreeBSD__) && (__FreeBSD__ >= 5)) \ + || defined(__FreeBSD_kernel__) +/* __size_t is a typedef on FreeBSD 5, must not trash it. */ #else #define __size_t #endif
Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
El 6 de febrer de 2012 19:31, Mike Stump ha escrit: >>> Looks obvious to me as well. I'd say let's put it in... >> >> Is this patch approved, then? > > I've not seen anyone approve it yet. I'm not a maintainer for that area, so, > I cannot. Who can approve it? Looking at the maintainers file it's not clear to me which area does this belong to. -- Robert Millan
Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
On Feb 4, 2012, at 11:20 AM, Robert Millan wrote: > El 1 de febrer de 2012 1:06, Mike Stump ha escrit: >> On Jan 31, 2012, at 2:29 PM, Gerald Pfeifer wrote: >>> On Sun, 29 Jan 2012, Robert Millan wrote: Please consider this patch to stddef.h. GNU/kFreeBSD has the same problem with __size_t as FreeBSD does, since it inherits many kernel headers from FreeBSD. >>> >>> The patch looks obvious to me, and I'll be happy to apply for >>> Robert if approved. Any taker? >> >> Looks obvious to me as well. I'd say let's put it in... > > Is this patch approved, then? I've not seen anyone approve it yet. I'm not a maintainer for that area, so, I cannot.
Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
El 1 de febrer de 2012 1:06, Mike Stump ha escrit: > On Jan 31, 2012, at 2:29 PM, Gerald Pfeifer wrote: >> On Sun, 29 Jan 2012, Robert Millan wrote: >>> Please consider this patch to stddef.h. GNU/kFreeBSD has the same >>> problem with __size_t as FreeBSD does, since it inherits many kernel >>> headers from FreeBSD. >> >> The patch looks obvious to me, and I'll be happy to apply for >> Robert if approved. Any taker? > > Looks obvious to me as well. I'd say let's put it in... Is this patch approved, then? -- Robert Millan
Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
On Jan 31, 2012, at 2:29 PM, Gerald Pfeifer wrote: > On Sun, 29 Jan 2012, Robert Millan wrote: >> Please consider this patch to stddef.h. GNU/kFreeBSD has the same >> problem with __size_t as FreeBSD does, since it inherits many kernel >> headers from FreeBSD. > > The patch looks obvious to me, and I'll be happy to apply for > Robert if approved. Any taker? Looks obvious to me as well. I'd say let's put it in...
Re: [PATCH] disable __size_t macro on GNU/kFreeBSD
On Sun, 29 Jan 2012, Robert Millan wrote: > Please consider this patch to stddef.h. GNU/kFreeBSD has the same > problem with __size_t as FreeBSD does, since it inherits many kernel > headers from FreeBSD. The patch looks obvious to me, and I'll be happy to apply for Robert if approved. Any taker? Gerald 2012-01-29 Robert Millan * ginclude/stddef.h [__FreeBSD_kernel__] (__size_t): Do not define. Index: ginclude/stddef.h === --- ginclude/stddef.h (revision 183670) +++ ginclude/stddef.h (working copy) @@ -200,7 +200,7 @@ #define ___int_size_t_h #define _GCC_SIZE_T #define _SIZET_ -#if defined (__FreeBSD__) && (__FreeBSD__ >= 5) +#if (defined (__FreeBSD__) && (__FreeBSD__ >= 5)) || defined(__FreeBSD_kernel__) /* __size_t is a typedef on FreeBSD 5!, must not trash it. */ #else #define __size_t
