Re: [PATCH] i386, testsuite: adjust asm patterns

[Fangrui Song]

On Sun, Feb 11, 2024 at 11:12 AM Mike Stump  wrote:
>
> On Feb 10, 2024, at 10:07 AM, FX Coudert  wrote:
> >
> > The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is 
> > partly because symbols are prefixed with underscore, and also because the 
> > order of operands in the addition is reversed (but I think it’s valid 
> > still). The code generated is this:
> >
> > _func:
> > LFB0:
> >pushq   %rbp
> > LCFI0:
> >movq%rsp, %rbp
> > LCFI1:
> > # 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 
> > 1
> >@ _func
> > # 0 "" 2
> > # 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 
> > 1
> >@ 4+_var
> > # 0 "" 2
> >nop
> >popq%rbp
> > LCFI2:
> >ret
> >
> >
> >
> > I’m adjusting the pattern accordingly.
> > OK to push?
>
> Ok.

Thanks for commit bbf05e3753c0fd49f1a3bf23897fa96d052ddae9!



-- 
宋方睿

Re: [PATCH] i386, testsuite: adjust asm patterns

[Mike Stump]

On Feb 10, 2024, at 10:07 AM, FX Coudert  wrote:
> 
> The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is 
> partly because symbols are prefixed with underscore, and also because the 
> order of operands in the addition is reversed (but I think it’s valid still). 
> The code generated is this:
> 
> _func:
> LFB0:
>pushq   %rbp
> LCFI0:
>movq%rsp, %rbp
> LCFI1:
> # 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
>@ _func
> # 0 "" 2
> # 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
>@ 4+_var
> # 0 "" 2
>nop
>popq%rbp
> LCFI2:
>ret
> 
> 
> 
> I’m adjusting the pattern accordingly.
> OK to push?

Ok.