Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.
On Mon, 20 May 2024 at 15:23, Nick Clifton wrote: > > Hi Christophe, > > > I have a follow-up one: I think the same applies to binutils, but I > > don't think any maintainer / contributor expressed an opinion, and > > IIUC patch policy for binutils is (lightly) documented at > > https://sourceware.org/binutils/wiki/HowToContribute > > Maybe Nick can update it? > > Done. Thanks! > > > (I don't have such rights) > > Would you like them ? It is easy enough to set up. > No need to bother :-) Christophe > Cheers >Nick > >
Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.
Hi Christophe, I have a follow-up one: I think the same applies to binutils, but I don't think any maintainer / contributor expressed an opinion, and IIUC patch policy for binutils is (lightly) documented at https://sourceware.org/binutils/wiki/HowToContribute Maybe Nick can update it? Done. (I don't have such rights) Would you like them ? It is easy enough to set up. Cheers Nick
Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.
On 4/25/24 14:32, Richard Biener wrote: > > >> Am 25.04.2024 um 17:44 schrieb Carlos O'Donell : >> >> Discussion is here: >> https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=v8ka9g5eecdnk3bdhfnzjumpvc+hedmkvj...@mail.gmail.com/ >> >> Rough consensus from Jakub Jelinek, Richard Biener and others is >> that maintainers are for the change. > > Ok Pushed. Thanks for helping me move this forward. I look forward to pre-commit CI across all the projects. Helping Linaro make forward progress here is my primary goal. -- Cheers, Carlos.
Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.
On Fri, 26 Apr 2024 at 10:25, Christophe Lyon wrote: > > On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell wrote: > > > > Discussion is here: > > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=v8ka9g5eecdnk3bdhfnzjumpvc+hedmkvj...@mail.gmail.com/ > > > > Rough consensus from Jakub Jelinek, Richard Biener and others is > > that maintainers are for the change. > > > > This changes the contribution notes to allow it. > > Thank you Carlos for the patch and helping with the discussions! > > Christophe > And BTW sorry I wasn't able to attend the meeting yesterday, thanks Thiago for raising the question. I have a follow-up one: I think the same applies to binutils, but I don't think any maintainer / contributor expressed an opinion, and IIUC patch policy for binutils is (lightly) documented at https://sourceware.org/binutils/wiki/HowToContribute Maybe Nick can update it? (I don't have such rights) Thanks, Christophe > > --- > > htdocs/contribute.html | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/htdocs/contribute.html b/htdocs/contribute.html > > index 7c1ae323..e8137edc 100644 > > --- a/htdocs/contribute.html > > +++ b/htdocs/contribute.html > > @@ -195,8 +195,9 @@ of your testing. > > > > The patch itself > > > > -Do not include generated files as part of the patch, just mention > > -them in the ChangeLog (e.g., "* configure: Regenerate."). > > +The patch should include everything you are changing (including > > +regenerated files which should be noted in the ChangeLog e.g. > > +"* configure: Regenerate."). > > > > > > > > -- > > 2.44.0 > >
Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.
On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell wrote: > > Discussion is here: > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=v8ka9g5eecdnk3bdhfnzjumpvc+hedmkvj...@mail.gmail.com/ > > Rough consensus from Jakub Jelinek, Richard Biener and others is > that maintainers are for the change. > > This changes the contribution notes to allow it. Thank you Carlos for the patch and helping with the discussions! Christophe > --- > htdocs/contribute.html | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/htdocs/contribute.html b/htdocs/contribute.html > index 7c1ae323..e8137edc 100644 > --- a/htdocs/contribute.html > +++ b/htdocs/contribute.html > @@ -195,8 +195,9 @@ of your testing. > > The patch itself > > -Do not include generated files as part of the patch, just mention > -them in the ChangeLog (e.g., "* configure: Regenerate."). > +The patch should include everything you are changing (including > +regenerated files which should be noted in the ChangeLog e.g. > +"* configure: Regenerate."). > > > > -- > 2.44.0 >
Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.
> Am 25.04.2024 um 17:44 schrieb Carlos O'Donell : > > Discussion is here: > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=v8ka9g5eecdnk3bdhfnzjumpvc+hedmkvj...@mail.gmail.com/ > > Rough consensus from Jakub Jelinek, Richard Biener and others is > that maintainers are for the change. Ok Richard > This changes the contribution notes to allow it. > --- > htdocs/contribute.html | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/htdocs/contribute.html b/htdocs/contribute.html > index 7c1ae323..e8137edc 100644 > --- a/htdocs/contribute.html > +++ b/htdocs/contribute.html > @@ -195,8 +195,9 @@ of your testing. > > The patch itself > > -Do not include generated files as part of the patch, just mention > -them in the ChangeLog (e.g., "* configure: Regenerate."). > +The patch should include everything you are changing (including > +regenerated files which should be noted in the ChangeLog e.g. > +"* configure: Regenerate."). > > > > -- > 2.44.0 >
