Re: [PATCH 1/2] Document HLE / RTM intrinsics
On 12 January 2013 16:28:41 Andi Kleen wrote: From: Andi Kleen +Returns _XBEGIN_STARTED when the transaction +started successfully (not this is not 0, so the constant has to be not this is not 0? Or note? Thanks, Sent with AquaMail for Android http://www.aqua-mail.com
Re: [PATCH 1/2] Document HLE / RTM intrinsics
On Sat, Jan 12, 2013 at 06:04:19PM +0100, Bernhard Reutner-Fischer wrote: > On 12 January 2013 16:28:41 Andi Kleen wrote: > >From: Andi Kleen > > >+Returns _XBEGIN_STARTED when the transaction > >+started successfully (not this is not 0, so the constant has to be > > not this is not 0? Or note? "note" Thanks. Will fix before comitting. -Andi
Re: [PATCH 1/2] Document HLE / RTM intrinsics
On Sat, Jan 12, 2013 at 6:20 PM, Andi Kleen wrote: > On Sat, Jan 12, 2013 at 06:04:19PM +0100, Bernhard Reutner-Fischer wrote: >> On 12 January 2013 16:28:41 Andi Kleen wrote: >> >From: Andi Kleen >> >> >+Returns _XBEGIN_STARTED when the transaction >> >+started successfully (not this is not 0, so the constant has to be >> >> not this is not 0? Or note? > > "note" > > Thanks. Will fix before comitting. I think (somewhere else) we agreed to only document intrinsics, not the __builtin_ia32_ variants (they are an implementation detail). Yes, we're not consistent with that, but we do miss a lot of documentation for these kind of builtins. I suppose we also do not document all intrinsics either (though that's desired, as we provide those headers - even manpages would be nice for them I suppose). Target maintainers? Thanks, Richard. > -Andi
Re: [PATCH 1/2] Document HLE / RTM intrinsics
> I think (somewhere else) we agreed to only document intrinsics, > not the __builtin_ia32_ variants (they are an implementation detail). They are all (poorly) documented. I didn't really document them, just list them. > Yes, we're not consistent with that, but we do miss a lot of > documentation for these kind of builtins. I suppose we also do not > document all intrinsics either (though that's desired, as we provide > those headers - even manpages would be nice for them I suppose). It would be nice if gcc had proper documentation for all the functions. But that's a lot of work. But I would like to have TSX properly documented at least. -Andi
Re: [PATCH 1/2] Document HLE / RTM intrinsics
On 01/12/2013 04:28 PM, Andi Kleen wrote: The TSX HLE/RTM intrinsics were missing documentation. Add this to the manual. Are these intrinsics restricted to free-standing implementations? Or are these instructions designed in such a way that they work as expected even if the threading library uses them internally? (That would be quite a feat.) -- Florian Weimer / Red Hat Product Security Team
Re: [PATCH 1/2] Document HLE / RTM intrinsics
On Sun, Jan 27, 2013 at 07:15:42PM +0100, Florian Weimer wrote: > On 01/12/2013 04:28 PM, Andi Kleen wrote: > > >The TSX HLE/RTM intrinsics were missing documentation. Add this to the > >manual. > > Are these intrinsics restricted to free-standing implementations? Or > are these instructions designed in such a way that they work as expected > even if the threading library uses them internally? (That would be > quite a feat.) They can be combined with a threading library, with some restrictions. See the manual for details. All transactions are flattened. http://software.intel.com/sites/default/files/m/a/b/3/4/d/41604-319433-012a.pdf chapter 8 "restrictions" may lead to not eliding or abort, but never to correctness problems. Documenting all that is out of scope for the gcc manual though. -Andi -- a...@linux.intel.com -- Speaking for myself only.
[PING] Re: [PATCH 1/2] Document HLE / RTM intrinsics
Andi Kleen writes: > From: Andi Kleen > > The TSX HLE/RTM intrinsics were missing documentation. Add this to the > manual. > > Ok for release / trunk? Could someone please review/approve this (documentation only) patch? Thanks. -Andi > 2013-01-11 Andi Kleen > > * doc/extend.texi: Document __ATOMIC_HLE_ACQUIRE, > __ATOMIC_HLE_RELEASE. Document __builtin_ia32 TSX intrincs. > Document _x* TSX intrinsics. -- a...@linux.intel.com -- Speaking for myself only
Re: [PING^2] Re: [PATCH 1/2] Document HLE / RTM intrinsics
Andi Kleen writes: PING^2!! > Andi Kleen writes: > >> From: Andi Kleen >> >> The TSX HLE/RTM intrinsics were missing documentation. Add this to the >> manual. >> >> Ok for release / trunk? > > Could someone please review/approve this (documentation only) patch? > Thanks. > > -Andi > >> 2013-01-11 Andi Kleen >> >> * doc/extend.texi: Document __ATOMIC_HLE_ACQUIRE, >> __ATOMIC_HLE_RELEASE. Document __builtin_ia32 TSX intrincs. >> Document _x* TSX intrinsics. -- a...@linux.intel.com -- Speaking for myself only
Re: [PING^3] Re: [PATCH 1/2] Document HLE / RTM intrinsics
Andi Kleen writes: PING^3 I'm about to give up on this, concluding that there is no interest in improving the gcc documentation. -Andi > Andi Kleen writes: > > PING^2!! > >> Andi Kleen writes: >> >>> From: Andi Kleen >>> >>> The TSX HLE/RTM intrinsics were missing documentation. Add this to the >>> manual. >>> >>> Ok for release / trunk? >> >> Could someone please review/approve this (documentation only) patch? > >> Thanks. >> >> -Andi >> >>> 2013-01-11 Andi Kleen >>> >>> * doc/extend.texi: Document __ATOMIC_HLE_ACQUIRE, >>> __ATOMIC_HLE_RELEASE. Document __builtin_ia32 TSX intrincs. >>> Document _x* TSX intrinsics. -- a...@linux.intel.com -- Speaking for myself only
