On 7/19/23 04:11, Xiao Zeng wrote:
This patch completes the recognition of Zicond when the select pattern with
condition eq or neq to non-zero (using equality as an example), namely:

1 rd = (rs2 == non-imm) ? 0 : rs1
2 rd = (rs2 == reg) ? 0 : rs1

At the same time, more Zicond non basic semantic test cases have been added.

gcc/ChangeLog:

        * config/riscv/riscv.cc (riscv_expand_conditional_move): Recognize 
Zicond.
I think this is handled by the changes from Raphael I just committed. But I do think we should take the testsuite work to verify the cases all work as expected.

Given the testcases from 3/5 are also on hold pending fixing the costing issues, I'm thinking to roll all the testsuite changes into a distinct patch, with the failing tests xfailed until we fix the costing work. But I definitely don't want to lose the tests.

jeff

Reply via email to