Re: [PATCH 4/5] combine: distribute_log_links for PARALLELs of SETs

2014-11-25 Thread Segher Boessenkool
On Tue, Nov 25, 2014 at 12:37:57PM -0700, Jeff Law wrote:
> This is OK once prereqs are approved.

That is only 3/5 now.

> You might consider pushing the two LOG_LINKs related patches forward 
> independently of the patch to rip apart the PARALLELs.  Though I think 
> that all of the patches are pretty close to being approved.  Your call.

I probably will; 2/5 (the "rip" patch) needs updating, and my patch stack
is much too high :-)  Not that [34]/5 do terribly much without 2/5.

Thanks for all the reviews,


Segher


Re: [PATCH 4/5] combine: distribute_log_links for PARALLELs of SETs

2014-11-25 Thread Jeff Law

On 11/14/14 12:19, Segher Boessenkool wrote:

Now that LOG_LINKS are per regno, we can distribute them on PARALLELs
just fine.  Do so.  This makes PARALLELs not lose their LOG_LINKS early
when e.g. a trivial reg-reg move is combined, so that they can be used
in more useful combinations as well.


2014-11-14  Segher Boessenkool  

gcc/
* combine.c (distribute_links): Handle multiple SETs.
So the code in distribute_links implies that we're not going to see hard 
register SUBREGs, so ignore my concerns with the prior patch in this 
series WRT hard register SUBREGs.



This is OK once prereqs are approved.

You might consider pushing the two LOG_LINKs related patches forward 
independently of the patch to rip apart the PARALLELs.  Though I think 
that all of the patches are pretty close to being approved.  Your call.


Jeff