Re: [PATCH 4/7] Remove gcc/params.* files.
Hi Martin, >> Please fix and properly follow testing procedures in the future. Just >> looking for FAILs is not enough: e.g. comparing mail-report.log before >> and after the patch would have immediately shown this. > > Note that the patch set was very huge and I had to test very many targets > at the same time. So that's why a fallout happened ;) understood. However, this would have shown up on any target and it's not the first time your testing missed non-FAIL regressions. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [PATCH 4/7] Remove gcc/params.* files.
On 11/12/19 10:13 PM, Rainer Orth wrote: Hi Martin, gcc/ChangeLog: 2019-11-06 Martin Liska * Makefile.in: Remove PARAMS_H and params.list and params.options. this has obviously not been tested properly: it completely broke gcc.dg/params/params.exp: Hello. Sorry for the breakage, I'm going to fix the issue soon. +ERROR: couldn't open "/var/gcc/regression/trunk/11.5-gcc/build/gcc/testsuite/gcc/../../params.options": no such file or directory [...] +ERROR: tcl error sourcing /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/para ms/params.exp. [...] once for every instance of parallel testing. Please fix and properly follow testing procedures in the future. Just looking for FAILs is not enough: e.g. comparing mail-report.log before and after the patch would have immediately shown this. Note that the patch set was very huge and I had to test very many targets at the same time. So that's why a fallout happened ;) Martin Rainer
Re: [PATCH 4/7] Remove gcc/params.* files.
Hi Martin, > gcc/ChangeLog: > > 2019-11-06 Martin Liska > > * Makefile.in: Remove PARAMS_H and params.list > and params.options. this has obviously not been tested properly: it completely broke gcc.dg/params/params.exp: +ERROR: couldn't open "/var/gcc/regression/trunk/11.5-gcc/build/gcc/testsuite/gcc/../../params.options": no such file or directory [...] +ERROR: tcl error sourcing /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/para ms/params.exp. [...] once for every instance of parallel testing. Please fix and properly follow testing procedures in the future. Just looking for FAILs is not enough: e.g. comparing mail-report.log before and after the patch would have immediately shown this. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
