Re: [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals as unsigned in char8_t modes.
On Mon, 8 Aug 2022, Tom Honermann via Gcc-patches wrote: > On 8/2/22 6:14 PM, Joseph Myers wrote: > > On Tue, 2 Aug 2022, Tom Honermann via Gcc-patches wrote: > > > > > This patch corrects handling of UTF-8 character literals in preprocessing > > > directives so that they are treated as unsigned types in char8_t enabled > > > C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). > > > Previously, > > > UTF-8 character literals were always treated as having the same type as > > > ordinary character literals (signed or unsigned dependent on target or use > > > of the -fsigned-char or -funsigned char options). > > OK in the absence of C++ maintainer objections within 72 hours. (This is > > the case where, when I added support for such literals for C (commit > > 7c5890cc0a0ecea0e88cc39e9fba6385fb579e61), I raised the question of > > whether they should be unsigned in the preprocessor for C++ as well.) > > Joseph, would you be so kind as to commit this patch series for me? I don't > have commit access. Thank you in advance! Done. -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals as unsigned in char8_t modes.
On 8/2/22 6:14 PM, Joseph Myers wrote: On Tue, 2 Aug 2022, Tom Honermann via Gcc-patches wrote: This patch corrects handling of UTF-8 character literals in preprocessing directives so that they are treated as unsigned types in char8_t enabled C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). Previously, UTF-8 character literals were always treated as having the same type as ordinary character literals (signed or unsigned dependent on target or use of the -fsigned-char or -funsigned char options). OK in the absence of C++ maintainer objections within 72 hours. (This is the case where, when I added support for such literals for C (commit 7c5890cc0a0ecea0e88cc39e9fba6385fb579e61), I raised the question of whether they should be unsigned in the preprocessor for C++ as well.) Joseph, would you be so kind as to commit this patch series for me? I don't have commit access. Thank you in advance! Tom.
Re: [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals as unsigned in char8_t modes.
On Tue, 2 Aug 2022, Tom Honermann via Gcc-patches wrote: > This patch corrects handling of UTF-8 character literals in preprocessing > directives so that they are treated as unsigned types in char8_t enabled > C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). Previously, > UTF-8 character literals were always treated as having the same type as > ordinary character literals (signed or unsigned dependent on target or use > of the -fsigned-char or -funsigned char options). OK in the absence of C++ maintainer objections within 72 hours. (This is the case where, when I added support for such literals for C (commit 7c5890cc0a0ecea0e88cc39e9fba6385fb579e61), I raised the question of whether they should be unsigned in the preprocessor for C++ as well.) -- Joseph S. Myers jos...@codesourcery.com
