Re: [PING] Enhance array types debug info. for Ada

2014-12-17 Thread Pierre-Marie de Rodat

On 12/15/2014 05:24 PM, Jakub Jelinek wrote:

Ok for trunk then.


All the 5 commits are submitted. Thank you very much for your review! :-)

--
Pierre-Marie de Rodat


Re: [PING] Enhance array types debug info. for Ada

2014-12-15 Thread Jakub Jelinek
On Mon, Dec 15, 2014 at 05:21:07PM +0100, Pierre-Marie de Rodat wrote:
 Ping for https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00058.html.

Ok for trunk then.

 On 12/01/2014 05:40 PM, Pierre-Marie de Rodat wrote:
 While I agree this might trigger compatibility issues with old
 debuggers, I don't know what to do assuming this change is not
 acceptable: should we add a kludge in add_scalar_info in order to force
 unsignedness when generating debugging information for Fortran?
 
 Here is a data point: I tried to debug gfortran.dg/array_function_2.f90
 build with my patches compiler for x86_64-linux with a GDB from an old GNAT
 Pro release (5.03a1, from 2005):
 
 (gdb) b array_function_2.f90:24
 (gdb) r
 (gdb) ptype q_in
 type = real*8 (0:-1,-6:-1)
 
 With a recent GDB, I have instead:
 (gdb) ptype q_in
 type = real(kind=8) (0:*,-6:*)
 
 Given that the only thing that my patches changed in the debug information
 for this example is the encoding of the arrays' lower bounds, everything
 looks fine, here.
 
 -- 
 Pierre-Marie de Rodat

Jakub


Re: [PING] Enhance array types debug info. for Ada

2014-10-07 Thread Pierre-Marie de Rodat

On 10/03/2014 06:41 PM, Jason Merrill wrote:

Patches 1-4 are OK.


+  bool pell_conversions = true;


I don't understand pell.  Do you mean strip?


Absolutely: I though it was correct English. I replaced all occurences 
of pell with strip. Updates patches will follow...


Thank you very much for your review! :-)

--
Pierre-Marie de Rodat


Re: [PING] Enhance array types debug info. for Ada

2014-10-03 Thread Jason Merrill

On 09/17/2014 10:38 AM, Pierre-Marie de Rodat wrote:

Patches 1-4 are OK.


+  bool pell_conversions = true;


I don't understand pell.  Do you mean strip?

Jason