Re: [Patch, fortran, RFC] PR 40958 Reduce size of module files

2011-11-29 Thread Thomas Koenig 

Hi Janne,


Regression-tested on x86_64-unknown-linux-gnu.  OK for trunk?


Nice! Ok for trunk.


Sende  ChangeLog
Sende  module.c
Übertrage Daten ..
Revision 181810 übertragen.

Thanks for the review!

Thomas

Re: [Patch, fortran, RFC] PR 40958 Reduce size of module files

2011-11-28 Thread Thomas Koenig 

Hello world,

the testing of the test patch I submitted earlier (Thanks Salvatore and
Joost!) has shown a performance increase, so here is a formal
submission.  No test case because this patch is not supposed to
change anything, just make module reading a bit more efficient.

Regression-tested on x86_64-unknown-linux-gnu.  OK for trunk?

Thomas

2011-11-28  Thomas Koenig  tkoe...@gcc.gnu.org

PR fortran/40958
* module.c (prev_module_line):  New variable.
(prev_module_column):  New variable.
(prev_character):  New variable.
(module_char):  Update the new variables.
(module_unget_char):  New function.
(parse_string):  Use module_unget_char.
(parse_integer):  Likewise.
(parse_name):  Likewise.
Index: module.c
===
--- module.c	(Revision 181745)
+++ module.c	(Arbeitskopie)
@@ -194,6 +194,8 @@ static char module_name[GFC_MAX_SYMBOL_LEN + 1];
 static bool specified_nonint, specified_int;
 
 static int module_line, module_column, only_flag;
+static int prev_module_line, prev_module_column, prev_character;
+
 static enum
 { IO_INPUT, IO_OUTPUT }
 iomode;
@@ -1036,6 +1038,10 @@ module_char (void)
   if (c == EOF)
 bad_module (Unexpected EOF);
 
+  prev_module_line = module_line;
+  prev_module_column = module_column;
+  prev_character = c;
+
   if (c == '\n')
 {
   module_line++;
@@ -1046,7 +1052,17 @@ module_char (void)
   return c;
 }
 
+/* Unget a character while remembering the line and column.  Works for
+   a single character only.  */
 
+static void
+module_unget_char (void)
+{
+  module_line = prev_module_line;
+  module_column = prev_module_column;
+  ungetc (prev_character, module_fp);
+}
+
 /* Parse a string constant.  The delimiter is guaranteed to be a
single quote.  */
 
@@ -1106,24 +1122,22 @@ parse_string (void)
 static void
 parse_integer (int c)
 {
-  module_locus m;
-
   atom_int = c - '0';
 
   for (;;)
 {
-  get_module_locus (m);
-
   c = module_char ();
   if (!ISDIGIT (c))
-	break;
+	{
+	  module_unget_char ();
+	  break;
+	}
 
   atom_int = 10 * atom_int + c - '0';
   if (atom_int  )
 	bad_module (Integer overflow);
 }
 
-  set_module_locus (m);
 }
 
 
@@ -1132,7 +1146,6 @@ parse_integer (int c)
 static void
 parse_name (int c)
 {
-  module_locus m;
   char *p;
   int len;
 
@@ -1141,13 +1154,14 @@ parse_name (int c)
   *p++ = c;
   len = 1;
 
-  get_module_locus (m);
-
   for (;;)
 {
   c = module_char ();
   if (!ISALNUM (c)  c != '_'  c != '-')
-	break;
+	{
+	  module_unget_char ();
+	  break;
+	}
 
   *p++ = c;
   if (++len  GFC_MAX_SYMBOL_LEN)
@@ -1156,11 +1170,6 @@ parse_name (int c)
 
   *p = '\0';
 
-  fseek (module_fp, -1, SEEK_CUR);
-  module_column = m.column + len - 1;
-
-  if (c == '\n')
-module_line--;
 }

Re: [Patch, fortran, RFC] PR 40958 Reduce size of module files

2011-11-28 Thread Janne Blomqvist 
On Mon, Nov 28, 2011 at 22:29, Thomas Koenig tkoe...@netcologne.de wrote:
 Hello world,

 the testing of the test patch I submitted earlier (Thanks Salvatore and
 Joost!) has shown a performance increase, so here is a formal
 submission.  No test case because this patch is not supposed to
 change anything, just make module reading a bit more efficient.

 Regression-tested on x86_64-unknown-linux-gnu.  OK for trunk?

        Thomas

 2011-11-28  Thomas Koenig  tkoe...@gcc.gnu.org

        PR fortran/40958
        * module.c (prev_module_line):  New variable.
        (prev_module_column):  New variable.
        (prev_character):  New variable.
        (module_char):  Update the new variables.
        (module_unget_char):  New function.
        (parse_string):  Use module_unget_char.
        (parse_integer):  Likewise.
        (parse_name):  Likewise.

Nice! Ok for trunk.


-- 
Janne Blomqvist

Re: [Patch, fortran, RFC] PR 40958 Reduce size of module files

2011-11-25 Thread Mikael Morin 
On Friday 25 November 2011 11:10:01 Janne Blomqvist wrote:
 Based on a brief inspection of the code, most if
 not all of these seeks are for a very short distance (typically peek a
 few bytes ahead in the stream, then seek back)
I'm afraid they aren't.
The moves are as follows (-: sequential, x: seek)
-- beginning of file
  - skip operator interfaces
  - skip user operators
  - skip commons, equivalences, and derived type extensions
  - register the offset of each symbol node and skip it
  -   (this is usually
  -the biggest part of the module)
  - read the symtree list and mark needed the associated symbols (if they are 
wanted)
-- end of file
  x go back to operator interfaces and load them
  - load user operators
  - load commons
  - load equivalences
  xxx now the required symbols are known, so for each one of them seek to 
its offset and load it. This requires a lot of seeks, and if the number of 
symbols, components etc is high in the module, they are not necessarily short 
distance
  x load derived type extensions


We'll see the results from Salvatore, but I'm not very optimistic.

Mikael