Re: [Patch,testsuite]: target-supports.exp: Disable -fprofile-generate for AVR
Georg-Johann Lay writes: > Index: lib/target-supports.exp > === > --- lib/target-supports.exp (revision 175811) > +++ lib/target-supports.exp (working copy) > @@ -497,6 +497,13 @@ proc check_profiling_available { test_wh > > # Tree profiling requires TLS runtime support. > if { $test_what == "-fprofile-generate" } { > + # Target AVR does not support profile generation because ^ Leave out the `Target' > + # it does not implement needed support functions. > + # A call to check_effective_target_tls_runtime won't > + # reveal that. Omit the second sentence: it isn't supposed to, but just documents a general requirement of -fprofile-generate. > + if { [istarget avr-*-*] } { > + return 0 > + } > return [check_effective_target_tls_runtime] > } > Index: gcc.dg/tree-ssa/vrp51.c > === > --- gcc.dg/tree-ssa/vrp51.c (revision 175811) > +++ gcc.dg/tree-ssa/vrp51.c (working copy) > @@ -1,6 +1,7 @@ > /* PR tree-optimization/28632 */ > /* { dg-do compile } */ > /* { dg-options "-O2 -ftree-vrp" } */ > +/* { dg-require-effective-target int32plus } */ > > void > v4 (unsigned a, unsigned b) This is completely unrelated to the first; please don't mix such patches in one post. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [Patch,testsuite]: target-supports.exp: Disable -fprofile-generate for AVR
Rainer Orth wrote: > Georg-Johann Lay writes: > >> Index: lib/target-supports.exp >> === >> --- lib/target-supports.exp (revision 175811) >> +++ lib/target-supports.exp (working copy) >> @@ -497,6 +497,13 @@ proc check_profiling_available { test_wh >> >> # Tree profiling requires TLS runtime support. >> if { $test_what == "-fprofile-generate" } { >> +# Target AVR does not support profile generation because > ^ Leave out the `Target' > >> +# it does not implement needed support functions. >> +# A call to check_effective_target_tls_runtime won't >> +# reveal that. > > Omit the second sentence: it isn't supposed to, but just documents a > general requirement of -fprofile-generate. > >> +if { [istarget avr-*-*] } { >> +return 0 >> +} >> return [check_effective_target_tls_runtime] >> } > >> Index: gcc.dg/tree-ssa/vrp51.c >> === >> --- gcc.dg/tree-ssa/vrp51.c (revision 175811) >> +++ gcc.dg/tree-ssa/vrp51.c (working copy) >> @@ -1,6 +1,7 @@ >> /* PR tree-optimization/28632 */ >> /* { dg-do compile } */ >> /* { dg-options "-O2 -ftree-vrp" } */ >> +/* { dg-require-effective-target int32plus } */ >> >> void >> v4 (unsigned a, unsigned b) > > This is completely unrelated to the first; please don't mix such patches > in one post. Sorry for the glitch. > > Thanks. > Rainer Here is a revised patch. Ok? Johann * lib/target-supports.exp (check_profiling_available): Disable profiling with -fprofile-generate for target avr. Index: lib/target-supports.exp === --- lib/target-supports.exp (revision 175811) +++ lib/target-supports.exp (working copy) @@ -497,6 +497,11 @@ proc check_profiling_available { test_wh # Tree profiling requires TLS runtime support. if { $test_what == "-fprofile-generate" } { + # AVR does not support profile generation because + # it does not implement needed support functions. + if { [istarget avr-*-*] } { + return 0 + } return [check_effective_target_tls_runtime] }
Re: [Patch,testsuite]: target-supports.exp: Disable -fprofile-generate for AVR
Georg-Johann Lay writes: > Here is a revised patch. > > Ok? I'd like to defer to the target maintainers here: they know their port, while I don't. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [Patch,testsuite]: target-supports.exp: Disable -fprofile-generate for AVR
2011/7/6 Rainer Orth : > Georg-Johann Lay writes: > >> Here is a revised patch. >> >> Ok? > > I'd like to defer to the target maintainers here: they know their port, > while I don't. > Approved. Denis.