Re: [Patch] Fix PR54814
On Sun, Jan 27, 2013 at 11:26 PM, Steven Bosscher stevenb@gmail.com wrote: On Sun, Jan 27, 2013 at 11:09 PM, Georg-Johann Lay wrote: The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 Ironically, this revision fixes a reload problem on x86/x86_64 -- which doesn't use reload anymore now... Does this mean the fix is rejected for 4.8? No, just that it probably helps to add a RM to the CC list. FWIW, it seems to me that this patch should go into 4.8, because the bug is probably not limited to AVR. Indeed, the fix also looks quite obvious though I know nothing about the code at all. Thus, ok from a RM perspective if a reload-affine person approves it. Thanks, Richard. Ciao! Steven
Re: [Patch] Fix PR54814
Richard Biener wrote: On Sun, Jan 27, 2013 at 11:26 PM, Steven Bosscher stevenb@gmail.com wrote: On Sun, Jan 27, 2013 at 11:09 PM, Georg-Johann Lay wrote: The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 Ironically, this revision fixes a reload problem on x86/x86_64 -- which doesn't use reload anymore now... Does this mean the fix is rejected for 4.8? No, just that it probably helps to add a RM to the CC list. FWIW, it seems to me that this patch should go into 4.8, because the bug is probably not limited to AVR. Indeed, the fix also looks quite obvious though I know nothing about the code at all. Thus, ok from a RM perspective if a reload-affine person approves it. The patch was originally by Bernd, but FWIW it looks good to me as well. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE ulrich.weig...@de.ibm.com
Re: [Patch] Fix PR54814
On 01/27/2013 03:26 PM, Steven Bosscher wrote: On Sun, Jan 27, 2013 at 11:09 PM, Georg-Johann Lay wrote: The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 Ironically, this revision fixes a reload problem on x86/x86_64 -- which doesn't use reload anymore now... Does this mean the fix is rejected for 4.8? No, just that it probably helps to add a RM to the CC list. FWIW, it seems to me that this patch should go into 4.8, because the bug is probably not limited to AVR. At this stage, I tend to be more conservative. However, it looks like Ulrich Richi have taken a looksie and think the patch is fine. I'm certainly not going to object. jeff
Re: [Patch] Fix PR54814
On 01/27/2013 03:09 PM, Georg-Johann Lay wrote: If not, it'll probably need release manager approval before it can go in. Please attach your patch to PR54814 and attach PR 54814 to the 4.9 pending patches meta bug. Does this mean the fix is rejected for 4.8? Not necessarily. We're in a regression bugfix only stage; so regressions can obviously be fixed. If a change does not fix a regression, then it really needs the release manager's approval to go forward at this stage. Jeff
Re: [Patch] Fix PR54814
On 01/28/2013 06:55 AM, Ulrich Weigand wrote: Richard Biener wrote: On Sun, Jan 27, 2013 at 11:26 PM, Steven Bosscher stevenb@gmail.com wrote: On Sun, Jan 27, 2013 at 11:09 PM, Georg-Johann Lay wrote: The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 Ironically, this revision fixes a reload problem on x86/x86_64 -- which doesn't use reload anymore now... Does this mean the fix is rejected for 4.8? No, just that it probably helps to add a RM to the CC list. FWIW, it seems to me that this patch should go into 4.8, because the bug is probably not limited to AVR. Indeed, the fix also looks quite obvious though I know nothing about the code at all. Thus, ok from a RM perspective if a reload-affine person approves it. The patch was originally by Bernd, but FWIW it looks good to me as well. Now that I know this is a regression, I've looked at it more closely and it looks good to me too. George-Johann, please install this onto the trunk. Thanks, Jeff
Re: [Patch] Fix PR54814
Georg-Johann Lay schrieb: Jeff Law schrieb: On 01/25/2013 11:41 AM, Georg-Johann Lay wrote: PR54814 causes spill fails because reload.c:find_valid_class_1 tests only one hard register instead of all hard registers of regno:mode in rclass: http://gcc.gnu.org/PR54814 The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 The patch is bootstrapped and tested on x86_64-linux and also fixes the spill fails that originally occurred on avr-unknown-one. Ok to apply? PR other/54814 * reload.c (find_valid_class_1): Use in_hard_reg_set_p instead of TEST_HARD_REG_BIT. Is this a regression relative to a prior version of GCC? Yes, it's 4.8 regression. 4.7 works and r190252 was only applied to 4.8 trunk. If not, it'll probably need release manager approval before it can go in. Please attach your patch to PR54814 and attach PR 54814 to the 4.9 pending patches meta bug. Does this mean the fix is rejected for 4.8? I found no 4.9 meta-bug in the 47 meta-bugs. You have th PR? http://gcc.gnu.org/bugzilla/buglist.cgi?keywords=meta-bug%2C%20keywords_type=allwordslist_id=51998cf_known_to_fail_type=allwordscf_known_to_work_type=allwordsquery_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=SUSPENDEDbug_status=WAITINGbug_status=REOPENEDproduct=gcc FYI, this bug breaks the avr port almost completely. Many real-world programs ICE.
Re: [Patch] Fix PR54814
On Sun, 27 Jan 2013, Georg-Johann Lay wrote: I found no 4.9 meta-bug in the 47 meta-bugs. You have th PR? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55996 -- Marc Glisse
Re: [Patch] Fix PR54814
On Sun, Jan 27, 2013 at 11:09 PM, Georg-Johann Lay wrote: The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 Ironically, this revision fixes a reload problem on x86/x86_64 -- which doesn't use reload anymore now... Does this mean the fix is rejected for 4.8? No, just that it probably helps to add a RM to the CC list. FWIW, it seems to me that this patch should go into 4.8, because the bug is probably not limited to AVR. Ciao! Steven
Re: [Patch] Fix PR54814
On 01/25/2013 11:41 AM, Georg-Johann Lay wrote: PR54814 causes spill fails because reload.c:find_valid_class_1 tests only one hard register instead of all hard registers of regno:mode in rclass: http://gcc.gnu.org/PR54814 The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 The patch is bootstrapped and tested on x86_64-linux and also fixes the spill fails that originally occured on avr-unknown-one. Ok to apply? PR other/54814 * reload.c (find_valid_class_1): Use in_hard_reg_set_p instead of TEST_HARD_REG_BIT. Is this a regression relative to a prior version of GCC? If not, it'll probably need release manager approval before it can go in. Please attach your patch to PR54814 and attach PR 54814 to the 4.9 pending patches meta bug. jeff
Re: [Patch] Fix PR54814
Jeff Law schrieb: On 01/25/2013 11:41 AM, Georg-Johann Lay wrote: PR54814 causes spill fails because reload.c:find_valid_class_1 tests only one hard register instead of all hard registers of regno:mode in rclass: http://gcc.gnu.org/PR54814 The patch was originally worked out by Bernd Schmidt and fixed a problem introduced in http://gcc.gnu.org/r190252 The patch is bootstrapped and tested on x86_64-linux and also fixes the spill fails that originally occurred on avr-unknown-one. Ok to apply? PR other/54814 * reload.c (find_valid_class_1): Use in_hard_reg_set_p instead of TEST_HARD_REG_BIT. Is this a regression relative to a prior version of GCC? Yes, it's 4.8 regression. 4.7 works and r190252 was only applied to 4.8 trunk. If not, it'll probably need release manager approval before it can go in. Please attach your patch to PR54814 and attach PR 54814 to the 4.9 pending patches meta bug. The patch *is* already attached, I can attach it again if that helps. Johann
