Re: [build] Avoid ld -v error message with Sun ld on SPARC
On 04/26/2011 05:25 PM, Rainer Orth wrote: David, Thanks Rainer, if you cons up a patch to add the .align directive I'll ACK that as well. here's the patch that I've been testing over the weekend. It caused no change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that configuration showed no testsuite regressions. Ok for mainline? it's been a week since I've submitted this patch. Or should I take it as preapproved? Thanks. Rainer 2011-04-15 David S. Millerda...@davemloft.net Rainer Orthr...@cebitec.uni-bielefeld.de * configure.ac (gcc_cv_as_sparc_gotdata_op): Specify alignment. * configure: Regenerate. diff --git a/gcc/configure.ac b/gcc/configure.ac --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -3270,6 +3270,7 @@ case $target in gcc_cv_as_sparc_gotdata_op,, [-K PIC], [.text +.align 4 foo: nop bar: I was waiting for David or Eric to approve it since I know nothing about this stuff. :) Paolo
Re: [build] Avoid ld -v error message with Sun ld on SPARC
From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Tue, 26 Apr 2011 17:25:56 +0200 David, Thanks Rainer, if you cons up a patch to add the .align directive I'll ACK that as well. here's the patch that I've been testing over the weekend. It caused no change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that configuration showed no testsuite regressions. Ok for mainline? it's been a week since I've submitted this patch. Or should I take it as preapproved? I'm sorry about this, I must have missed it inadvertantly. ACK to this patch, thanks for your contributions.
Re: [build] Avoid ld -v error message with Sun ld on SPARC
David, Thanks Rainer, if you cons up a patch to add the .align directive I'll ACK that as well. here's the patch that I've been testing over the weekend. It caused no change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that configuration showed no testsuite regressions. Ok for mainline? Thanks. Rainer 2011-04-15 David S. Miller da...@davemloft.net Rainer Orth r...@cebitec.uni-bielefeld.de * configure.ac (gcc_cv_as_sparc_gotdata_op): Specify alignment. * configure: Regenerate. diff --git a/gcc/configure.ac b/gcc/configure.ac --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -3270,6 +3270,7 @@ case $target in gcc_cv_as_sparc_gotdata_op,, [-K PIC], [.text +.align 4 foo: nop bar: -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [build] Avoid ld -v error message with Sun ld on SPARC
David Miller da...@davemloft.net writes: Thanks Rainer, if you cons up a patch to add the .align directive I'll ACK that as well. That's my plan: I'll include such a patch in my S8 to S11 bootstraps over the weekend to make sure nothing breaks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [build] Avoid ld -v error message with Sun ld on SPARC
David Miller da...@davemloft.net writes: From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Tue, 12 Apr 2011 15:00:53 +0200 On Solaris 10, as assembles the test just fine, but ld cannot deal with gas 2.21 output: ld: fatal: relocation error: R_SPARC_GOTDATA_HIX22: file gotdata.o: symbol unknown: offset 0xff370163 is non-aligned ld: fatal: relocation error: R_SPARC_GOTDATA_LOX10: file gotdata.o: symbol unknown: offset 0xff370167 is non-aligned ld: fatal: file gotdata: creation interrupted: Error 0 Really strange error message, could you see if adding something as simply as .align 4 after the .text in the test assembler makes this go away? yep, that does the trick. Ok for mainline? I'm fine with this patch, we can try to attack the above problem independently. Thanks, installed. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [build] Avoid ld -v error message with Sun ld on SPARC
From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Wed, 13 Apr 2011 19:16:32 +0200 David Miller da...@davemloft.net writes: From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Tue, 12 Apr 2011 15:00:53 +0200 On Solaris 10, as assembles the test just fine, but ld cannot deal with gas 2.21 output: ld: fatal: relocation error: R_SPARC_GOTDATA_HIX22: file gotdata.o: symbol unknown: offset 0xff370163 is non-aligned ld: fatal: relocation error: R_SPARC_GOTDATA_LOX10: file gotdata.o: symbol unknown: offset 0xff370167 is non-aligned ld: fatal: file gotdata: creation interrupted: Error 0 Really strange error message, could you see if adding something as simply as .align 4 after the .text in the test assembler makes this go away? yep, that does the trick. Ok for mainline? I'm fine with this patch, we can try to attack the above problem independently. Thanks, installed. Thanks Rainer, if you cons up a patch to add the .align directive I'll ACK that as well.
Re: [build] Avoid ld -v error message with Sun ld on SPARC
David Miller da...@davemloft.net writes: From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Mon, 11 Apr 2011 14:57:58 +0200 The follwing patch uses the easy way out and just tests ld_ver. Tested with make configure-gcc on sparc-sun-solaris2.11 with Sun as/ld, GNU as/Sun ld, and GNU as/ld without change to gcc/auto-host.h and no linker error. Just out of curiosity, do the Sun tools pass the GOTDATA_OP test? It depends: as/ld gas/ld gas/gld Solaris 8 no no yes Solaris 9 no no yes Solaris 10 yes no yes Solaris 11 yes yes yes On Solaris 8 and 9, as fails to assemble the testcase, with gas, ld SEGVs when linking. On Solaris 10, as assembles the test just fine, but ld cannot deal with gas 2.21 output: ld: fatal: relocation error: R_SPARC_GOTDATA_HIX22: file gotdata.o: symbol unknown: offset 0xff370163 is non-aligned ld: fatal: relocation error: R_SPARC_GOTDATA_LOX10: file gotdata.o: symbol unknown: offset 0xff370167 is non-aligned ld: fatal: file gotdata: creation interrupted: Error 0 On Solaris 11, all is fine. I get the same results with an unmodifed tree and the following simplified version of my patch. Ok for mainline? Rainer 2011-04-09 Rainer Orth r...@cebitec.uni-bielefeld.de * configure.ac (gcc_cv_as_sparc_gotdata_op): Remove GNU ld check. * configure: Regenerate. diff --git a/gcc/configure.ac b/gcc/configure.ac --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -3305,17 +3305,13 @@ bar: ld[[%l7 + %g1]], %g2, %gdop(foo)], [if test x$gcc_cv_ld != x \ $gcc_cv_ld -o conftest conftest.o -G /dev/null 21; then - if $gcc_cv_ld -v | grep GNU /dev/null 21; then - if test x$gcc_cv_objdump != x; then - if $gcc_cv_objdump -s -j .text conftest 2 /dev/null \ -| grep ' 0304 82186004 c405c001' /dev/null 21; then + if test x$gcc_cv_objdump != x; then + if $gcc_cv_objdump -s -j .text conftest 2 /dev/null \ + | grep ' 0304 82186004 c405c001' /dev/null 21; then gcc_cv_as_sparc_gotdata_op=no - else + else gcc_cv_as_sparc_gotdata_op=yes - fi fi - else - gcc_cv_as_sparc_gotdata_op=yes fi fi rm -f conftest], -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [build] Avoid ld -v error message with Sun ld on SPARC
From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Tue, 12 Apr 2011 15:00:53 +0200 On Solaris 10, as assembles the test just fine, but ld cannot deal with gas 2.21 output: ld: fatal: relocation error: R_SPARC_GOTDATA_HIX22: file gotdata.o: symbol unknown: offset 0xff370163 is non-aligned ld: fatal: relocation error: R_SPARC_GOTDATA_LOX10: file gotdata.o: symbol unknown: offset 0xff370167 is non-aligned ld: fatal: file gotdata: creation interrupted: Error 0 Really strange error message, could you see if adding something as simply as .align 4 after the .text in the test assembler makes this go away? On Solaris 11, all is fine. I get the same results with an unmodifed tree and the following simplified version of my patch. Ok for mainline? I'm fine with this patch, we can try to attack the above problem independently.
Re: [build] Avoid ld -v error message with Sun ld on SPARC
From: Rainer Orth r...@cebitec.uni-bielefeld.de Date: Mon, 11 Apr 2011 14:57:58 +0200 The follwing patch uses the easy way out and just tests ld_ver. Tested with make configure-gcc on sparc-sun-solaris2.11 with Sun as/ld, GNU as/Sun ld, and GNU as/ld without change to gcc/auto-host.h and no linker error. Just out of curiosity, do the Sun tools pass the GOTDATA_OP test?
