Re: [build] Link genmatch with $(LIBINTL)
On Wed, Oct 22, 2014 at 05:53:22PM +0200, Rainer Orth wrote: 2014-10-22 Rainer Orth r...@cebitec.uni-bielefeld.de * Makefile.in (build/genmatch(build_exeext)): Add $(LIBINTL) to Shouldn't that be build/genmatch$(build_exeext) , both in the ChangeLog and more importantly, in the patch? BUILD_LIBS. Add $(LIBINTL_DEP) dependency. diff --git a/gcc/Makefile.in b/gcc/Makefile.in --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -2519,8 +2519,9 @@ genprog = $(genprogerr) check checksum c # These programs need libs over and above what they get from the above list. build/genautomata$(build_exeext) : BUILD_LIBS += -lm - -build/genmatch$(build_exeext) : $(CPPLIB) $(LIBIBERTY) \ +build/genmatch(build_exeext) : BUILD_LIBS += $(LIBINTL) + +build/genmatch$(build_exeext) : $(CPPLIB) $(LIBIBERTY) $(LIBINTL_DEP) \ $(BUILD_ERRORS) build/vec.o build/hash-table.o # These programs are not linked with the MD reader. -- - Rainer Orth, Center for Biotechnology, Bielefeld University Jakub
Re: [build] Link genmatch with $(LIBINTL)
I reported the same problem in a separate thread. On AIX it needs LIBINTL and LIBICONV. Index: Makefile.in === --- Makefile.in (revision 216542) +++ Makefile.in (working copy) @@ -2520,7 +2520,7 @@ # These programs need libs over and above what they get from the above list. build/genautomata$(build_exeext) : BUILD_LIBS += -lm -build/genmatch$(build_exeext) : $(CPPLIB) $(LIBIBERTY) \ +build/genmatch$(build_exeext) : $(CPPLIB) $(LIBIBERTY) $(LIBINTL) $(LIBICONV) \ $(BUILD_ERRORS) build/vec.o build/hash-table.o # These programs are not linked with the MD reader. Thanks, David
Re: [build] Link genmatch with $(LIBINTL)
On Wed, 22 Oct 2014, Rainer Orth wrote: 2014-10-22 Rainer Orth r...@cebitec.uni-bielefeld.de * Makefile.in (build/genmatch(build_exeext)): Add $(LIBINTL) to BUILD_LIBS. Add $(LIBINTL_DEP) dependency. No, this doesn't look right. A program built for the build system needs to use build versions of all relevant libraries, not host versions. That means $(BUILD_LIBIBERTY) not host libiberty, and build versions of libcpp and libintl if those are now needed for something built for the build system. That in turn needs toplevel changes to add libcpp and intl to build_modules. -- Joseph S. Myers jos...@codesourcery.com
Re: [build] Link genmatch with $(LIBINTL)
On October 22, 2014 7:13:41 PM CEST, David Edelsohn dje@gmail.com wrote: I reported the same problem in a separate thread. On AIX it needs LIBINTL and LIBICONV. I wonder what ends up linking those with Linux? Or is all the features available from glibc? Fixed patch is OK. Thanks, Richard. Index: Makefile.in === --- Makefile.in (revision 216542) +++ Makefile.in (working copy) @@ -2520,7 +2520,7 @@ # These programs need libs over and above what they get from the above list. build/genautomata$(build_exeext) : BUILD_LIBS += -lm -build/genmatch$(build_exeext) : $(CPPLIB) $(LIBIBERTY) \ +build/genmatch$(build_exeext) : $(CPPLIB) $(LIBIBERTY) $(LIBINTL) $(LIBICONV) \ $(BUILD_ERRORS) build/vec.o build/hash-table.o # These programs are not linked with the MD reader. Thanks, David
Re: [build] Link genmatch with $(LIBINTL)
On Wed, Oct 22, 2014 at 1:31 PM, Richard Biener rguent...@suse.de wrote: On October 22, 2014 7:13:41 PM CEST, David Edelsohn dje@gmail.com wrote: I reported the same problem in a separate thread. On AIX it needs LIBINTL and LIBICONV. I wonder what ends up linking those with Linux? Or is all the features available from glibc? The dependency comes from libcpp. Thanks, David
Re: [build] Link genmatch with $(LIBINTL)
On October 22, 2014 7:19:33 PM CEST, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 22 Oct 2014, Rainer Orth wrote: 2014-10-22 Rainer Orth r...@cebitec.uni-bielefeld.de * Makefile.in (build/genmatch(build_exeext)): Add $(LIBINTL) to BUILD_LIBS. Add $(LIBINTL_DEP) dependency. No, this doesn't look right. A program built for the build system needs to use build versions of all relevant libraries, not host versions. That means $(BUILD_LIBIBERTY) not host libiberty, and build versions of libcpp and libintl if those are now needed for something built for the build system. That in turn needs toplevel changes to add libcpp and intl to build_modules. I suppose we should build the build variant of libcpp without NLS support instead. Richard.
Re: [build] Link genmatch with $(LIBINTL)
On Wed, 22 Oct 2014, Richard Biener wrote: On October 22, 2014 7:19:33 PM CEST, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 22 Oct 2014, Rainer Orth wrote: 2014-10-22 Rainer Orth r...@cebitec.uni-bielefeld.de * Makefile.in (build/genmatch(build_exeext)): Add $(LIBINTL) to BUILD_LIBS. Add $(LIBINTL_DEP) dependency. No, this doesn't look right. A program built for the build system needs to use build versions of all relevant libraries, not host versions. That means $(BUILD_LIBIBERTY) not host libiberty, and build versions of libcpp and libintl if those are now needed for something built for the build system. That in turn needs toplevel changes to add libcpp and intl to build_modules. I suppose we should build the build variant of libcpp without NLS support instead. Indeed, that would avoid various complications such as configure options for where to find libiconv only being correct for the host and not the build system. -- Joseph S. Myers jos...@codesourcery.com
