Re: [committed] arc: Fail conditional move expand patterns

2022-02-25 Thread Robin Dapp via Gcc-patches
> If the movcc comparison is not valid it triggers an assert in the
> current implementation.  This behavior is not needed as we can FAIL
> the movcc expand pattern.

In case of a MODE_CC comparison you can also just return it as described
here https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104154

or here: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590639.html

If there already is a "CC comparison" the backend does not need to
create one and ifcvt can make use of this, creating better sequences.

Regards
 Robin


Re: [committed] arc: Fail conditional move expand patterns

2022-02-28 Thread Claudiu Zissulescu Ianculescu via Gcc-patches
Hi Robin,

I don't know how I missed your arc related patch, I'll bootstrap and test
your patch asap.

Thanks,
Claudiu


On Fri, Feb 25, 2022 at 3:29 PM Robin Dapp  wrote:

> > If the movcc comparison is not valid it triggers an assert in the
> > current implementation.  This behavior is not needed as we can FAIL
> > the movcc expand pattern.
>
> In case of a MODE_CC comparison you can also just return it as described
> here https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104154
>
> or here:
> https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590639.html
>
> If there already is a "CC comparison" the backend does not need to
> create one and ifcvt can make use of this, creating better sequences.
>
> Regards
>  Robin
>