Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)
On 03/18/2011 06:16 PM, dnovi...@google.com wrote: Paolo, Splitting this test fixes the failures I described in http://gcc.gnu.org/ml/libstdc++/2011-03/msg00076.html OK for trunk? Sure, it's Ok. A nit, however: we have been using quite consistently the *_neg suffix for such kind of testcases, I think mixed-mode-1_neg.cc and mixed-mode-2_neg.cc are better names. Paolo.
Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)
On Fri, Mar 18, 2011 at 13:23, Paolo Carlini paolo.carl...@oracle.com wrote: On 03/18/2011 06:16 PM, dnovi...@google.com wrote: Paolo, Splitting this test fixes the failures I described in http://gcc.gnu.org/ml/libstdc++/2011-03/msg00076.html OK for trunk? Sure, it's Ok. A nit, however: we have been using quite consistently the *_neg suffix for such kind of testcases, I think mixed-mode-1_neg.cc and mixed-mode-2_neg.cc are better names. Will do. Thanks. Diego.
Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)
On 03/18/2011 06:29 PM, Diego Novillo wrote: Will do. Thanks. Sorry again - otherwise I have to do it myself anyway: why don't you split it a more meaningful way, like splitting out all the comparisons? That would avoid the naming issue in the first place. Thanks, Paolo.
Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)
On Fri, Mar 18, 2011 at 13:31, Paolo Carlini paolo.carl...@oracle.com wrote: On 03/18/2011 06:29 PM, Diego Novillo wrote: Will do. Thanks. Sorry again - otherwise I have to do it myself anyway: why don't you split it a more meaningful way, like splitting out all the comparisons? That would avoid the naming issue in the first place. I can split it any way you prefer. You mean create 14 files? Or two files, one with all the bad_cmp another with the bad_op ? Diego.
Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)
Hi, Like this? Tested on my insanely deep tree and on mainline on x86_64. Sure. Thanks, Paolo
