Re: [ping] Fix error recovery issue with alias

2013-09-01 Thread Eric Botcazou 
 The test still fails with the following change:
 
 --- /opt/gcc/_clean/gcc/testsuite/gnat.dg/specs/linker_alias.ads2013-08-18
 17:39:22.0 +0200 +++
 /opt/gcc/work/gcc/testsuite/gnat.dg/specs/linker_alias.ads2013-08-19
 08:52:35.0 +0200 @@ -5,5 +5,6 @@ package Linker_Alias is
 Var : Integer;  -- { dg-error aliased to undefined symbol }
 pragma Export (C, Var, my_var);
 pragma Linker_Alias (Var, var2);
 +   pragma Weak_External (Var);
 
  end Linker_Alias;

OK, I've installed the following patchlet instead, thanks.


2013-09-01  Eric Botcazou  ebotca...@adacore.com

* gnat.dg/specs/linker_alias.ads: Skip on Darwin.


-- 
Eric BotcazouIndex: gnat.dg/specs/linker_alias.ads
===
--- gnat.dg/specs/linker_alias.ads	(revision 202141)
+++ gnat.dg/specs/linker_alias.ads	(working copy)
@@ -1,4 +1,5 @@
 -- { dg-do compile }
+-- { dg-skip-if missing alias support { *-*-darwin* } }
 
 package Linker_Alias is

Re: [ping] Fix error recovery issue with alias

2013-08-19 Thread Dominique Dhumieres 
 Can you try and add

  pragma Weak_External (Var);

on line 8 and see whether it passes?  If so, you can commit the patchlet.

The test still fails with the following change:

--- /opt/gcc/_clean/gcc/testsuite/gnat.dg/specs/linker_alias.ads
2013-08-18 17:39:22.0 +0200
+++ /opt/gcc/work/gcc/testsuite/gnat.dg/specs/linker_alias.ads  2013-08-19 
08:52:35.0 +0200
@@ -5,5 +5,6 @@ package Linker_Alias is
Var : Integer;  -- { dg-error aliased to undefined symbol }
pragma Export (C, Var, my_var);
pragma Linker_Alias (Var, var2);
+   pragma Weak_External (Var);
 
 end Linker_Alias;

Dominique

Re: [ping] Fix error recovery issue with alias

2013-08-18 Thread Jan Hubicka 
 http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01417.html
OK,
thank you!
Honza
 
 Thanks in advance.
 
 -- 
 Eric Botcazou

Re: [ping] Fix error recovery issue with alias

2013-08-18 Thread Dominique Dhumieres 
The test gnat.dg/specs/linker_alias.ads fails on x86_64-apple-darwin10:

FAIL: gnat.dg/specs/linker_alias.ads  (test for errors, line 5)
FAIL: gnat.dg/specs/linker_alias.ads (test for excess errors)

with

built-in:0:0: error: only weak aliases are supported in this configuration
gnatmake: /opt/gcc/work/gcc/testsuite/gnat.dg/specs/linker_alias.ads 
compilation error

Dominique

Re: [ping] Fix error recovery issue with alias

2013-08-18 Thread Eric Botcazou 
 The test gnat.dg/specs/linker_alias.ads fails on x86_64-apple-darwin10:
 
 FAIL: gnat.dg/specs/linker_alias.ads  (test for errors, line 5)
 FAIL: gnat.dg/specs/linker_alias.ads (test for excess errors)
 
 with
 
 built-in:0:0: error: only weak aliases are supported in this
 configuration gnatmake:
 /opt/gcc/work/gcc/testsuite/gnat.dg/specs/linker_alias.ads compilation
 error

Can you try and add

  pragma Weak_External (Var);

on line 8 and see whether it passes?  If so, you can commit the patchlet.

-- 
Eric Botcazou