Re: [testsuite] Adding -fno-pic to certain tests
Hi, Thank you for your review. Since the patch was aimed to fix tests and it is pretty small, is it posible to backport it to 4.8 branch? So we would not have those testfails on Android with new release. Alexander 2013/3/27 Kirill Yukhin : >> Ok with that change. > > Checked into trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00786.html > > Thanks, K
Re: [testsuite] Adding -fno-pic to certain tests
> Ok with that change. Checked into trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00786.html Thanks, K
Re: [testsuite] Adding -fno-pic to certain tests
On Sun, Mar 24, 2013 at 7:49 AM, Alexander Ivchenko wrote: > Hi, > > Finally got my hands on that: the attached patch adds the > "target nonpic" for those tests that require the avaiability of > functions defined in them. > > OK for trunk? For testsuite/gcc.target/i386/mmx-1.c you still don't use nopic. Please fix that. Ok with that change. Thanks, Richard. > thanks, > Alexander > > > 2013/1/10 Richard Biener : >> On Thu, Jan 10, 2013 at 2:50 PM, Alexander Ivchenko >> wrote: >>> Hi, >>> >>> It all begun with discussion here >>> http://gcc.gnu.org/ml/gcc/2012-11/msg00205.html >>> >>> Since -fpic option is turned on by default in Android we have certain test >>> fails. The reason for that is that those tests rely on the >>> availability of functions, defined in them >>> and with -fpic compiler conservatively assumes that they are >>> AVAIL_OVERWRITABLE. >>> >>> The attached patch adding -fno-pic option for tests that fail because of >>> that. >> >> I think this should be a dg-requires nopic instead. Otherwise testing >> with -fPIC/-fno-pic will not show expected differences. >> >> Richard. >> >>> 2013-01-10 Alexander Ivchenko >>> >>>* g++.dg/ipa/ivinline-1.C: Add -fno-pic option. >>>* g++.dg/ipa/ivinline-2.C: Likewise. >>>* g++.dg/ipa/ivinline-3.C: Likewise. >>>* g++.dg/ipa/ivinline-4.C: Likewise. >>>* g++.dg/ipa/ivinline-5.C: Likewise. >>>* g++.dg/ipa/ivinline-7.C: Likewise. >>>* g++.dg/ipa/ivinline-8.C: Likewise. >>>* g++.dg/ipa/ivinline-9.C: Likewise. >>>* g++.dg/cpp0x/noexcept03.C: Likewise. >>>* gcc.dg/const-1.c: Likewise. >>>* gcc.dg/ipa/pure-const-1.c: Likewise. >>>* gcc.dg/noreturn-8.c: Likewise. >>>* gcc.dg/tree-ssa/ipa-split-5.c: Likewise. >>>* gcc.dg/tree-ssa/loadpre6.c: Likewise. >>>* gcc.c-torture/execute/pr33992.c: Likewise. >>>* gcc.c-torture/execute/pr33992.x: New file. >>> >>> ok for mainline? >>> >>> thanks, >>> Alexander
Re: [testsuite] Adding -fno-pic to certain tests
Hi, Finally got my hands on that: the attached patch adds the "target nonpic" for those tests that require the avaiability of functions defined in them. OK for trunk? thanks, Alexander 2013/1/10 Richard Biener : > On Thu, Jan 10, 2013 at 2:50 PM, Alexander Ivchenko > wrote: >> Hi, >> >> It all begun with discussion here >> http://gcc.gnu.org/ml/gcc/2012-11/msg00205.html >> >> Since -fpic option is turned on by default in Android we have certain test >> fails. The reason for that is that those tests rely on the >> availability of functions, defined in them >> and with -fpic compiler conservatively assumes that they are >> AVAIL_OVERWRITABLE. >> >> The attached patch adding -fno-pic option for tests that fail because of >> that. > > I think this should be a dg-requires nopic instead. Otherwise testing > with -fPIC/-fno-pic will not show expected differences. > > Richard. > >> 2013-01-10 Alexander Ivchenko >> >>* g++.dg/ipa/ivinline-1.C: Add -fno-pic option. >>* g++.dg/ipa/ivinline-2.C: Likewise. >>* g++.dg/ipa/ivinline-3.C: Likewise. >>* g++.dg/ipa/ivinline-4.C: Likewise. >>* g++.dg/ipa/ivinline-5.C: Likewise. >>* g++.dg/ipa/ivinline-7.C: Likewise. >>* g++.dg/ipa/ivinline-8.C: Likewise. >>* g++.dg/ipa/ivinline-9.C: Likewise. >>* g++.dg/cpp0x/noexcept03.C: Likewise. >>* gcc.dg/const-1.c: Likewise. >>* gcc.dg/ipa/pure-const-1.c: Likewise. >>* gcc.dg/noreturn-8.c: Likewise. >>* gcc.dg/tree-ssa/ipa-split-5.c: Likewise. >>* gcc.dg/tree-ssa/loadpre6.c: Likewise. >>* gcc.c-torture/execute/pr33992.c: Likewise. >>* gcc.c-torture/execute/pr33992.x: New file. >> >> ok for mainline? >> >> thanks, >> Alexander adding_fno_pic_02.patch Description: Binary data
Re: [testsuite] Adding -fno-pic to certain tests
On Thu, Jan 10, 2013 at 2:50 PM, Alexander Ivchenko wrote: > Hi, > > It all begun with discussion here > http://gcc.gnu.org/ml/gcc/2012-11/msg00205.html > > Since -fpic option is turned on by default in Android we have certain test > fails. The reason for that is that those tests rely on the > availability of functions, defined in them > and with -fpic compiler conservatively assumes that they are > AVAIL_OVERWRITABLE. > > The attached patch adding -fno-pic option for tests that fail because of that. I think this should be a dg-requires nopic instead. Otherwise testing with -fPIC/-fno-pic will not show expected differences. Richard. > 2013-01-10 Alexander Ivchenko > >* g++.dg/ipa/ivinline-1.C: Add -fno-pic option. >* g++.dg/ipa/ivinline-2.C: Likewise. >* g++.dg/ipa/ivinline-3.C: Likewise. >* g++.dg/ipa/ivinline-4.C: Likewise. >* g++.dg/ipa/ivinline-5.C: Likewise. >* g++.dg/ipa/ivinline-7.C: Likewise. >* g++.dg/ipa/ivinline-8.C: Likewise. >* g++.dg/ipa/ivinline-9.C: Likewise. >* g++.dg/cpp0x/noexcept03.C: Likewise. >* gcc.dg/const-1.c: Likewise. >* gcc.dg/ipa/pure-const-1.c: Likewise. >* gcc.dg/noreturn-8.c: Likewise. >* gcc.dg/tree-ssa/ipa-split-5.c: Likewise. >* gcc.dg/tree-ssa/loadpre6.c: Likewise. >* gcc.c-torture/execute/pr33992.c: Likewise. >* gcc.c-torture/execute/pr33992.x: New file. > > ok for mainline? > > thanks, > Alexander
