Re: [wwwdocs] Add Ada's changelog entry
On Fri, 15 Apr 2022, Fernando Oleo Blanco wrote: > thank you for your comments. As you have picked up, HTML is not my > strongest language. > > I did not know that "<" and ">" had to scaped in HTML, I will try to > remember that. No worries, Fernando. "<" and ">" require special handling in HTML since the otherwise mark tags such as , , and the like. > Regarding the nested . Since I did not know HTML, I looked at how > nested structure/lists are generated. Since the changelog uses > sequences of and to indent/create a nested list, so I did. I > wanted to have a "title" (Pattern matching) and then have the > explanation with the code. Therefore, I copied the , sequence > to get another level of nesting. Ah, I see. I believe I've got it and committed the little adjustment below. > I checked my results by opening the file in Firefox (latest version) > and it renders properly as I would expect/as I just explained. Is this > not correct? Is Firefox trying to make it work/trying to understand > what I meant and reproducing it as such? Yes, browsers are relatively resilient and intelligently render things that technically may not be perfectly standards compliant - Postel's law and such. :) To validate a document, especially after bigger changes, the W3 validator ( https://validator.w3.org ) has proven very helpful. It allows you to easily upload a draft version and get immediate feedback. In any case, having documentation is more in important than detailed markup aspects, with which I and others can help - thank you for that! Gerald commit 771ba5f8386afe082d41f47d504b405784785ac7 Author: Gerald Pfeifer Date: Sat Apr 16 07:12:53 2022 -0600 gcc-12: Fix two markup issues diff --git a/htdocs/gcc-12/changes.html b/htdocs/gcc-12/changes.html index 9daf3c51..4f904bfd 100644 --- a/htdocs/gcc-12/changes.html +++ b/htdocs/gcc-12/changes.html @@ -221,14 +221,14 @@ a work-in-progress. exit when. The following expression is therefore now valid raise Constraint_Error with "Element is null" when Element = null; -Pattern matching +Pattern matching The case statement has been extended to cover records and arrays as well as finer grained casing on scalar types. In the future it is expected to provide more compile time guarantees when accessing discriminated fields. Case exhaustion is supported for pattern matching. An example would -be +be type Sign is (Neg, Zero, Pos); function Multiply (S1, S2 : Sign) return Sign is @@ -236,7 +236,7 @@ function Multiply (S1, S2 : Sign) return Sign is when (Neg, Neg) | (Pos, Pos) = Pos, when (Zero, ) | (, Zero) = Zero, when (Neg, Pos) | (Pos, Neg) = Neg); - +
Re: [wwwdocs] Add Ada's changelog entry
On Wed, 13 Apr 2022, Gerald Pfeifer wrote: > I am not familiar with that Emacs mode, but < and > are special characters > in HTML and have to be written as (less than) and (greater than) > respectively. Here is a second batch which I had missed originally. Also pushed... Gerald commit adefeb2b20b4bce5575bd550a48cb476e001987f Author: Gerald Pfeifer Date: Wed Apr 13 23:09:00 2022 -0600 gcc-12: More < and > escaping diff --git a/htdocs/gcc-12/changes.html b/htdocs/gcc-12/changes.html index 057d1274..9daf3c51 100644 --- a/htdocs/gcc-12/changes.html +++ b/htdocs/gcc-12/changes.html @@ -233,9 +233,9 @@ type Sign is (Neg, Zero, Pos); function Multiply (S1, S2 : Sign) return Sign is (case (S1, S2) is - when (Neg, Neg) | (Pos, Pos) => Pos, - when (Zero, <>) | (<>, Zero) => Zero, - when (Neg, Pos) | (Pos, Neg) => Neg); + when (Neg, Neg) | (Pos, Pos) = Pos, + when (Zero, ) | (, Zero) = Zero, + when (Neg, Pos) | (Pos, Neg) = Neg);
Re: [wwwdocs] Add Ada's changelog entry
Am Wed, 13 Apr 2022 23:04:17 -0600 (MDT) schrieb "Gerald Pfeifer" : > On Wed, 13 Apr 2022, Gerald Pfeifer wrote: > > This is the first batch of fixes. Pushed. > > Hmm, there is one issue that confused me a bit. What did you want to > relay by the following? > >+Pattern matching >+ >+ The case statement has been extended to > cover > > Currently that is a within a , which does not work. Did you > mean to skip the and have that after the nested ? > > Gerald Hi Gerald, thank you for your comments. As you have picked up, HTML is not my strongest language. I did not know that "<" and ">" had to scaped in HTML, I will try to remember that. Regarding the nested . Since I did not know HTML, I looked at how nested structure/lists are generated. Since the changelog uses sequences of and to indent/create a nested list, so I did. I wanted to have a "title" (Pattern matching) and then have the explanation with the code. Therefore, I copied the , sequence to get another level of nesting. I checked my results by opening the file in Firefox (latest version) and it renders properly as I would expect/as I just explained. Is this not correct? Is Firefox trying to make it work/trying to understand what I meant and reproducing it as such? Thank you for your feedback. Regards, Fer
Re: [wwwdocs] Add Ada's changelog entry
On 05/04/22 06:05 +, Arnaud Charlet wrote: Thank you for the feedback. Should I remove it and resuply the patch or can you/GCC maintainers do the modification before merging? Can you please resubmit it? I'll let others comment on the need to sign a contributor agreement, my understanding is that this is unavoidable, whether you're contributing code or documentation doesn't change this need AFAIU. Nothing is needed for changes which are not "legally significant changes", see https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html For legally significant changes we require either a copyright assignment to the FSF *or* DCO sign-off, which can be done by adding yourself to the DCO section of the MAINTAINERS file, or as described at https://gcc.gnu.org/dco.html
Re: [wwwdocs] Add Ada's changelog entry
On Wed, 13 Apr 2022, Gerald Pfeifer wrote: > This is the first batch of fixes. Pushed. Hmm, there is one issue that confused me a bit. What did you want to relay by the following? +Pattern matching + + The case statement has been extended to cover Currently that is a within a , which does not work. Did you mean to skip the and have that after the nested ? Gerald
Re: [wwwdocs] Add Ada's changelog entry
On Mon, 4 Apr 2022, Fernando Oleo Blanco via Gcc-patches wrote: > this is my first patch to GCC, if there is anything off, please, say > so. I have used the default HTML formatting that comes with Emacs. I am not familiar with that Emacs mode, but < and > are special characters in HTML and have to be written as (less than) and (greater than) respectively. On Mon, 11 Apr 2022, Arnaud Charlet via Gcc-patches wrote: > Thank you, I've just merged your contribution. This is the first batch of fixes. Pushed. Gerald commit 67c72bb30309882ce465519e97fb14592d18ff2c Author: Gerald Pfeifer Date: Wed Apr 13 22:43:05 2022 -0600 gcc-12: Properly escape < and >. diff --git a/htdocs/gcc-12/changes.html b/htdocs/gcc-12/changes.html index bd9e5122..057d1274 100644 --- a/htdocs/gcc-12/changes.html +++ b/htdocs/gcc-12/changes.html @@ -205,10 +205,10 @@ a work-in-progress. Fixed lower bound for unconstrained arrays. - type Matrix is array (Natural range 0 .. <>, Natural -range 0 .. <>) of Integer; is now valid. + type Matrix is array (Natural range 0 .. , + Natural range 0 .. ) of Integer; is now valid. Subtypes can also specify a lower bound: subtype -String_1 is String (1 .. <>);. Boundaries from slices +String_1 is String (1 .. );. Boundaries from slices will "slide" to the correct lower bound of the subtype.
Re: [wwwdocs] Add Ada's changelog entry
> Thank you all for your feedback and guidance. I have taken Eric's > feedback and deleted the relevant entry. > > Since I do not have write access, I cannot add myself to the > MAINTAINERS file. Therefore, I want to explicitly state that I am > submitting these patches under the DCO. I have read and accept the > indications and requirements listed in (https://gcc.gnu.org/dco.html). > > There are two patches, the original one, with the DCO signature at the > end and a second one, with the DCO signature too, with Eric's feedback. > > Should anything else be required, do not hesitate to indicate so. Thank you, I've just merged your contribution. Arno
Re: [wwwdocs] Add Ada's changelog entry
Am Tue, 5 Apr 2022 08:30:32 +0200 schrieb "Richard Biener" : > If you have git write access you should add yourself in the DCO > section in the MAINTAINERS file. Otherwise it has been said it's > enough to explicitly state in mail that you are contributing this > change under the Developer's Certificate of Origin Version 1.1 > (https://gcc.gnu.org/dco.html). > > Richard. > > > > > Arno Thank you all for your feedback and guidance. I have taken Eric's feedback and deleted the relevant entry. Since I do not have write access, I cannot add myself to the MAINTAINERS file. Therefore, I want to explicitly state that I am submitting these patches under the DCO. I have read and accept the indications and requirements listed in (https://gcc.gnu.org/dco.html). There are two patches, the original one, with the DCO signature at the end and a second one, with the DCO signature too, with Eric's feedback. Should anything else be required, do not hesitate to indicate so. Signed-off-by: Fernando Oleo Blanco From a2f402895ab87713882adf2faef6f587d6d01264 Mon Sep 17 00:00:00 2001 From: Fernando Oleo Blanco Date: Mon, 4 Apr 2022 23:22:43 +0200 Subject: [PATCH 1/2] Add Ada's entry in the v12 changelog --- htdocs/gcc-12/changes.html | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/htdocs/gcc-12/changes.html b/htdocs/gcc-12/changes.html index 4e1f6b0f..16351697 100644 --- a/htdocs/gcc-12/changes.html +++ b/htdocs/gcc-12/changes.html @@ -183,7 +183,84 @@ a work-in-progress. - +Ada + + Ada 2022 + +Added the -gnat2022 flag to indicate strict Ada + 2022 compliance. The old -gnat2020 flag is now + deprecated. +Support for Big Numbers (Annex G) has seen continuous + improvements. It is now cosidered complete. It is also proven to + be correct through the use of contracts and SPARK. +Continuous improvements to the Ada 2022 standard since GCC + 11. The main missing feature is support for the new + parallel keyword. However, some initial support has + already been put in place. +Greatly improved compile time support. More functions can now + have the with Static aspect and can be used in more + contexts. + + + Ada 2022 extensions. The use of the -gnatX flag is +necessary to access these features as they are not considered +stable or standard. + +Fixed lower bound for unconstrained arrays. + + type Matrix is array (Natural range 0 .. <>, Natural +range 0 .. <>) of Integer; is now valid. + Subtypes can also specify a lower bound: subtype +String_1 is String (1 .. <>);. Boundaries from slices +will "slide" to the correct lower bound of the subtype. + + +Generalized Object.Operand notation. The follwing + code is now valid V.Add_Element(42);, + with V being a vector, for example. +Additional when constructs. Keywords + return, goto and raise + can now use when in addition to the existing + exit when. The following expression is therefore + now valid raise Constraint_Error with "Element is null" + when Element = null; +Pattern matching + + The case statement has been extended to cover +records and arrays as well as finer grained casing on scalar +types. In the future it is expected to provide more compile +time guarantees when accessing discriminated fields. Case +exhaustion is supported for patter matching. An example would +be +type Sign is (Neg, Zero, Pos); + +function Multiply (S1, S2 : Sign) return Sign is + (case (S1, S2) is + when (Neg, Neg) | (Pos, Pos) => Pos, + when (Zero, <>) | (<>, Zero) => Zero, + when (Neg, Pos) | (Pos, Neg) => Neg); + + + + + + gnatfind and gnatxref, which were +already deprecated, have been removed. + Support for 128bit integers has beed added. + Greatly expanded code covered by contracts. Thanks to this work, +there are now several Ada standard libraries fully proven in SPARK +which means they have no runtime nor logical errors. They are +mostly numeric and string handling libraries. + Enable return-slot optimization for Pure +functions. + General optimizations, improvements and additions to the +standard library. Performance, correctness and in some cases +stability was improved. Memory pools have also seen some minor +enhancements. + Improvements to embedded-RTOS targets such as RTEMS, VxWorks and +QNX. Older targets were removed or cleaned. + Added some https://gcc.gnu.org/onlinedocs/gnat_rm/Security-Hardening-Features.html#Security-Hardening-Features;>hardening features. + C family -- 2.35.1 Signed-off-by: Fernando Oleo Blanco From d9c1233cff4122b6cfa328688fb88646effc8cfa Mon Sep 17 00:00:00 2001 From: Fernando Oleo Blanco Date: Tue, 5 Apr 2022 18:32:45 +0200 Subject: [PATCH 2/2] Correct 128bit, it was added in GCC 11 ---
Re: [wwwdocs] Add Ada's changelog entry
On Tue, Apr 5, 2022 at 8:06 AM Arnaud Charlet via Gcc-patches wrote: > > > Thank you for the feedback. Should I remove it and resuply the patch or > > can you/GCC maintainers do the modification before merging? > > Can you please resubmit it? > > I'll let others comment on the need to sign a contributor agreement, my > understanding is that this is unavoidable, whether you're contributing > code or documentation doesn't change this need AFAIU. If you have git write access you should add yourself in the DCO section in the MAINTAINERS file. Otherwise it has been said it's enough to explicitly state in mail that you are contributing this change under the Developer's Certificate of Origin Version 1.1 (https://gcc.gnu.org/dco.html). Richard. > > Arno
Re: [wwwdocs] Add Ada's changelog entry
> Thank you for the feedback. Should I remove it and resuply the patch or > can you/GCC maintainers do the modification before merging? Can you please resubmit it? I'll let others comment on the need to sign a contributor agreement, my understanding is that this is unavoidable, whether you're contributing code or documentation doesn't change this need AFAIU. Arno
Re: [wwwdocs] Add Ada's changelog entry
Am Mon, 04 Apr 2022 23:51:24 +0200 schrieb "Eric Botcazou" : > Thanks for your contribution. Small nit: > > + Support for 128bit integers has beed added. > > The support was already present in GCC 11, the criterion being the > use of the 'Max_Integer_Size attribute in system.ads. > > -- > Eric Botcazou > > Thank you for the feedback. Should I remove it and resuply the patch or can you/GCC maintainers do the modification before merging? Regards, -- Fernando Oleo Blanco https://irvise.xyz
Re: [wwwdocs] Add Ada's changelog entry
> this is my first patch to GCC, if there is anything off, please, say > so. I have used the default HTML formatting that comes with Emacs. I > have created the patch using the `git format-patch` utility. Thanks for your contribution. Small nit: + Support for 128bit integers has beed added. The support was already present in GCC 11, the criterion being the use of the 'Max_Integer_Size attribute in system.ads. -- Eric Botcazou
