Re: Announcement: Porting the Docs to Sphinx - tomorrow
On 11/11/22 22:10, Sandra Loosemore wrote: > On 11/11/22 13:52, Gerald Pfeifer wrote: >> On Tue, 8 Nov 2022, Martin Liška wrote: >>> After the migration, people should be able to build (and install) GCC >>> even if they miss Sphinx (similar happens now if you miss makeinfo). >> >> My nightly *install* (not build) on amd64-unknown-freebsd12.2 broke >> (from what I can tell due to this - it's been working fine most of >> the last several 1000 days): >> >> if [ -f doc/g++.1 ]; then rm -f >> /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; /usr/bin/install -c -m >> 644 doc/g++.1 /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; chmod a-x >> /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; fimake -C >> /scratch/tmp/gerald/GCC-HEAD/gcc/../doc man >> SOURCEDIR=/scratch/tmp/gerald/GCC-HEAD/gcc/fortran/doc/gfortran >> BUILDDIR=/scratch/tmp/gerald/OBJ--0954/gcc/doc/gfortran/man SPHINXBUILD= >> make[3]: make[3]: don't know how to make w. Stop >> make[3]: stopped in /scratch/tmp/gerald/GCC-HEAD/doc >> gmake[2]: *** [/scratch/tmp/gerald/GCC-HEAD/gcc/fortran/Make-lang.in:164: >> doc/gfortran/man/man/gfortran.1] Error 2 >> gmake[2]: Leaving directory '/scratch/tmp/gerald/OBJ--0954/gcc' >> gmake[1]: *** [Makefile:5310: install-strip-gcc] Error 2 >> gmake[1]: Leaving directory '/scratch/tmp/gerald/OBJ--0954' >> gmake: *** [Makefile:2734: install-strip] Error 2 >> >> (This appears to be the case with "make -j1 install-strip". Not sure where >> that "w" target is coming from?) > > I've seen something similar: "make install" seems to be passing an empty > SPHINXBUILD= option to the docs Makefile which is not equipped to handle > that. I know the fix is to get a recent-enough version of Sphinx installed > (and I'm going to work on that over the weekend), but it ought to fail more > gracefully, or not try to install docs that cannot be built without Sphinx. > > -Sandra > Can you please update the current master, you should get a proper error message. I'm going to take a look at make install-strip target. Martin
Re: Announcement: Porting the Docs to Sphinx - tomorrow
On 11/11/22 13:52, Gerald Pfeifer wrote: On Tue, 8 Nov 2022, Martin Liška wrote: After the migration, people should be able to build (and install) GCC even if they miss Sphinx (similar happens now if you miss makeinfo). My nightly *install* (not build) on amd64-unknown-freebsd12.2 broke (from what I can tell due to this - it's been working fine most of the last several 1000 days): if [ -f doc/g++.1 ]; then rm -f /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; /usr/bin/install -c -m 644 doc/g++.1 /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; chmod a-x /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; fimake -C /scratch/tmp/gerald/GCC-HEAD/gcc/../doc man SOURCEDIR=/scratch/tmp/gerald/GCC-HEAD/gcc/fortran/doc/gfortran BUILDDIR=/scratch/tmp/gerald/OBJ--0954/gcc/doc/gfortran/man SPHINXBUILD= make[3]: make[3]: don't know how to make w. Stop make[3]: stopped in /scratch/tmp/gerald/GCC-HEAD/doc gmake[2]: *** [/scratch/tmp/gerald/GCC-HEAD/gcc/fortran/Make-lang.in:164: doc/gfortran/man/man/gfortran.1] Error 2 gmake[2]: Leaving directory '/scratch/tmp/gerald/OBJ--0954/gcc' gmake[1]: *** [Makefile:5310: install-strip-gcc] Error 2 gmake[1]: Leaving directory '/scratch/tmp/gerald/OBJ--0954' gmake: *** [Makefile:2734: install-strip] Error 2 (This appears to be the case with "make -j1 install-strip". Not sure where that "w" target is coming from?) I've seen something similar: "make install" seems to be passing an empty SPHINXBUILD= option to the docs Makefile which is not equipped to handle that. I know the fix is to get a recent-enough version of Sphinx installed (and I'm going to work on that over the weekend), but it ought to fail more gracefully, or not try to install docs that cannot be built without Sphinx. -Sandra
Re: Announcement: Porting the Docs to Sphinx - tomorrow
On Tue, 8 Nov 2022, Martin Liška wrote: > After the migration, people should be able to build (and install) GCC > even if they miss Sphinx (similar happens now if you miss makeinfo). My nightly *install* (not build) on amd64-unknown-freebsd12.2 broke (from what I can tell due to this - it's been working fine most of the last several 1000 days): if [ -f doc/g++.1 ]; then rm -f /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; /usr/bin/install -c -m 644 doc/g++.1 /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; chmod a-x /home/gerald/gcc-ref12-amd64/share/man/man1/g++.1; fimake -C /scratch/tmp/gerald/GCC-HEAD/gcc/../doc man SOURCEDIR=/scratch/tmp/gerald/GCC-HEAD/gcc/fortran/doc/gfortran BUILDDIR=/scratch/tmp/gerald/OBJ--0954/gcc/doc/gfortran/man SPHINXBUILD= make[3]: make[3]: don't know how to make w. Stop make[3]: stopped in /scratch/tmp/gerald/GCC-HEAD/doc gmake[2]: *** [/scratch/tmp/gerald/GCC-HEAD/gcc/fortran/Make-lang.in:164: doc/gfortran/man/man/gfortran.1] Error 2 gmake[2]: Leaving directory '/scratch/tmp/gerald/OBJ--0954/gcc' gmake[1]: *** [Makefile:5310: install-strip-gcc] Error 2 gmake[1]: Leaving directory '/scratch/tmp/gerald/OBJ--0954' gmake: *** [Makefile:2734: install-strip] Error 2 (This appears to be the case with "make -j1 install-strip". Not sure where that "w" target is coming from?) Gerald
Re: Announcement: Porting the Docs to Sphinx - tomorrow
On Wed, Nov 9, 2022 at 6:11 PM Joseph Myers wrote: > > On Wed, 9 Nov 2022, Richard Biener via Gcc wrote: > > > I'd say that doing a trunk snapshot build every day as CI would be nice, we > > can then publish one once a week, skipping days where the build failed. > > Note that each snapshot should have diffs relative to the previous > published snapshot. Not relative to some other one that was not > published, for example. Sure, but diffs can be created from the two snapshot tarballs at publishing time. Richard. > > -- > Joseph S. Myers > jos...@codesourcery.com
Re: Announcement: Porting the Docs to Sphinx - tomorrow
On Wed, 9 Nov 2022, Richard Biener via Gcc wrote: > I'd say that doing a trunk snapshot build every day as CI would be nice, we > can then publish one once a week, skipping days where the build failed. Note that each snapshot should have diffs relative to the previous published snapshot. Not relative to some other one that was not published, for example. -- Joseph S. Myers jos...@codesourcery.com
Re: Announcement: Porting the Docs to Sphinx - tomorrow
Hi, On Wed, Nov 09, 2022 at 08:49:22AM +0100, Richard Biener via Gcc wrote: > On Wed, Nov 9, 2022 at 1:09 AM Sam James via Gcc-patches > wrote: > > > On 9 Nov 2022, at 00:00, Joseph Myers wrote: > > > On Tue, 8 Nov 2022, Sam James via Gcc wrote: > > > > If that's your expectation, that's fine, but I'd regard it as pretty > > serious if one didn't build, and I don't remember a time when it didn't. > > > > It's not like it's that much use if it fails to build on a bog-standard > > amd64 platform anyway, as if nothing else, you'd get a deluge > > of duplicate bug reports. > > I'd say that doing a trunk snapshot build every day as CI would be nice, we > can then publish one once a week, skipping days where the build failed. > > For release branches having generated files in the snapshots would be > even more useful and I very much hope the build there always succeeds. The current buildbot CI jobs already run various builds which just do a simple non-bootstrap build (plus some that do a full build and make check) to see if things work: https://builder.sourceware.org/buildbot/#/builders?tags=gcc=gcc-full If we make sure the relevant machine/containers contain the necessary prerequirements then can add the configure flags to some builders to make sure the docs are generated: https://sourceware.org/git/?p=builder.git;a=blob;f=README And make it sent warning emails (to gcc-testresults) when things break. Cheers, Mark
Re: Announcement: Porting the Docs to Sphinx - tomorrow
On Wed, Nov 9, 2022 at 1:09 AM Sam James via Gcc-patches wrote: > > > > > On 9 Nov 2022, at 00:00, Joseph Myers wrote: > > > > On Tue, 8 Nov 2022, Sam James via Gcc wrote: > > > >> Yes, please (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106899) > >> even for snapshots? Pretty please? :) > > > > I think we want snapshots to come out weekly even if the compiler or > > documentation build fails, which makes anything involving a build as part > > of the snapshot process problematic. > > If that's your expectation, that's fine, but I'd regard it as pretty > serious if one didn't build, and I don't remember a time when it didn't. > > It's not like it's that much use if it fails to build on a bog-standard > amd64 platform anyway, as if nothing else, you'd get a deluge > of duplicate bug reports. I'd say that doing a trunk snapshot build every day as CI would be nice, we can then publish one once a week, skipping days where the build failed. For release branches having generated files in the snapshots would be even more useful and I very much hope the build there always succeeds. Richard.
Re: Announcement: Porting the Docs to Sphinx - tomorrow
> On 9 Nov 2022, at 00:00, Joseph Myers wrote: > > On Tue, 8 Nov 2022, Sam James via Gcc wrote: > >> Yes, please (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106899) >> even for snapshots? Pretty please? :) > > I think we want snapshots to come out weekly even if the compiler or > documentation build fails, which makes anything involving a build as part > of the snapshot process problematic. If that's your expectation, that's fine, but I'd regard it as pretty serious if one didn't build, and I don't remember a time when it didn't. It's not like it's that much use if it fails to build on a bog-standard amd64 platform anyway, as if nothing else, you'd get a deluge of duplicate bug reports. signature.asc Description: Message signed with OpenPGP
Re: Announcement: Porting the Docs to Sphinx - tomorrow
On Tue, 8 Nov 2022, Sam James via Gcc wrote: > Yes, please (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106899) > even for snapshots? Pretty please? :) I think we want snapshots to come out weekly even if the compiler or documentation build fails, which makes anything involving a build as part of the snapshot process problematic. -- Joseph S. Myers jos...@codesourcery.com
Re: Announcement: Porting the Docs to Sphinx - tomorrow
> On 8 Nov 2022, at 13:55, Martin Liška wrote: > > Hi. > > Tomorrow in the morning (UTC time), I'm going to migrate the documentation > to Sphinx. The final version of the branch can be seen here: > > $ git fetch origin refs/users/marxin/heads/sphinx-final > $ git co FETCH_HEAD > > URL: https://splichal.eu/gccsphinx-final/ > > TL;DR; > > After the migration, people should be able to build (and install) GCC even > if they miss Sphinx (similar happens now if you miss makeinfo). However, > please > install Sphinx >= 5.3.0 (for manual and info pages - only *core* package is > necessary) [1] > > Steps following the migration: > > 1) update of web HTML (and PDF documentation) pages: > I prepared a script and tested our server has all what we need. > 2) gcc_release --enable-generated-files-in-srcdir: here I would like > to ask Joseph for cooperation Yes, please (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106899) even for snapshots? Pretty please? :) > 3) URL for diagnostics (used for warning) - will utilize [3] > 4) package source tarballs - https://gcc.gnu.org/onlinedocs/ (listed here) > 5) updating links from gcc.gnu.org that point to documentation > 6) removal of the further Texinfo leftovers > ... > Thanks for working on this. Very excited. > Cheers, > Martin Best, sam signature.asc Description: Message signed with OpenPGP