Re: C/C++ diagnostics guidelines (was: Re: [C PATCH] Enable initializing statics with COMPOUND_LITERAL_EXPR in C99 (PR c/63567))

2014-10-17 Thread Manuel López-Ibáñez
On 17 October 2014 20:04, Manuel López-Ibáñez  wrote:
> On 17 October 2014 19:33, Joseph S. Myers  wrote:
>> On Fri, 17 Oct 2014, Manuel López-Ibáñez wrote:
>>
>>> Thus, I drafted some guidelines
>>> at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines
>>>
>>> Please, could you take a look and comment whether I got it right/wrong?
>>
>> Yes, that looks right to me.
>
> Thanks!
>
> I added guidelines also about locations and warning options.

I believe there are also some rules about when to use some special
line-map functions that arise when warning about macros like NULL, but
I am not aware of the specifics. It would be useful if someone added
those.

Dodji, Paolo? Do you know what I'm talking about?

Cheers,

Manuel.


Re: C/C++ diagnostics guidelines (was: Re: [C PATCH] Enable initializing statics with COMPOUND_LITERAL_EXPR in C99 (PR c/63567))

2014-10-17 Thread Manuel López-Ibáñez
On 17 October 2014 19:33, Joseph S. Myers  wrote:
> On Fri, 17 Oct 2014, Manuel López-Ibáñez wrote:
>
>> Thus, I drafted some guidelines
>> at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines
>>
>> Please, could you take a look and comment whether I got it right/wrong?
>
> Yes, that looks right to me.

Thanks!

I added guidelines also about locations and warning options.

Cheers,

Manuel.


Re: C/C++ diagnostics guidelines (was: Re: [C PATCH] Enable initializing statics with COMPOUND_LITERAL_EXPR in C99 (PR c/63567))

2014-10-17 Thread Joseph S. Myers
On Fri, 17 Oct 2014, Manuel López-Ibáñez wrote:

> Thus, I drafted some guidelines
> at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines
> 
> Please, could you take a look and comment whether I got it right/wrong?

Yes, that looks right to me.

-- 
Joseph S. Myers
jos...@codesourcery.com