RE: Deque fiil/copy/move/copy_backward/move_backward/equal overloads
That's actually a solution to bug 90409, thanks for it :) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90409 Morwenn De : libstdc++-ow...@gcc.gnu.org de la part de François Dumont Envoyé : mercredi 19 juin 2019 19:32 À : libstd...@gcc.gnu.org; gcc-patches Objet : Deque fiil/copy/move/copy_backward/move_backward/equal overloads I wanted to implement Debug overloads for those already existing overloads but then realized that those algos could be generalized. This way we will benefit from the memmove replacement when operating with C array or std::array or std::vector iterators. I might do the same for lexicographical_compare one day. The ChangeLog below is quite huge so I attached it. I wonder if I could use deque::iterator and deque::const_iterator in place of the _Deque_iterator<> to reduce it ? Tested under Linux x86_64 normal and debug modes, ok to commit ? François
Re: Deque fiil/copy/move/copy_backward/move_backward/equal overloads
And thanks for noticing that not only user code will be improved but also our own algos ! I'll reference this PR if accepted. On 6/20/19 10:38 AM, Morwenn Ed wrote: That's actually a solution to bug 90409, thanks for it :) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90409 Morwenn *De :* libstdc++-ow...@gcc.gnu.org de la part de François Dumont *Envoyé :* mercredi 19 juin 2019 19:32 *À :* libstd...@gcc.gnu.org; gcc-patches *Objet :* Deque fiil/copy/move/copy_backward/move_backward/equal overloads I wanted to implement Debug overloads for those already existing overloads but then realized that those algos could be generalized. This way we will benefit from the memmove replacement when operating with C array or std::array or std::vector iterators. I might do the same for lexicographical_compare one day. The ChangeLog below is quite huge so I attached it. I wonder if I could use deque::iterator and deque::const_iterator in place of the _Deque_iterator<> to reduce it ? Tested under Linux x86_64 normal and debug modes, ok to commit ? François
Re: Deque fiil/copy/move/copy_backward/move_backward/equal overloads
Ping ? On 6/19/19 7:32 PM, François Dumont wrote: I wanted to implement Debug overloads for those already existing overloads but then realized that those algos could be generalized. This way we will benefit from the memmove replacement when operating with C array or std::array or std::vector iterators. I might do the same for lexicographical_compare one day. The ChangeLog below is quite huge so I attached it. I wonder if I could use deque::iterator and deque::const_iterator in place of the _Deque_iterator<> to reduce it ? Tested under Linux x86_64 normal and debug modes, ok to commit ? François
