Re: GCC 7 libbacktrace patch committed: Ignore compressed debug sections

2017-10-10 Thread Ian Lance Taylor
On Tue, Oct 10, 2017 at 12:47 PM, Paolo Carlini
 wrote:
>
> On 10/10/2017 18:55, Ian Lance Taylor wrote:
>>
>> Index: elf.c
>> ===
>> --- elf.c   (revision 253593)
>> +++ elf.c   (working copy)
>> @@ -103,6 +103,7 @@
>>   #undef SHT_SYMTAB
>>   #undef SHT_STRTAB
>>   #undef SHT_DYNSYM
>> +#undef SFH_COMPRESSED
>>   #undef STT_OBJECT
>>   #undef STT_FUNC
>
> You appear to have a typo here: SFH_COMPRESSED instead of SHF_COMPRESSED.
> That breaks the bootstrap for me:
>
> ../../../../gcc-7-branch/libsanitizer/libbacktrace/../../libbacktrace/elf.c:199:0:
> error: "SHF_COMPRESSED" redefined [-Werror]
>  #define SHF_COMPRESSED 0x800
>
> I'm going to test and commit the obvious fix, if nobody beats me to it.

Argh.  Sorry about that.  Please do commit the obvious fix.  Thanks.

Ian


Re: GCC 7 libbacktrace patch committed: Ignore compressed debug sections

2017-10-10 Thread Paolo Carlini

Hi,

On 10/10/2017 18:55, Ian Lance Taylor wrote:

Index: elf.c
===
--- elf.c   (revision 253593)
+++ elf.c   (working copy)
@@ -103,6 +103,7 @@
  #undef SHT_SYMTAB
  #undef SHT_STRTAB
  #undef SHT_DYNSYM
+#undef SFH_COMPRESSED
  #undef STT_OBJECT
  #undef STT_FUNC
You appear to have a typo here: SFH_COMPRESSED instead of 
SHF_COMPRESSED. That breaks the bootstrap for me:


../../../../gcc-7-branch/libsanitizer/libbacktrace/../../libbacktrace/elf.c:199:0: 
error: "SHF_COMPRESSED" redefined [-Werror]

 #define SHF_COMPRESSED 0x800

I'm going to test and commit the obvious fix, if nobody beats me to it.

Paolo.