Re: Unreviewed patches
On Mon, 6 Jun 2016, Rainer Orth wrote: > The following patches have remained unreviewed for a week: > > [gotools, libcc1] Update copyright dates > https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02307.html > > Richard already approved the update-copyright.py changes, but the actual > effects on gotools and libcc1 require either maintainer or release > manager approval, I believe. I think applying those updates is a direct consequence of updating the update-copyright.py script and you can just go ahead. Gerald
Re: Unreviewed patches
Hi Gerald, > On Mon, 6 Jun 2016, Rainer Orth wrote: >> The following patches have remained unreviewed for a week: >> >> [gotools, libcc1] Update copyright dates >> https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02307.html >> >> Richard already approved the update-copyright.py changes, but the actual >> effects on gotools and libcc1 require either maintainer or release >> manager approval, I believe. > > I think applying those updates is a direct consequence of updating > the update-copyright.py script and you can just go ahead. done now. I'd just hoped to get word from the RMs what to do about default_dirs in the script so the same doesn't happen again next year. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Unreviewed patches
On 06/06/2016 02:16 AM, Rainer Orth wrote: The following patches have remained unreviewed for a week: [gotools, libcc1] Update copyright dates https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02307.html Everything bug the gotools changes are OK. THe master bits for gotools is outside of GCC. Probably best to contact Ian for getting these updated. Richard already approved the update-copyright.py changes, but the actual effects on gotools and libcc1 require either maintainer or release manager approval, I believe. [build] Handle gas/gld --compress-debug-sections=type https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02325.html This one needs a build maintainer. This is OK for the trunk. jeff
Re: Unreviewed patches
Hi Jeff, > On 06/06/2016 02:16 AM, Rainer Orth wrote: >> The following patches have remained unreviewed for a week: >> >> [gotools, libcc1] Update copyright dates >> https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02307.html > Everything bug the gotools changes are OK. THe master bits for gotools is > outside of GCC. Probably best to contact Ian for getting these updated. I'd already installed the complete patch, based on https://gcc.gnu.org/ml/gcc-patches/2016-06/msg00407.html Since update-copyright.py only updates files with FSF copyright notices, which are local to the gcc tree, I hope this should be safe. >> Richard already approved the update-copyright.py changes, but the actual >> effects on gotools and libcc1 require either maintainer or release >> manager approval, I believe. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Unreviewed patches
On 06/08/2017 04:08 AM, Rainer Orth wrote: > The following patches have remained unreviewed for a week or more: > > [build] Support --sysroot with Solaris ld > https://gcc.gnu.org/ml/gcc-patches/2017-05/msg02342.html > > This needs a build maintainer unless one considers it obvious. > > Support $SYSROOT for = in -I etc. > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00011.html > > This needs a cpp or C maintainer. OK for both. Sorry for the long wait. jeff
Re: Unreviewed patches
On Wed, Jan 31, 2024 at 3:04 PM Rainer Orth wrote: > > Three patches have remained unreviewed for a week or more: > > c++: Fix g++.dg/ext/attr-section2.C etc. with Solaris/SPARC as > https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643434.html > > This one may even be obvious. > > testsuite: i386: Fix gcc.target/i386/pr70321.c on 32-bit Solaris/x86 > https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643771.html > > testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on > 32-bit Solaris/x86 > https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643774.html > > Those two require an x86 maintainer. OK for x86 patches, I'd say that these two fall under Solaris maintainership (if not obvious, after all). Thanks, Uros.
Re: Unreviewed patches
Hi Uros, > On Wed, Jan 31, 2024 at 3:04 PM Rainer Orth > wrote: >> >> Three patches have remained unreviewed for a week or more: >> >> c++: Fix g++.dg/ext/attr-section2.C etc. with Solaris/SPARC as >> https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643434.html >> >> This one may even be obvious. I do claim that now and have installed the patch. >> testsuite: i386: Fix gcc.target/i386/pr70321.c on 32-bit Solaris/x86 >> https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643771.html >> >> testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on >> 32-bit Solaris/x86 >> https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643774.html >> >> Those two require an x86 maintainer. > > OK for x86 patches, I'd say that these two fall under Solaris > maintainership (if not obvious, after all). I've always been careful when touching files that affect non-Solaris targets, in case a maintainer sees a better solution or finds fault with mine. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
