Re: V3 [PATCH] c-family: Update unaligned adress of packed member check
On Mon, Jan 21, 2019 at 4:57 AM Maxim Kuvyrkov wrote: > > Hi H.J., > > I've bisected compiler crash on building linux kernel for ARM down to this > commit. Search for > == > fs/ntfs/super.c:597:3: internal compiler error: Segmentation fault > == > in > https://ci.linaro.org/view/tcwg_kernel-gnu/job/tcwg_kernel-build-gnu-master-arm-mainline-defconfig/285/artifact/artifacts/5-count_linux_objs/console.log/*view*/ > . > > This should be trivial to reproduce, but let me know if you need assistance. That is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88928 and a patch is posted. -- H.J.
Re: V3 [PATCH] c-family: Update unaligned adress of packed member check
Hi H.J., I've bisected compiler crash on building linux kernel for ARM down to this commit. Search for == fs/ntfs/super.c:597:3: internal compiler error: Segmentation fault == in https://ci.linaro.org/view/tcwg_kernel-gnu/job/tcwg_kernel-build-gnu-master-arm-mainline-defconfig/285/artifact/artifacts/5-count_linux_objs/console.log/*view*/ . This should be trivial to reproduce, but let me know if you need assistance. Regards, -- Maxim Kuvyrkov www.linaro.org > On Jan 18, 2019, at 2:10 PM, Jakub Jelinek wrote: > > On Thu, Jan 17, 2019 at 04:00:47PM -0800, H.J. Lu wrote: >> gcc/c-family/ >> >> PR c/51628 >> PR c/88664 >> * c-common.h (warn_for_address_or_pointer_of_packed_member): >> Remove the boolean argument. >> * c-warn.c (check_address_of_packed_member): Renamed to ... >> (check_address_or_pointer_of_packed_member): This. Also >> warn pointer conversion. >> (check_and_warn_address_of_packed_member): Renamed to ... >> (check_and_warn_address_or_pointer_of_packed_member): This. >> Also warn pointer conversion. >> (warn_for_address_or_pointer_of_packed_member): Remove the >> boolean argument. Don't check pointer conversion here. >> >> gcc/c >> >> PR c/51628 >> PR c/88664 >> * c-typeck.c (convert_for_assignment): Upate the >> warn_for_address_or_pointer_of_packed_member call. >> >> gcc/cp >> >> PR c/51628 >> PR c/88664 >> * call.c (convert_for_arg_passing): Upate the >> warn_for_address_or_pointer_of_packed_member call. >> * typeck.c (convert_for_assignment): Likewise. >> >> gcc/testsuite/ >> >> PR c/51628 >> PR c/88664 >> * c-c++-common/pr51628-33.c: New test. >> * c-c++-common/pr51628-35.c: New test. >> * c-c++-common/pr88664-1.c: Likewise. >> * c-c++-common/pr88664-2.c: Likewise. >> * gcc.dg/pr51628-34.c: Likewise. > > Ok, thanks. > > Jakub
Re: V3 [PATCH] c-family: Update unaligned adress of packed member check
On Thu, Jan 17, 2019 at 04:00:47PM -0800, H.J. Lu wrote: > gcc/c-family/ > > PR c/51628 > PR c/88664 > * c-common.h (warn_for_address_or_pointer_of_packed_member): > Remove the boolean argument. > * c-warn.c (check_address_of_packed_member): Renamed to ... > (check_address_or_pointer_of_packed_member): This. Also > warn pointer conversion. > (check_and_warn_address_of_packed_member): Renamed to ... > (check_and_warn_address_or_pointer_of_packed_member): This. > Also warn pointer conversion. > (warn_for_address_or_pointer_of_packed_member): Remove the > boolean argument. Don't check pointer conversion here. > > gcc/c > > PR c/51628 > PR c/88664 > * c-typeck.c (convert_for_assignment): Upate the > warn_for_address_or_pointer_of_packed_member call. > > gcc/cp > > PR c/51628 > PR c/88664 > * call.c (convert_for_arg_passing): Upate the > warn_for_address_or_pointer_of_packed_member call. > * typeck.c (convert_for_assignment): Likewise. > > gcc/testsuite/ > > PR c/51628 > PR c/88664 > * c-c++-common/pr51628-33.c: New test. > * c-c++-common/pr51628-35.c: New test. > * c-c++-common/pr88664-1.c: Likewise. > * c-c++-common/pr88664-2.c: Likewise. > * gcc.dg/pr51628-34.c: Likewise. Ok, thanks. Jakub
