Re: VEC re-write [patch 09/25]

2012-11-16 Thread Tom Tromey 
 Diego == Diego Novillo dnovi...@google.com writes:

Diego 2012-11-15  Diego Novillo  dnovi...@google.com
Diego  Adjust for new vec API (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec)
Diego  * boehm.c: Use new vec API in vec.h.
Diego  * class.c: Likewise.
Diego  * constants.c: Likewise.
Diego  * decl.c: Likewise.
Diego  * expr.c: Likewise.
Diego  * java-tree.h: Likewise.
Diego  * jcf-parse.c: Likewise.
Diego  * resource.c: Likewise.
Diego  * verify-glue.c: Likewise.

Looks nice.  Thanks.
I have one nit:

Diego= build_utf8_ref (unmangle_classname (IDENTIFIER_POINTER 
(sig),
Diego -IDENTIFIER_LENGTH 
(sig)));
Diego -e = VEC_index (constructor_elt, v, idx--);
Diego +IDENTIFIER_LENGTH (sig)));
Diego +e = (*v)[idx--];

Looks like a spurious reindentation of the IDENTIFIER_LENGTH line.

Tom

Re: VEC re-write [patch 09/25]

2012-11-16 Thread Diego Novillo 
On Fri, Nov 16, 2012 at 11:32 AM, Tom Tromey tro...@redhat.com wrote:

 Diego= build_utf8_ref (unmangle_classname 
 (IDENTIFIER_POINTER (sig),
 Diego -IDENTIFIER_LENGTH 
 (sig)));
 Diego -e = VEC_index (constructor_elt, v, idx--);
 Diego +IDENTIFIER_LENGTH (sig)));
 Diego +e = (*v)[idx--];

 Looks like a spurious reindentation of the IDENTIFIER_LENGTH line.

Thanks.  Fixed.


Diego.