Re: libffi patch RFA: Pass -Qunused-arguments for asm files

2014-10-14 Thread Paolo Bonzini
Il 30/09/2014 02:12, Ian Lance Taylor ha scritto:
> Similar to a recent patch to libgo, this patch to the libffi configure
> script checks whether the compiler support -Qunused-arguments.  If it
> does, it passes -Qunused-arguments when invoking the compiler on .s
> files.  This is because the clang driver complains by default when given
> useless arguments, such as -I options when compiling a .s file.  This
> somewhat annoying behaviour works poorly with configure scripts.  The
> -Qunused-arguments option disables it.  Bootstrapped and ran libffi and
> libgo tests on x86_64-unknown-linux-gnu.
> 
> OK for mainline?
> 
> Ian
> 
> 
> 2014-09-29  Ian Lance Taylor  
> 
>   * configure.ac: If the compiler supports -Qunused-arguments, use
>   it when running the compiler on .s files.
>   * configure: Regenerated.

Ok.

Paolo



Re: libffi patch RFA: Pass -Qunused-arguments for asm files

2014-10-10 Thread Ian Lance Taylor
Ping.  Adding Paolo as a build machinery maintainer.  Thanks.

Ian

On Mon, Sep 29, 2014 at 5:12 PM, Ian Lance Taylor  wrote:
> Similar to a recent patch to libgo, this patch to the libffi configure
> script checks whether the compiler support -Qunused-arguments.  If it
> does, it passes -Qunused-arguments when invoking the compiler on .s
> files.  This is because the clang driver complains by default when given
> useless arguments, such as -I options when compiling a .s file.  This
> somewhat annoying behaviour works poorly with configure scripts.  The
> -Qunused-arguments option disables it.  Bootstrapped and ran libffi and
> libgo tests on x86_64-unknown-linux-gnu.
>
> OK for mainline?
>
> Ian
>
>
> 2014-09-29  Ian Lance Taylor  
>
> * configure.ac: If the compiler supports -Qunused-arguments, use
> it when running the compiler on .s files.
> * configure: Regenerated.
>
>