Re: Small typo in iconv.m4
On 11/9/18 10:57 AM, Eric Gallager wrote: > On 11/7/18, Jeff Law wrote: >> On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: >>> Hi All, >>> I was investigating a character set related problem with windows hosted >>> GDB and I tracked it down to a typo in iconv.m4. This typo caused >>> libiconv detection to fail and related support was not built into gdb. >>> >>> The problem is with the following line. >>> CPPFLAGS="$LIBS $INCICONV" >>> which should have been >>> CPPFLAGS="$CPPFLAGS $INCICONV" >>> >>> OK to commit the attached patch? >>> >>> 2018-11-06 Hafiz Abid Qadeer >>> >>> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. >>> Append $INCICONV to it. >>> * gcc/configure: Regenerate. >>> * libcpp/configure: Likewise. >>> * libstdc++-v3/configure: Likewise. >>> * intl/configure: Likewise. >>> >>> Thanks, >>> >> THanks. I wasn't sure if you had commit privs, so I went ahead and >> installed the patch. >> >> Jeff >> > > Does this have any effect on GCC bug 78251? > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251 > Or any of the related bugs under "See Also" for that matter? Certainly looks related. Though I think we're still going to see pollution, just in a slightly different way. jeff
Re: Small typo in iconv.m4
On 11/7/18, Jeff Law wrote: > On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: >> Hi All, >> I was investigating a character set related problem with windows hosted >> GDB and I tracked it down to a typo in iconv.m4. This typo caused >> libiconv detection to fail and related support was not built into gdb. >> >> The problem is with the following line. >> CPPFLAGS="$LIBS $INCICONV" >> which should have been >> CPPFLAGS="$CPPFLAGS $INCICONV" >> >> OK to commit the attached patch? >> >> 2018-11-06 Hafiz Abid Qadeer >> >> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. >> Append $INCICONV to it. >> * gcc/configure: Regenerate. >> * libcpp/configure: Likewise. >> * libstdc++-v3/configure: Likewise. >> * intl/configure: Likewise. >> >> Thanks, >> > THanks. I wasn't sure if you had commit privs, so I went ahead and > installed the patch. > > Jeff > Does this have any effect on GCC bug 78251? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251 Or any of the related bugs under "See Also" for that matter?
Re: Small typo in iconv.m4
On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: > Hi All, > I was investigating a character set related problem with windows hosted > GDB and I tracked it down to a typo in iconv.m4. This typo caused > libiconv detection to fail and related support was not built into gdb. > > The problem is with the following line. > CPPFLAGS="$LIBS $INCICONV" > which should have been > CPPFLAGS="$CPPFLAGS $INCICONV" > > OK to commit the attached patch? > > 2018-11-06 Hafiz Abid Qadeer > > * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. > Append $INCICONV to it. > * gcc/configure: Regenerate. > * libcpp/configure: Likewise. > * libstdc++-v3/configure: Likewise. > * intl/configure: Likewise. > > Thanks, > THanks. I wasn't sure if you had commit privs, so I went ahead and installed the patch. Jeff
Re: Small typo in iconv.m4
On 2018-11-06 11:37, Hafiz Abid Qadeer wrote: Hi All, I was investigating a character set related problem with windows hosted GDB and I tracked it down to a typo in iconv.m4. This typo caused libiconv detection to fail and related support was not built into gdb. The problem is with the following line. CPPFLAGS="$LIBS $INCICONV" which should have been CPPFLAGS="$CPPFLAGS $INCICONV" OK to commit the attached patch? 2018-11-06 Hafiz Abid Qadeer * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. Append $INCICONV to it. * gcc/configure: Regenerate. * libcpp/configure: Likewise. * libstdc++-v3/configure: Likewise. * intl/configure: Likewise. Thanks, Seems good from my point of view, but I can't approve. Simon
Small typo in iconv.m4
Hi All, I was investigating a character set related problem with windows hosted GDB and I tracked it down to a typo in iconv.m4. This typo caused libiconv detection to fail and related support was not built into gdb. The problem is with the following line. CPPFLAGS="$LIBS $INCICONV" which should have been CPPFLAGS="$CPPFLAGS $INCICONV" OK to commit the attached patch? 2018-11-06 Hafiz Abid Qadeer * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. Append $INCICONV to it. * gcc/configure: Regenerate. * libcpp/configure: Likewise. * libstdc++-v3/configure: Likewise. * intl/configure: Likewise. Thanks, -- Hafiz Abid Qadeer Mentor Embedded/CodeSourcery diff --git a/config/iconv.m4 b/config/iconv.m4 index 5f9304a6ba..f1e54c5aed 100644 --- a/config/iconv.m4 +++ b/config/iconv.m4 @@ -73,7 +73,7 @@ AC_DEFUN([AM_ICONV_LINK], if test "$am_cv_func_iconv" != yes; then am_save_CPPFLAGS="$CPPFLAGS" am_save_LIBS="$LIBS" - CPPFLAGS="$LIBS $INCICONV" + CPPFLAGS="$CPPFLAGS $INCICONV" LIBS="$LIBS $LIBICONV" AC_TRY_LINK([#include #include ],
