Re: Unreviewed libstdc++/libgomp patch
Jakub Jelinek ja...@redhat.com writes: On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It is critical to avoid breaking libstdc++.so symbol versioning on Solaris and requires libstdc++ and libgomp maintainers. The libgomp changes are ok if the libstdc++ changes are approved. Thanks. Unfortunately, none of the libstdc++ maintainers hasn't commented in almost two weeks. It would be a pity to release 4.7.0 with this bug unfixed. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Unreviewed libstdc++/libgomp patch
Hi, Jakub Jelinekja...@redhat.com writes: On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It is critical to avoid breaking libstdc++.so symbol versioning on Solaris and requires libstdc++ and libgomp maintainers. The libgomp changes are ok if the libstdc++ changes are approved. Thanks. Unfortunately, none of the libstdc++ maintainers hasn't commented in almost two weeks. It would be a pity to release 4.7.0 with this bug unfixed. I cannot say to understand in detail the issue, but if it affects Solaris only, likewise the fix (I think so), and you double checked it on, say, x86_64-Linux, the patch is Ok with me. Thanks! Paolo.
Re: Unreviewed libstdc++/libgomp patch
Paolo Carlini paolo.carl...@oracle.com writes: Jakub Jelinekja...@redhat.com writes: On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It is critical to avoid breaking libstdc++.so symbol versioning on Solaris and requires libstdc++ and libgomp maintainers. The libgomp changes are ok if the libstdc++ changes are approved. Thanks. Unfortunately, none of the libstdc++ maintainers hasn't commented in almost two weeks. It would be a pity to release 4.7.0 with this bug unfixed. I cannot say to understand in detail the issue, but if it affects Solaris only, likewise the fix (I think so), and you double checked it on, say, x86_64-Linux, the patch is Ok with me. While the mechanism introduced is generic, it currently affects Solaris only. And yes, I've compared versioning in libstdc++.so and libgomp.so on x86_64-unknown-linux-gnu without and with the patch as described in the submission: no change. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Unreviewed libstdc++/libgomp patch
On 02/27/2012 02:38 PM, Rainer Orth wrote: While the mechanism introduced is generic, it currently affects Solaris only. And yes, I've compared versioning in libstdc++.so and libgomp.so on x86_64-unknown-linux-gnu without and with the patch as described in the submission: no change. Excellent. Thanks again, Paolo.
Re: Unreviewed libstdc++/libgomp patch
On Mon, Feb 27, 2012 at 02:38:14PM +0100, Rainer Orth wrote:
Paolo Carlini paolo.carl...@oracle.com writes:
Jakub Jelinekja...@redhat.com writes:
On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote:
The following patch has remained unreviewed for a week:
[v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188)
http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html
It is critical to avoid breaking libstdc++.so symbol versioning on
Solaris and requires libstdc++ and libgomp maintainers.
The libgomp changes are ok if the libstdc++ changes are approved.
Thanks. Unfortunately, none of the libstdc++ maintainers hasn't
commented in almost two weeks. It would be a pity to release 4.7.0 with
this bug unfixed.
I cannot say to understand in detail the issue, but if it affects Solaris
only, likewise the fix (I think so), and you double checked it on, say,
x86_64-Linux, the patch is Ok with me.
While the mechanism introduced is generic, it currently affects Solaris
only. And yes, I've compared versioning in libstdc++.so and libgomp.so
on x86_64-unknown-linux-gnu without and with the patch as described in
the submission: no change.
Unfortunately this broke build on powerpc{,64}-linux and likely all other
GLIBCXX_LDBL* targets.
The problem is that config/abi/pre/gnu.ver doesn't end with a newline,
so we end up with:
# Symbols in the support library (libsupc++) supporting transactional memory.
CXXABI_TM_1 {
global:
__cxa_tm_cleanup;
};# Appended to version file.
GLIBCXX_LDBL_3.4 {
_ZNSt14numeric_limitsIgE*;
and $(EGREP) -v '#(#| |$$)' just throws away the whole
};# Appended to version file.
line. I wonder if
sed -e 's/#[# $].*$//'
wouldn't be better, or alternative add ^ before the first #
in the egrep regex. Of course we can add a newline to gnu.ver, but the
next time somebody forgots to add a newline at the end of the file
we'll have the same problem again.
Benjamin, what do you prefer?
Jakub
Re: Unreviewed libstdc++/libgomp patch
On Tue, 28 Feb 2012 00:12:33 +0100 Jakub Jelinek ja...@redhat.com wrote: and $(EGREP) -v '#(#| |$$)' just throws away the whole };# Appended to version file. line. I wonder if sed -e 's/#[# $].*$//' wouldn't be better, or alternative add ^ before the first # in the egrep regex. Of course we can add a newline to gnu.ver, but the next time somebody forgots to add a newline at the end of the file we'll have the same problem again. Benjamin, what do you prefer? I would prefer not having gnu.ver have to end in a newline. Slight preference for ^ before first # but I don't really care. -benjamin
Re: Unreviewed libstdc++/libgomp patch
On Tue, 28 Feb 2012, Jakub Jelinek wrote: The problem is that config/abi/pre/gnu.ver doesn't end with a newline, [...] Of course we can add a newline to gnu.ver, but the next time somebody forgots to add a newline at the end of the file we'll have the same problem again. I seem to remember someone proposing (some years ago) a commit hook to prevent such bugs on all text files. I can't remember if there were arguments against it or just a lack of interest. -- Marc Glisse
Unreviewed libstdc++/libgomp patch
The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It is critical to avoid breaking libstdc++.so symbol versioning on Solaris and requires libstdc++ and libgomp maintainers. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Unreviewed libstdc++/libgomp patch
On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It is critical to avoid breaking libstdc++.so symbol versioning on Solaris and requires libstdc++ and libgomp maintainers. The libgomp changes are ok if the libstdc++ changes are approved. Jakub
