Re: [PATCH] Use a specfile that actually allows building programs on NetBSD
On Thu, Jun 29, 2017 at 05:23:37PM -0600, Jeff Law wrote: > On 06/29/2017 09:51 AM, coypu wrote: > > I was thinking of holding a party for the upcoming one year anniversary > > of pinging this patch, that was committed to NetBSD's copy of GCC about > > a decade ago. without it, I can't compile simple programs. > When it was committed to NetBSD isn't at all relevant. We don't scour > downstream uses for patches that might be useful and since few, if any, > of the most active GCC developers use NetBSD we're unlikely to trip over > the problem ourselves. That makes us reliant upon others to report bugs > and sometimes to even provide patches to fix platform specific issues. > > Krister indicated back when you first posted the patch in Jan that he > was going to fix this and other issues in specs handling, but I don't > see that Krister ever followed up. > > I wouldn't at all be surprised if this needs further work for pthreads. > But I'll have to leave investigation there to folks that use NetBSD. > > I've installed your patch on the trunk. Thank you. I've spoken with Krister and he is responsive and still interested in cleaning everything up, but it's good to have things working until then. I've mentioned it as I'd like to close N many years of not upstreaming patches :-) sometimes we have good changes, too, but they'll be mostly netbsd ones.
Re: [PATCH] Use a specfile that actually allows building programs on NetBSD
On 06/29/2017 09:51 AM, coypu wrote: > I was thinking of holding a party for the upcoming one year anniversary > of pinging this patch, that was committed to NetBSD's copy of GCC about > a decade ago. without it, I can't compile simple programs. When it was committed to NetBSD isn't at all relevant. We don't scour downstream uses for patches that might be useful and since few, if any, of the most active GCC developers use NetBSD we're unlikely to trip over the problem ourselves. That makes us reliant upon others to report bugs and sometimes to even provide patches to fix platform specific issues. Krister indicated back when you first posted the patch in Jan that he was going to fix this and other issues in specs handling, but I don't see that Krister ever followed up. I wouldn't at all be surprised if this needs further work for pthreads. But I'll have to leave investigation there to folks that use NetBSD. I've installed your patch on the trunk. jeff
Re: [PATCH] Use a specfile that actually allows building programs on NetBSD
On Thu, 29 Jun 2017, coypu wrote: > I was thinking of holding a party for the upcoming one year anniversary > of pinging this patch, that was committed to NetBSD's copy of GCC about > a decade ago. without it, I can't compile simple programs. I advise CC:ing the listed NetBSD maintainers (Jason Thorpe and Krister Walfridsson) on any ping of a NetBSD GCC patch. -- Joseph S. Myers jos...@codesourcery.com
[PATCH] Use a specfile that actually allows building programs on NetBSD
I was thinking of holding a party for the upcoming one year anniversary
of pinging this patch, that was committed to NetBSD's copy of GCC about
a decade ago. without it, I can't compile simple programs.
---
gcc/config/netbsd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/config/netbsd.h b/gcc/config/netbsd.h
index 4001f240d..f4ac23a73 100644
--- a/gcc/config/netbsd.h
+++ b/gcc/config/netbsd.h
@@ -96,6 +96,7 @@ along with GCC; see the file COPYING3. If not see
%{!pg:-lposix}} \
%{p:-lposix_p}\
%{pg:-lposix_p}} \
+ %{shared:-lc} \
%{!shared: \
%{!symbolic: \
%{!p: \
@@ -109,6 +110,7 @@ along with GCC; see the file COPYING3. If not see
%{!pg:-lposix}} \
%{p:-lposix_p}\
%{pg:-lposix_p}} \
+ %{shared:-lc} \
%{!shared: \
%{!symbolic: \
%{!p: \
--
2.13.1
Re: Use a specfile that actually allows building programs on NetBSD
On Wed, Jan 11, 2017 at 04:41:44PM +0100, Krister Walfridsson wrote: > On Mon, 9 Jan 2017, co...@sdf.org wrote: > > >3 month ping, 1 week ping (trying again), etc... > > Apologies for not getting back to you sooner. > > > >Like most operating systems, NetBSD has a libc which contains > >stuff it needs for most programs to work, and people expect > >it to be linked without explicitly specifying -lc. > > Well, most programs already get -lc automatically -- it is only when you > pass -shared that it fails... :-) > > But I'll fix this, together with some other SPEC issues, in a few days. > >/Krister yay! thanks netbsd patches stuff a lot more here, but I try not to upstream stuff I don't understand and did not need. I've done this to get gcc from pkgsrc working more, and it does for x86, but not for any other archs yet.
Re: Use a specfile that actually allows building programs on NetBSD
On Mon, 9 Jan 2017, co...@sdf.org wrote: 3 month ping, 1 week ping (trying again), etc... Apologies for not getting back to you sooner. Like most operating systems, NetBSD has a libc which contains stuff it needs for most programs to work, and people expect it to be linked without explicitly specifying -lc. Well, most programs already get -lc automatically -- it is only when you pass -shared that it fails... :-) But I'll fix this, together with some other SPEC issues, in a few days. /Krister
Re: Use a specfile that actually allows building programs on NetBSD
3 month ping, 1 week ping (trying again), etc...
This patch has zero affect on non-netbsd users and was already
accepted in NetBSD years ago.
On Wed, Jan 04, 2017 at 11:24:27AM +, coypu wrote:
> Like most operating systems, NetBSD has a libc which contains
> stuff it needs for most programs to work, and people expect
> it to be linked without explicitly specifying -lc.
>
> This patch is needed for just about any program to work.
>
> ---
> gcc/config/netbsd.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/config/netbsd.h b/gcc/config/netbsd.h
> index f2d6cc6..65ce943 100644
> --- a/gcc/config/netbsd.h
> +++ b/gcc/config/netbsd.h
> @@ -96,6 +96,7 @@ along with GCC; see the file COPYING3. If not see
> %{!pg:-lposix}} \
> %{p:-lposix_p} \
> %{pg:-lposix_p}}\
> + %{shared:-lc} \
> %{!shared:\
> %{!symbolic:\
> %{!p: \
> @@ -109,6 +110,7 @@ along with GCC; see the file COPYING3. If not see
> %{!pg:-lposix}} \
> %{p:-lposix_p} \
> %{pg:-lposix_p}}\
> + %{shared:-lc} \
> %{!shared:\
> %{!symbolic:\
> %{!p: \
> --
> 2.9.0
Re: Use a specfile that actually allows building programs on NetBSD
Identical patch was committed to NetBSD in April 28, 2008. https://github.com/jsonn/src/commit/7105def538f68e0a0034f5c93ec7fc384ca849b2
Use a specfile that actually allows building programs on NetBSD
Like most operating systems, NetBSD has a libc which contains
stuff it needs for most programs to work, and people expect
it to be linked without explicitly specifying -lc.
This patch is needed for just about any program to work.
---
gcc/config/netbsd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/config/netbsd.h b/gcc/config/netbsd.h
index f2d6cc6..65ce943 100644
--- a/gcc/config/netbsd.h
+++ b/gcc/config/netbsd.h
@@ -96,6 +96,7 @@ along with GCC; see the file COPYING3. If not see
%{!pg:-lposix}} \
%{p:-lposix_p}\
%{pg:-lposix_p}} \
+ %{shared:-lc} \
%{!shared: \
%{!symbolic: \
%{!p: \
@@ -109,6 +110,7 @@ along with GCC; see the file COPYING3. If not see
%{!pg:-lposix}} \
%{p:-lposix_p}\
%{pg:-lposix_p}} \
+ %{shared:-lc} \
%{!shared: \
%{!symbolic: \
%{!p: \
--
2.9.0
