Re: gfortran.dg/dg.exp debug messages pollute test output
> I suppose 'set t [...]' can be let go, too? Duh (x2). Pushed, on top of the previous patch. FX 0001-Testsuite-remove-unused-variables.patch Description: Binary data
Re: gfortran.dg/dg.exp debug messages pollute test output
Hi!
On 2023-11-15T11:29:20+0100, FX Coudert wrote:
>>> it's unclear if those messages can just be removed (they are pretty
>>> cryptic as is) or at least changed to use verbose instead of puts.
>>> Please fix.
>
> I don’t see value in this output, so I think it’s best to remove the puts
> calls entirely.
ACK, I'd noticed that, too.
> Attached patch does that.
> --- a/gcc/testsuite/gfortran.dg/coarray/caf.exp
> +++ b/gcc/testsuite/gfortran.dg/coarray/caf.exp
> @@ -81,7 +81,6 @@ if [check_effective_target_libatomic_available] {
> }
> }
> set t [get_multilibs]
> -puts "maybe al $maybe_atomic_lib ml $t"
> }
I suppose 'set t [...]' can be let go, too?
> --- a/gcc/testsuite/gfortran.dg/dg.exp
> +++ b/gcc/testsuite/gfortran.dg/dg.exp
> @@ -68,7 +68,6 @@ if [check_effective_target_libatomic_available] {
> set maybe_atomic_lib ""
> }
>set t [get_multilibs]
> - puts "dg set al $maybe_atomic_lib ml $t"
> }
Likewise.
Grüße
Thomas
-
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
Re: gfortran.dg/dg.exp debug messages pollute test output
Hi FX, >> FX submitted the patch series, I can find the reference if you need it. > > Patch was submitted in this thread: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630096.html ah, I see. I'd been looking for the patch summary and Iain's name in my searches; that's why I came up blank. >>> Besides, >>> it's unclear if those messages can just be removed (they are pretty >>> cryptic as is) or at least changed to use verbose instead of puts. >>> Please fix. > > I don’t see value in this output, so I think it’s best to remove the puts > calls entirely. Attached patch does that. > Testing under progress, OK if it passes? (or does that count as obvious > fix-up of the previous patch) Ok for trunk. However, this perfectly fits the obvious criteria, too. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: gfortran.dg/dg.exp debug messages pollute test output
> FX submitted the patch series, I can find the reference if you need it. Patch was submitted in this thread: https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630096.html >> Besides, >> it's unclear if those messages can just be removed (they are pretty >> cryptic as is) or at least changed to use verbose instead of puts. >> Please fix. I don’t see value in this output, so I think it’s best to remove the puts calls entirely. Attached patch does that. Testing under progress, OK if it passes? (or does that count as obvious fix-up of the previous patch) FX 0001-Testsuite-silence-some-noise-in-output.patch Description: Binary data
Re: gfortran.dg/dg.exp debug messages pollute test output
Hi Rainer, > On 13 Nov 2023, at 05:27, Rainer Orth wrote: > > I happened to notice that make check output is cluttered with the likes > of > > dg set al > -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/ > -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/.libs > ml /var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/. > revised FFLAGS -pedantic-errors > -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/ > -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/.libs > > (quite a number of instances). Those messages are from > gfortran.dg/dg.exp, introduced by your patch > > commit a0673ec5f9236dca6ada23f28343c591ccd575e4 > Author: Iain Sandoe > Date: Fri Apr 16 20:01:40 2021 +0100 > >Testsuite: allow non-installed testing on darwin > > I couldn't find any submission for that patch, unfortunately. FX submitted the patch series, I can find the reference if you need it. > Besides, > it's unclear if those messages can just be removed (they are pretty > cryptic as is) or at least changed to use verbose instead of puts. > Please fix. will do. thanks Iain > > Rainer > > -- > - > Rainer Orth, Center for Biotechnology, Bielefeld University
gfortran.dg/dg.exp debug messages pollute test output
Hi Iain, I happened to notice that make check output is cluttered with the likes of dg set al -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/ -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/.libs ml /var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/. revised FFLAGS -pedantic-errors -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/ -B/var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/./libatomic/.libs (quite a number of instances). Those messages are from gfortran.dg/dg.exp, introduced by your patch commit a0673ec5f9236dca6ada23f28343c591ccd575e4 Author: Iain Sandoe Date: Fri Apr 16 20:01:40 2021 +0100 Testsuite: allow non-installed testing on darwin I couldn't find any submission for that patch, unfortunately. Besides, it's unclear if those messages can just be removed (they are pretty cryptic as is) or at least changed to use verbose instead of puts. Please fix. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
