Re: ping^^^^: [PATCH V2] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd
Hi,
I just submit a new version:
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623533.html
So, we could ignore this ping and check the new version.
BR,
Jeff (Jiufu Guo)
Jiufu Guo via Gcc-patches writes:
> Hi,
>
> Gentle ping ...
>
> Jiufu Guo via Gcc-patches writes:
>
>> Gentle ping...
>>
>> Jiufu Guo via Gcc-patches writes:
>>
>>> Gentle ping...
>>>
>>> Jiufu Guo via Gcc-patches writes:
>>>
Hi
I would like to ping this patch for stage1:
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612168.html
BR,
Jeff (Jiufu)
Jiufu Guo writes:
> Hi,
>
> Compare with previous version:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609654.html
> This patch does not use UNSPEC for insn mtvsrws anymore. And to handle
> the subreg better on BE and LE, predicate "lowpart_subreg_operator"
> is introducted. To help combine pass to match the pattern on high32
> bit of DI, shiftrt is still used.
>
> As mentioned in PR108338, on p9, we could use mtvsrws to implement
> the conversion from SI#0 to SF (or lowpart DI to SF).
>
> For examples:
> *(long long*)buff = di;
> float f = *(float*)(buff);
> We generate "sldi 9,3,32 ; mtvsrd 1,9 ; xscvspdpn 1,1" instead of
> "mtvsrws 1,3 ; xscvspdpn 1,1".
>
> This patch update this, and also enhance the bitcast from highpart
> DI to SF.
>
> Bootstrap and regtests pass on ppc64{,le}.
> Is this ok for trunk?
>
> BR,
> Jeff (Jiufu)
>
> PR target/108338
>
> gcc/ChangeLog:
>
> * config/rs6000/predicates.md (lowpart_subreg_operator): New
> define_predicate.
> * config/rs6000/rs6000.md (any_rshift): New code_iterator.
> (movsf_from_si2): Rename to...
> (movsf_from_si2_): ... this.
> (si2sf_mtvsrws): New define_insn.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/powerpc/pr108338.c: New test.
>
> ---
> gcc/config/rs6000/predicates.md | 5 +++
> gcc/config/rs6000/rs6000.md | 35 -
> gcc/testsuite/gcc.target/powerpc/pr108338.c | 42 +
> 3 files changed, 73 insertions(+), 9 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/powerpc/pr108338.c
>
> diff --git a/gcc/config/rs6000/predicates.md
> b/gcc/config/rs6000/predicates.md
> index 52c65534e51..e57c9d99c6b 100644
> --- a/gcc/config/rs6000/predicates.md
> +++ b/gcc/config/rs6000/predicates.md
> @@ -2064,3 +2064,8 @@ (define_predicate "macho_pic_address"
>else
> return false;
> })
> +
> +(define_predicate "lowpart_subreg_operator"
> + (and (match_code "subreg")
> + (match_test "subreg_lowpart_offset (mode, GET_MODE (SUBREG_REG
> (op)))
> + == SUBREG_BYTE (op)")))
> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
> index 4a7812fa592..5b4a7f8d801 100644
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -7539,6 +7539,14 @@ (define_split
>UNSPEC_MOVSI_GOT))]
>"")
>
> +(define_insn "si2sf_mtvsrws"
> + [(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
> + (subreg:SF (match_operand:SI 1 "gpc_reg_operand" "r") 0))]
> + "TARGET_P9_VECTOR && TARGET_XSCVSPDPN"
> + "mtvsrws %x0,%1\n\txscvspdpn %x0,%x0"
> + [(set_attr "type" "mfvsr")
> + (set_attr "length" "8")])
> +
> ;; MR LA
> ;; LWZ LFIWZX LXSIWZX
> ;; STW STFIWX STXSIWX
> @@ -8203,10 +8211,18 @@ (define_insn_and_split "movsf_from_si"
>rtx op2 = operands[2];
>rtx op1_di = gen_rtx_REG (DImode, REGNO (op1));
>
> - /* Move SF value to upper 32-bits for xscvspdpn. */
> - emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
> - emit_insn (gen_p8_mtvsrd_sf (op0, op2));
> - emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
> + if (TARGET_P9_VECTOR)
> +{
> + emit_insn (gen_si2sf_mtvsrws (op0, gen_lowpart (SImode, op1_di)));
> +}
> + else
> +{
> + /* Move SF value to upper 32-bits for xscvspdpn. */
> + emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
> + emit_insn (gen_p8_mtvsrd_sf (op0, op2));
> + emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
> +}
> +
>DONE;
> }
>[(set_attr "length"
> @@ -8219,18 +8235,19 @@ (define_insn_and_split "movsf_from_si"
> "*, *, p9v, p8v, *, *,
>p8v,p8v, p8v, *")])
>
> +(define_code_iterator any_rshift [ashiftrt lshiftrt])
> +
> ;; For extracting high part element from DImode register like:
> ;; {%1:SF=unspec[r122:DI>>0x20#
ping^^^^: [PATCH V2] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd
Hi,
Gentle ping ...
Jiufu Guo via Gcc-patches writes:
> Gentle ping...
>
> Jiufu Guo via Gcc-patches writes:
>
>> Gentle ping...
>>
>> Jiufu Guo via Gcc-patches writes:
>>
>>> Hi
>>>
>>> I would like to ping this patch for stage1:
>>> https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612168.html
>>>
>>> BR,
>>> Jeff (Jiufu)
>>>
>>> Jiufu Guo writes:
>>>
Hi,
Compare with previous version:
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609654.html
This patch does not use UNSPEC for insn mtvsrws anymore. And to handle
the subreg better on BE and LE, predicate "lowpart_subreg_operator"
is introducted. To help combine pass to match the pattern on high32
bit of DI, shiftrt is still used.
As mentioned in PR108338, on p9, we could use mtvsrws to implement
the conversion from SI#0 to SF (or lowpart DI to SF).
For examples:
*(long long*)buff = di;
float f = *(float*)(buff);
We generate "sldi 9,3,32 ; mtvsrd 1,9 ; xscvspdpn 1,1" instead of
"mtvsrws 1,3 ; xscvspdpn 1,1".
This patch update this, and also enhance the bitcast from highpart
DI to SF.
Bootstrap and regtests pass on ppc64{,le}.
Is this ok for trunk?
BR,
Jeff (Jiufu)
PR target/108338
gcc/ChangeLog:
* config/rs6000/predicates.md (lowpart_subreg_operator): New
define_predicate.
* config/rs6000/rs6000.md (any_rshift): New code_iterator.
(movsf_from_si2): Rename to...
(movsf_from_si2_): ... this.
(si2sf_mtvsrws): New define_insn.
gcc/testsuite/ChangeLog:
* gcc.target/powerpc/pr108338.c: New test.
---
gcc/config/rs6000/predicates.md | 5 +++
gcc/config/rs6000/rs6000.md | 35 -
gcc/testsuite/gcc.target/powerpc/pr108338.c | 42 +
3 files changed, 73 insertions(+), 9 deletions(-)
create mode 100644 gcc/testsuite/gcc.target/powerpc/pr108338.c
diff --git a/gcc/config/rs6000/predicates.md
b/gcc/config/rs6000/predicates.md
index 52c65534e51..e57c9d99c6b 100644
--- a/gcc/config/rs6000/predicates.md
+++ b/gcc/config/rs6000/predicates.md
@@ -2064,3 +2064,8 @@ (define_predicate "macho_pic_address"
else
return false;
})
+
+(define_predicate "lowpart_subreg_operator"
+ (and (match_code "subreg")
+ (match_test "subreg_lowpart_offset (mode, GET_MODE (SUBREG_REG
(op)))
+ == SUBREG_BYTE (op)")))
diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 4a7812fa592..5b4a7f8d801 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -7539,6 +7539,14 @@ (define_split
UNSPEC_MOVSI_GOT))]
"")
+(define_insn "si2sf_mtvsrws"
+ [(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
+ (subreg:SF (match_operand:SI 1 "gpc_reg_operand" "r") 0))]
+ "TARGET_P9_VECTOR && TARGET_XSCVSPDPN"
+ "mtvsrws %x0,%1\n\txscvspdpn %x0,%x0"
+ [(set_attr "type" "mfvsr")
+ (set_attr "length" "8")])
+
;; MR LA
;; LWZ LFIWZX LXSIWZX
;; STW STFIWX STXSIWX
@@ -8203,10 +8211,18 @@ (define_insn_and_split "movsf_from_si"
rtx op2 = operands[2];
rtx op1_di = gen_rtx_REG (DImode, REGNO (op1));
- /* Move SF value to upper 32-bits for xscvspdpn. */
- emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
- emit_insn (gen_p8_mtvsrd_sf (op0, op2));
- emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
+ if (TARGET_P9_VECTOR)
+{
+ emit_insn (gen_si2sf_mtvsrws (op0, gen_lowpart (SImode, op1_di)));
+}
+ else
+{
+ /* Move SF value to upper 32-bits for xscvspdpn. */
+ emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
+ emit_insn (gen_p8_mtvsrd_sf (op0, op2));
+ emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
+}
+
DONE;
}
[(set_attr "length"
@@ -8219,18 +8235,19 @@ (define_insn_and_split "movsf_from_si"
"*, *, p9v, p8v, *, *,
p8v,p8v, p8v, *")])
+(define_code_iterator any_rshift [ashiftrt lshiftrt])
+
;; For extracting high part element from DImode register like:
;; {%1:SF=unspec[r122:DI>>0x20#0] 86;clobber scratch;}
;; split it before reload with "and mask" to avoid generating shift right
;; 32 bit then shift left 32 bit.
-(define_insn_and_split "movsf_from_si2"
+(define_insn_and_split "movsf_from_si2_"
[(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
(unspec:SF
- [(subreg
ping^^^: [PATCH V2] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd
Gentle ping...
Jiufu Guo via Gcc-patches writes:
> Gentle ping...
>
> Jiufu Guo via Gcc-patches writes:
>
>> Hi
>>
>> I would like to ping this patch for stage1:
>> https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612168.html
>>
>> BR,
>> Jeff (Jiufu)
>>
>> Jiufu Guo writes:
>>
>>> Hi,
>>>
>>> Compare with previous version:
>>> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609654.html
>>> This patch does not use UNSPEC for insn mtvsrws anymore. And to handle
>>> the subreg better on BE and LE, predicate "lowpart_subreg_operator"
>>> is introducted. To help combine pass to match the pattern on high32
>>> bit of DI, shiftrt is still used.
>>>
>>> As mentioned in PR108338, on p9, we could use mtvsrws to implement
>>> the conversion from SI#0 to SF (or lowpart DI to SF).
>>>
>>> For examples:
>>> *(long long*)buff = di;
>>> float f = *(float*)(buff);
>>> We generate "sldi 9,3,32 ; mtvsrd 1,9 ; xscvspdpn 1,1" instead of
>>> "mtvsrws 1,3 ; xscvspdpn 1,1".
>>>
>>> This patch update this, and also enhance the bitcast from highpart
>>> DI to SF.
>>>
>>> Bootstrap and regtests pass on ppc64{,le}.
>>> Is this ok for trunk?
>>>
>>> BR,
>>> Jeff (Jiufu)
>>>
>>> PR target/108338
>>>
>>> gcc/ChangeLog:
>>>
>>> * config/rs6000/predicates.md (lowpart_subreg_operator): New
>>> define_predicate.
>>> * config/rs6000/rs6000.md (any_rshift): New code_iterator.
>>> (movsf_from_si2): Rename to...
>>> (movsf_from_si2_): ... this.
>>> (si2sf_mtvsrws): New define_insn.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> * gcc.target/powerpc/pr108338.c: New test.
>>>
>>> ---
>>> gcc/config/rs6000/predicates.md | 5 +++
>>> gcc/config/rs6000/rs6000.md | 35 -
>>> gcc/testsuite/gcc.target/powerpc/pr108338.c | 42 +
>>> 3 files changed, 73 insertions(+), 9 deletions(-)
>>> create mode 100644 gcc/testsuite/gcc.target/powerpc/pr108338.c
>>>
>>> diff --git a/gcc/config/rs6000/predicates.md
>>> b/gcc/config/rs6000/predicates.md
>>> index 52c65534e51..e57c9d99c6b 100644
>>> --- a/gcc/config/rs6000/predicates.md
>>> +++ b/gcc/config/rs6000/predicates.md
>>> @@ -2064,3 +2064,8 @@ (define_predicate "macho_pic_address"
>>>else
>>> return false;
>>> })
>>> +
>>> +(define_predicate "lowpart_subreg_operator"
>>> + (and (match_code "subreg")
>>> + (match_test "subreg_lowpart_offset (mode, GET_MODE (SUBREG_REG
>>> (op)))
>>> + == SUBREG_BYTE (op)")))
>>> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
>>> index 4a7812fa592..5b4a7f8d801 100644
>>> --- a/gcc/config/rs6000/rs6000.md
>>> +++ b/gcc/config/rs6000/rs6000.md
>>> @@ -7539,6 +7539,14 @@ (define_split
>>> UNSPEC_MOVSI_GOT))]
>>>"")
>>>
>>> +(define_insn "si2sf_mtvsrws"
>>> + [(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
>>> + (subreg:SF (match_operand:SI 1 "gpc_reg_operand" "r") 0))]
>>> + "TARGET_P9_VECTOR && TARGET_XSCVSPDPN"
>>> + "mtvsrws %x0,%1\n\txscvspdpn %x0,%x0"
>>> + [(set_attr "type" "mfvsr")
>>> + (set_attr "length" "8")])
>>> +
>>> ;;MR LA
>>> ;;LWZ LFIWZX LXSIWZX
>>> ;;STW STFIWX STXSIWX
>>> @@ -8203,10 +8211,18 @@ (define_insn_and_split "movsf_from_si"
>>>rtx op2 = operands[2];
>>>rtx op1_di = gen_rtx_REG (DImode, REGNO (op1));
>>>
>>> - /* Move SF value to upper 32-bits for xscvspdpn. */
>>> - emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
>>> - emit_insn (gen_p8_mtvsrd_sf (op0, op2));
>>> - emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
>>> + if (TARGET_P9_VECTOR)
>>> +{
>>> + emit_insn (gen_si2sf_mtvsrws (op0, gen_lowpart (SImode, op1_di)));
>>> +}
>>> + else
>>> +{
>>> + /* Move SF value to upper 32-bits for xscvspdpn. */
>>> + emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
>>> + emit_insn (gen_p8_mtvsrd_sf (op0, op2));
>>> + emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
>>> +}
>>> +
>>>DONE;
>>> }
>>>[(set_attr "length"
>>> @@ -8219,18 +8235,19 @@ (define_insn_and_split "movsf_from_si"
>>> "*, *, p9v, p8v, *, *,
>>> p8v,p8v, p8v, *")])
>>>
>>> +(define_code_iterator any_rshift [ashiftrt lshiftrt])
>>> +
>>> ;; For extracting high part element from DImode register like:
>>> ;; {%1:SF=unspec[r122:DI>>0x20#0] 86;clobber scratch;}
>>> ;; split it before reload with "and mask" to avoid generating shift right
>>> ;; 32 bit then shift left 32 bit.
>>> -(define_insn_and_split "movsf_from_si2"
>>> +(define_insn_and_split "movsf_from_si2_"
>>>[(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
>>> (unspec:SF
>>> -[(subreg:SI
>>> - (ashiftrt:DI
>>> +[(match_operator:SI 3 "lowpart_subreg_operator"
>>> + [(any_rshift:DI
>>> (match_operand:DI 1 "input_operand" "r")
>>> - (const_in
ping^^: [PATCH V2] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd
Gentle ping...
Jiufu Guo via Gcc-patches writes:
> Hi
>
> I would like to ping this patch for stage1:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612168.html
>
> BR,
> Jeff (Jiufu)
>
> Jiufu Guo writes:
>
>> Hi,
>>
>> Compare with previous version:
>> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609654.html
>> This patch does not use UNSPEC for insn mtvsrws anymore. And to handle
>> the subreg better on BE and LE, predicate "lowpart_subreg_operator"
>> is introducted. To help combine pass to match the pattern on high32
>> bit of DI, shiftrt is still used.
>>
>> As mentioned in PR108338, on p9, we could use mtvsrws to implement
>> the conversion from SI#0 to SF (or lowpart DI to SF).
>>
>> For examples:
>> *(long long*)buff = di;
>> float f = *(float*)(buff);
>> We generate "sldi 9,3,32 ; mtvsrd 1,9 ; xscvspdpn 1,1" instead of
>> "mtvsrws 1,3 ; xscvspdpn 1,1".
>>
>> This patch update this, and also enhance the bitcast from highpart
>> DI to SF.
>>
>> Bootstrap and regtests pass on ppc64{,le}.
>> Is this ok for trunk?
>>
>> BR,
>> Jeff (Jiufu)
>>
>> PR target/108338
>>
>> gcc/ChangeLog:
>>
>> * config/rs6000/predicates.md (lowpart_subreg_operator): New
>> define_predicate.
>> * config/rs6000/rs6000.md (any_rshift): New code_iterator.
>> (movsf_from_si2): Rename to...
>> (movsf_from_si2_): ... this.
>> (si2sf_mtvsrws): New define_insn.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/powerpc/pr108338.c: New test.
>>
>> ---
>> gcc/config/rs6000/predicates.md | 5 +++
>> gcc/config/rs6000/rs6000.md | 35 -
>> gcc/testsuite/gcc.target/powerpc/pr108338.c | 42 +
>> 3 files changed, 73 insertions(+), 9 deletions(-)
>> create mode 100644 gcc/testsuite/gcc.target/powerpc/pr108338.c
>>
>> diff --git a/gcc/config/rs6000/predicates.md
>> b/gcc/config/rs6000/predicates.md
>> index 52c65534e51..e57c9d99c6b 100644
>> --- a/gcc/config/rs6000/predicates.md
>> +++ b/gcc/config/rs6000/predicates.md
>> @@ -2064,3 +2064,8 @@ (define_predicate "macho_pic_address"
>>else
>> return false;
>> })
>> +
>> +(define_predicate "lowpart_subreg_operator"
>> + (and (match_code "subreg")
>> + (match_test "subreg_lowpart_offset (mode, GET_MODE (SUBREG_REG (op)))
>> +== SUBREG_BYTE (op)")))
>> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
>> index 4a7812fa592..5b4a7f8d801 100644
>> --- a/gcc/config/rs6000/rs6000.md
>> +++ b/gcc/config/rs6000/rs6000.md
>> @@ -7539,6 +7539,14 @@ (define_split
>> UNSPEC_MOVSI_GOT))]
>>"")
>>
>> +(define_insn "si2sf_mtvsrws"
>> + [(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
>> + (subreg:SF (match_operand:SI 1 "gpc_reg_operand" "r") 0))]
>> + "TARGET_P9_VECTOR && TARGET_XSCVSPDPN"
>> + "mtvsrws %x0,%1\n\txscvspdpn %x0,%x0"
>> + [(set_attr "type" "mfvsr")
>> + (set_attr "length" "8")])
>> +
>> ;; MR LA
>> ;; LWZ LFIWZX LXSIWZX
>> ;; STW STFIWX STXSIWX
>> @@ -8203,10 +8211,18 @@ (define_insn_and_split "movsf_from_si"
>>rtx op2 = operands[2];
>>rtx op1_di = gen_rtx_REG (DImode, REGNO (op1));
>>
>> - /* Move SF value to upper 32-bits for xscvspdpn. */
>> - emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
>> - emit_insn (gen_p8_mtvsrd_sf (op0, op2));
>> - emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
>> + if (TARGET_P9_VECTOR)
>> +{
>> + emit_insn (gen_si2sf_mtvsrws (op0, gen_lowpart (SImode, op1_di)));
>> +}
>> + else
>> +{
>> + /* Move SF value to upper 32-bits for xscvspdpn. */
>> + emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
>> + emit_insn (gen_p8_mtvsrd_sf (op0, op2));
>> + emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
>> +}
>> +
>>DONE;
>> }
>>[(set_attr "length"
>> @@ -8219,18 +8235,19 @@ (define_insn_and_split "movsf_from_si"
>> "*, *, p9v, p8v, *, *,
>> p8v,p8v, p8v, *")])
>>
>> +(define_code_iterator any_rshift [ashiftrt lshiftrt])
>> +
>> ;; For extracting high part element from DImode register like:
>> ;; {%1:SF=unspec[r122:DI>>0x20#0] 86;clobber scratch;}
>> ;; split it before reload with "and mask" to avoid generating shift right
>> ;; 32 bit then shift left 32 bit.
>> -(define_insn_and_split "movsf_from_si2"
>> +(define_insn_and_split "movsf_from_si2_"
>>[(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
>> (unspec:SF
>> - [(subreg:SI
>> - (ashiftrt:DI
>> + [(match_operator:SI 3 "lowpart_subreg_operator"
>> + [(any_rshift:DI
>> (match_operand:DI 1 "input_operand" "r")
>> -(const_int 32))
>> - 0)]
>> +(const_int 32))])]
>> UNSPEC_SF_FROM_SI))
>>(clobber (match_scratch:DI 2 "=r"))]
>>"TARGET_NO_SF_SUBREG"
>> diff --git
ping: [PATCH V2] rs6000: Enhance lowpart/highpart DI->SF by mtvsrws/mtvsrd
Hi
I would like to ping this patch for stage1:
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612168.html
BR,
Jeff (Jiufu)
Jiufu Guo writes:
> Hi,
>
> Compare with previous version:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609654.html
> This patch does not use UNSPEC for insn mtvsrws anymore. And to handle
> the subreg better on BE and LE, predicate "lowpart_subreg_operator"
> is introducted. To help combine pass to match the pattern on high32
> bit of DI, shiftrt is still used.
>
> As mentioned in PR108338, on p9, we could use mtvsrws to implement
> the conversion from SI#0 to SF (or lowpart DI to SF).
>
> For examples:
> *(long long*)buff = di;
> float f = *(float*)(buff);
> We generate "sldi 9,3,32 ; mtvsrd 1,9 ; xscvspdpn 1,1" instead of
> "mtvsrws 1,3 ; xscvspdpn 1,1".
>
> This patch update this, and also enhance the bitcast from highpart
> DI to SF.
>
> Bootstrap and regtests pass on ppc64{,le}.
> Is this ok for trunk?
>
> BR,
> Jeff (Jiufu)
>
> PR target/108338
>
> gcc/ChangeLog:
>
> * config/rs6000/predicates.md (lowpart_subreg_operator): New
> define_predicate.
> * config/rs6000/rs6000.md (any_rshift): New code_iterator.
> (movsf_from_si2): Rename to...
> (movsf_from_si2_): ... this.
> (si2sf_mtvsrws): New define_insn.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/powerpc/pr108338.c: New test.
>
> ---
> gcc/config/rs6000/predicates.md | 5 +++
> gcc/config/rs6000/rs6000.md | 35 -
> gcc/testsuite/gcc.target/powerpc/pr108338.c | 42 +
> 3 files changed, 73 insertions(+), 9 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/powerpc/pr108338.c
>
> diff --git a/gcc/config/rs6000/predicates.md b/gcc/config/rs6000/predicates.md
> index 52c65534e51..e57c9d99c6b 100644
> --- a/gcc/config/rs6000/predicates.md
> +++ b/gcc/config/rs6000/predicates.md
> @@ -2064,3 +2064,8 @@ (define_predicate "macho_pic_address"
>else
> return false;
> })
> +
> +(define_predicate "lowpart_subreg_operator"
> + (and (match_code "subreg")
> + (match_test "subreg_lowpart_offset (mode, GET_MODE (SUBREG_REG (op)))
> + == SUBREG_BYTE (op)")))
> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
> index 4a7812fa592..5b4a7f8d801 100644
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -7539,6 +7539,14 @@ (define_split
>UNSPEC_MOVSI_GOT))]
>"")
>
> +(define_insn "si2sf_mtvsrws"
> + [(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
> + (subreg:SF (match_operand:SI 1 "gpc_reg_operand" "r") 0))]
> + "TARGET_P9_VECTOR && TARGET_XSCVSPDPN"
> + "mtvsrws %x0,%1\n\txscvspdpn %x0,%x0"
> + [(set_attr "type" "mfvsr")
> + (set_attr "length" "8")])
> +
> ;; MR LA
> ;; LWZ LFIWZX LXSIWZX
> ;; STW STFIWX STXSIWX
> @@ -8203,10 +8211,18 @@ (define_insn_and_split "movsf_from_si"
>rtx op2 = operands[2];
>rtx op1_di = gen_rtx_REG (DImode, REGNO (op1));
>
> - /* Move SF value to upper 32-bits for xscvspdpn. */
> - emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
> - emit_insn (gen_p8_mtvsrd_sf (op0, op2));
> - emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
> + if (TARGET_P9_VECTOR)
> +{
> + emit_insn (gen_si2sf_mtvsrws (op0, gen_lowpart (SImode, op1_di)));
> +}
> + else
> +{
> + /* Move SF value to upper 32-bits for xscvspdpn. */
> + emit_insn (gen_ashldi3 (op2, op1_di, GEN_INT (32)));
> + emit_insn (gen_p8_mtvsrd_sf (op0, op2));
> + emit_insn (gen_vsx_xscvspdpn_directmove (op0, op0));
> +}
> +
>DONE;
> }
>[(set_attr "length"
> @@ -8219,18 +8235,19 @@ (define_insn_and_split "movsf_from_si"
> "*, *, p9v, p8v, *, *,
>p8v,p8v, p8v, *")])
>
> +(define_code_iterator any_rshift [ashiftrt lshiftrt])
> +
> ;; For extracting high part element from DImode register like:
> ;; {%1:SF=unspec[r122:DI>>0x20#0] 86;clobber scratch;}
> ;; split it before reload with "and mask" to avoid generating shift right
> ;; 32 bit then shift left 32 bit.
> -(define_insn_and_split "movsf_from_si2"
> +(define_insn_and_split "movsf_from_si2_"
>[(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
> (unspec:SF
> - [(subreg:SI
> -(ashiftrt:DI
> + [(match_operator:SI 3 "lowpart_subreg_operator"
> +[(any_rshift:DI
> (match_operand:DI 1 "input_operand" "r")
> - (const_int 32))
> -0)]
> + (const_int 32))])]
>UNSPEC_SF_FROM_SI))
>(clobber (match_scratch:DI 2 "=r"))]
>"TARGET_NO_SF_SUBREG"
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr108338.c
> b/gcc/testsuite/gcc.target/powerpc/pr108338.c
> new file mode 100644
> index 000..2438dc13f41
> --- /dev/null
> +++ b/g
