Re: r 262451

2018-08-20 Thread Iain Sandoe


> On 20 Aug 2018, at 15:55, Alexander Monakov  wrote:
> On Mon, 20 Aug 2018, Iain Sandoe wrote:
> 
>> I am seeing excess changes when running

I meant regenerating .. not running.. 

>> configure, is it possible the regenerated files were missed from this rev?
>> 
>> https://gcc.gnu.org/ml/gcc-cvs/2018-07/msg00172.html
> 
> Yes, that change did not regenerate configure scripts.  I've also noticed 
> that.
> 
> I considered filing a bug, but the changes in question are so trivial I
> decided it totally not worth the trouble. They only affect pgcc compilers.

Hmm the revision changelog

 * libtool.m4: Sort output of 'find' to enable deterministic builds.
 * ltmain.sh: Likewise.

Agreed the changes are superficially not complex, but libtool changes affect 
most
 (probably all?) of the configure scripts, which means that the next 
regeneration
of each will end up commiting unrelated hunks - or one has to edit them out.

- it would be neater to have a single commit to accommodate any that haven’t
happened as fallout of other changes in the intervening time?

Iain



Re: r 262451

2018-08-20 Thread Alexander Monakov



On Mon, 20 Aug 2018, Iain Sandoe wrote:

> I am seeing excess changes when running configure, is it possible the 
> regenerated files were missed from this rev?
> 
> https://gcc.gnu.org/ml/gcc-cvs/2018-07/msg00172.html

Yes, that change did not regenerate configure scripts.  I've also noticed that.

I considered filing a bug, but the changes in question are so trivial I
decided it totally not worth the trouble. They only affect pgcc compilers.

Alexander


r 262451

2018-08-20 Thread Iain Sandoe
I am seeing excess changes when running configure, is it possible the 
regenerated files were missed from this rev?

https://gcc.gnu.org/ml/gcc-cvs/2018-07/msg00172.html

thanks
Iain