[Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629 Sam James changed: What|Removed |Added See Also||https://github.com/Rust-GCC ||/gccrs/issues/1996 CC||sjames at gcc dot gnu.org -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629
Andrew Pinski changed:
What|Removed |Added
Ever confirmed|0 |1
Last reconfirmed||2024-04-07
Status|UNCONFIRMED |NEW
Keywords||diagnostic
--- Comment #1 from Andrew Pinski ---
Confirmed.
else if (funny_error)
{
/* This was a "break rust" or "break gcc", and the identifier failed to
resolve. Emit a funny ICE. We set the finalizer to our custom one,
and use the lower-level emit_diagnostic () instead of the more common
internal_error_no_backtrace () in order to pass our locus. */
diagnostic_finalizer (global_dc) = funny_ice_finalizer;
emit_diagnostic (DK_ICE_NOBT, expr.get_locus (), -1,
"are you trying to break %s? how dare you?",
expr.as_string ().c_str ());
This is not even that funny.
I suggest to remove the idea of funny_error really.
if (ident == "rust" || ident == "gcc")
funny_error = true;
...
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug rust/114629] New: rust-ast-resolve-expr contains bloated code for funny_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629 Bug ID: 114629 Summary: rust-ast-resolve-expr contains bloated code for funny_error Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: rust Assignee: unassigned at gcc dot gnu.org Reporter: roland.illig at gmx dot de CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org Target Milestone: --- The file contains funny_error, which unnecessarily bloats the executable in all installations. That's a waste of resources. The identifier funny_error should be removed, including everything that depends on it. (Background: As the German translator of GCC, I strictly oppose against insulting the GCC users, therefore I have translated that message free of any humor. There's enough code bloat already, I consider this one unnecessary.) -- You are receiving this mail because: You are on the CC list for the bug.
