Re: [Geany-devel] Empty project properties dialog
On 01/11/2012 11:10 PM, Lex Trotman wrote: On Thu, Jan 12, 2012 at 1:25 PM, Matthew Brush wrote: On 01/11/2012 04:11 PM, Jiří Techet wrote: On Mon, Jan 9, 2012 at 01:05, Matthew Brushwrote: On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it. 3. Open it for the second time. Result: the project properties dialog is much smaller and it's empty. I suspect it's related to the GtkBuiler transition. I haven't looked into it because I guess Matthew knows better what might be wrong. I fixed this in: https://github.com/geany/geany/commit/0755b44db1a238a65d7b3cec7f8b11430c8b2f1e If you don't mind to test around the project preferences dialog a bit to see if you can spot any more problems it would great. In general it seems to be fixed. However, there's one related problem - in GProject I add additional tab to the dialog. At the moment I'm adding the tab every time the dialog appears because before the GtkBuilder changes the dialog was destroyed once it was closed. Now it seems you reuse the same dialog which means I should change the GProject behavior otherwise new and new GProject tabs are added every time the dialog appears. If this new behavior is official then the plugins API version should be bumped because it changes their behavior. Yeah, I guess that couldn't hurt, although according to the docs, this is how the API version is supposed to be used[1]: "The Application Programming Interface (API) version, incremented whenever any plugin data types are modified or appended to." Which is why I never touched the API version, since it's quite clear when to increment it[2]. Cheers, Matthew Brush [1] Although I personally dislike this in general since it does not give any indication when new functions are added or removed or like this case where behaviour is changed, nor does it give any correlation between API version and the currently running version of Geany. In other words, it seems basically useless, IMO. [2] Despite the example in the same comment that shows it being used to guard a function, which can't actually be guarded since there's no way to know what API version to check for functions. Hi Guys, This should be an ABI and API change unfortunately, current functions do not work the way they did so old plugins (eg old GProjects) won't work. API without ABI is for adding new stuff that does not prevent current plugins from working. There was no change in documented functions, signals or behaviour AFAIK. Would you, for example, increment the API and ABI if GeanyPluginX depended on the fact that the main GtkVBox widget in the Glade file was named `vbox1` and we changed it to `vbox_main`? In this case GProject was (understandably) relying on undefined internal behaviour of Geany rather than using the signal provided in the API to allow a plugin to remove the notebook page from the projects dialog (not that the docs would lead you to believe this, in fact the opposite). Since we're loading plugins into the Geany process with basically complete access to everything, then we should bump the API version on every commit, since we could potentially be changing undocumented internal behaviour that the plugins can have access to if they really want. In any case, the docs, especially for `project_dialog_confirmed` should be improved/fixed. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Empty project properties dialog
On Thu, Jan 12, 2012 at 1:25 PM, Matthew Brush wrote: > On 01/11/2012 04:11 PM, Jiří Techet wrote: >> >> On Mon, Jan 9, 2012 at 01:05, Matthew Brush wrote: >>> >>> On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it. 3. Open it for the second time. Result: the project properties dialog is much smaller and it's empty. I suspect it's related to the GtkBuiler transition. I haven't looked into it because I guess Matthew knows better what might be wrong. >>> >>> I fixed this in: >>> >>> https://github.com/geany/geany/commit/0755b44db1a238a65d7b3cec7f8b11430c8b2f1e >>> >>> If you don't mind to test around the project preferences dialog a bit to >>> see >>> if you can spot any more problems it would great. >> >> >> In general it seems to be fixed. >> >> However, there's one related problem - in GProject I add additional >> tab to the dialog. At the moment I'm adding the tab every time the >> dialog appears because before the GtkBuilder changes the dialog was >> destroyed once it was closed. Now it seems you reuse the same dialog >> which means I should change the GProject behavior otherwise new and >> new GProject tabs are added every time the dialog appears. If this new >> behavior is official then the plugins API version should be bumped >> because it changes their behavior. >> > > Yeah, I guess that couldn't hurt, although according to the docs, this is > how the API version is supposed to be used[1]: > > "The Application Programming Interface (API) version, incremented whenever > any plugin data types are modified or appended to." > > Which is why I never touched the API version, since it's quite clear when to > increment it[2]. > > Cheers, > Matthew Brush > > [1] Although I personally dislike this in general since it does not give any > indication when new functions are added or removed or like this case where > behaviour is changed, nor does it give any correlation between API version > and the currently running version of Geany. In other words, it seems > basically useless, IMO. > > [2] Despite the example in the same comment that shows it being used to > guard a function, which can't actually be guarded since there's no way to > know what API version to check for functions. > Hi Guys, This should be an ABI and API change unfortunately, current functions do not work the way they did so old plugins (eg old GProjects) won't work. API without ABI is for adding new stuff that does not prevent current plugins from working. Cheers Lex > ___ > Geany-devel mailing list > Geany-devel@uvena.de > https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Geany-Plugins: MAINTAINERS file
On 01/11/2012 05:13 AM, Frank Lanitz wrote: Am 10.01.2012 23:46, schrieb Matthew Brush: On 01/07/2012 07:20 AM, Colomban Wendling wrote: Le 07/01/2012 16:00, Frank Lanitz a écrit : On Fri, 6 Jan 2012 23:42:39 +0100 Frank Lanitz wrote: * What's the exact difference between Supported and Maintained? The only difference I see is that "supported" has the word "paid" in the description, but I doubt that most of us get paid for this in particular, and I also doubt it changes anything on how good is the support (hobby vs. job). My fault. I wanted to change this but missed it. I wanted to s/supported/paid for ... (Even I don't know anybody at the moment who is getting paid with Geany stuff ;) ) I suggest to use paid instead of supported and change current usage of supported to maintained. I'm still not sure what that fact someone is paid or not changes, but otherwise it looks fine and clearer to me. +1 Whether paid or volunteer, it's still "Maintained". I suggest dropping the "Paid" status altogether if no one has used it by the time all the plugins' info is filled in. I disagree. Currently there might be no plugin maintainer being paid to work on a plugin, but: - this might change (...) - is something user should be able to see to resynch there demandings with reality. Hehehe, well said. OK, it's not a big deal, though I still feel it's not very useful for Geany-Plugins. I'm reading e.g. support@pidgin mailing list and more than once a week I need to facepalm myself because of users don't understand they are not talking to some paid support. I really don't want to end up on Geany with such situation. You aren't kidding! I was reading a bug report[1] on Pidgin's tracker a while back about the auto-sizing of a text box or something and the tone was absolutely incredible, including demands, threats, name-calling and much more. I couldn't work on a project like Pidgin with so many disrespectful users. Cheers, Matthew Brush [1] I think it was: http://developer.pidgin.im/ticket/4986 ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Empty project properties dialog
On 01/11/2012 04:11 PM, Jiří Techet wrote: On Mon, Jan 9, 2012 at 01:05, Matthew Brush wrote: On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it. 3. Open it for the second time. Result: the project properties dialog is much smaller and it's empty. I suspect it's related to the GtkBuiler transition. I haven't looked into it because I guess Matthew knows better what might be wrong. I fixed this in: https://github.com/geany/geany/commit/0755b44db1a238a65d7b3cec7f8b11430c8b2f1e If you don't mind to test around the project preferences dialog a bit to see if you can spot any more problems it would great. In general it seems to be fixed. However, there's one related problem - in GProject I add additional tab to the dialog. At the moment I'm adding the tab every time the dialog appears because before the GtkBuilder changes the dialog was destroyed once it was closed. Now it seems you reuse the same dialog which means I should change the GProject behavior otherwise new and new GProject tabs are added every time the dialog appears. If this new behavior is official then the plugins API version should be bumped because it changes their behavior. Yeah, I guess that couldn't hurt, although according to the docs, this is how the API version is supposed to be used[1]: "The Application Programming Interface (API) version, incremented whenever any plugin data types are modified or appended to." Which is why I never touched the API version, since it's quite clear when to increment it[2]. Cheers, Matthew Brush [1] Although I personally dislike this in general since it does not give any indication when new functions are added or removed or like this case where behaviour is changed, nor does it give any correlation between API version and the currently running version of Geany. In other words, it seems basically useless, IMO. [2] Despite the example in the same comment that shows it being used to guard a function, which can't actually be guarded since there's no way to know what API version to check for functions. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Q: how to switch to new Git repo?
On Fri, Jan 6, 2012 at 18:00, Eugene Arshinov wrote: > It seems that everything went fine. > > My personal fork is https://github.com/earshinov/geany/, and the new > home for sm branch is https://github.com/earshinov/geany/tree/sm. > > Jiří, > > I suppose you can safely remove your sm-branch repository. Thank you > for keeping it for so long! > No problem, I've just removed it. Jiri ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Empty project properties dialog
On Mon, Jan 9, 2012 at 01:05, Matthew Brush wrote: > On 12/26/2011 01:37 PM, Jiří Techet wrote: >> >> Hi, >> >> I'm experiencing a bug where the project properties dialog is empty >> when opened for the second time. Steps to reproduce: >> >> 1. Open project properties dialog. >> 2. Close it. >> 3. Open it for the second time. >> >> Result: the project properties dialog is much smaller and it's empty. >> >> I suspect it's related to the GtkBuiler transition. I haven't looked >> into it because I guess Matthew knows better what might be wrong. >> > > I fixed this in: > https://github.com/geany/geany/commit/0755b44db1a238a65d7b3cec7f8b11430c8b2f1e > > If you don't mind to test around the project preferences dialog a bit to see > if you can spot any more problems it would great. In general it seems to be fixed. However, there's one related problem - in GProject I add additional tab to the dialog. At the moment I'm adding the tab every time the dialog appears because before the GtkBuilder changes the dialog was destroyed once it was closed. Now it seems you reuse the same dialog which means I should change the GProject behavior otherwise new and new GProject tabs are added every time the dialog appears. If this new behavior is official then the plugins API version should be bumped because it changes their behavior. Cheers, Jiri ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Geany-Plugins: MAINTAINERS file
Hi >> I suggest dropping the "Paid" status altogether if no one has used it by >> the time all the plugins' info is filled in. > > I disagree. Currently there might be no plugin maintainer being paid to > work on a plugin, but: > - this might change (...) > - is something user should be able to see to resynch there demandings > with reality. > > I'm reading e.g. support@pidgin mailing list and more than once a week I > need to facepalm myself because of users don't understand they are not > talking to some paid support. I really don't want to end up on Geany > with such situation. Even if someone is paid, he will probably be paid to do something that person that is paying want (feature, bug fix), not helping random people with support. But such status will just make someone say something like: "Hey, you are being paid, DO AS I WANT AT ONCE!!!" -- Best regards, Yury Siamashka ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Geany-Plugins: MAINTAINERS file
Am 10.01.2012 23:46, schrieb Matthew Brush: > On 01/07/2012 07:20 AM, Colomban Wendling wrote: >> Le 07/01/2012 16:00, Frank Lanitz a écrit : >>> On Fri, 6 Jan 2012 23:42:39 +0100 >>> Frank Lanitz wrote: >>> > * What's the exact difference between Supported and Maintained? The > only difference I see is that "supported" has the word "paid" in the > description, but I doubt that most of us get paid for this in > particular, and I also doubt it changes anything on how good is the > support (hobby vs. job). My fault. I wanted to change this but missed it. I wanted to s/supported/paid for ... (Even I don't know anybody at the moment who is getting paid with Geany stuff ;) ) >>> >>> I suggest to use paid instead of supported and change current usage of >>> supported to maintained. >> >> I'm still not sure what that fact someone is paid or not changes, but >> otherwise it looks fine and clearer to me. > > +1 > > Whether paid or volunteer, it's still "Maintained". > > I suggest dropping the "Paid" status altogether if no one has used it by > the time all the plugins' info is filled in. I disagree. Currently there might be no plugin maintainer being paid to work on a plugin, but: - this might change (...) - is something user should be able to see to resynch there demandings with reality. I'm reading e.g. support@pidgin mailing list and more than once a week I need to facepalm myself because of users don't understand they are not talking to some paid support. I really don't want to end up on Geany with such situation. Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
