Re: gEDA-user: pcb option --fab-author not working
(sorry, this is off-topic)
diff --git a/src/misc.c b/src/misc.c
index 693da81..89d5c84 100644
--- a/src/misc.c
+++ b/src/misc.c
@@ -1836,18 +1836,18 @@ LayerGroupsToString (LayerGroupTypePtr lg)
char *
pcb_author (void)
{
-#ifdef HAVE_GETPWUID
- static struct passwd *pwentry;
static char *fab_author = 0;
if (!fab_author)
{
if (Settings.FabAuthor Settings.FabAuthor[0])
fab_author = Settings.FabAuthor;
+#ifdef HAVE_GETPWUID
else
{
int len;
char *comma, *gecos;
+ static struct passwd *pwentry;
/* ID the user. */
pwentry = getpwuid (getuid ());
@@ -1857,20 +1857,15 @@ pcb_author (void)
len = comma - gecos;
else
len = strlen (gecos);
- fab_author = malloc (len + 1);
- if (!fab_author)
-{
- perror (pcb: out of memory.\n);
- exit (-1);
-}
+ fab_author = MyMalloc (len + 1, pcb_author);
memcpy (fab_author, gecos, len);
fab_author[len] = 0;
}
+#endif
}
- return fab_author;
-#else
+ if (fab_author)
+return fab_author;
return Unknown;
-#endif
}
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb option --fab-author not working
Ineiev ine...@gmail.com wrote: But actually it does not claim this is fab author, it intentionally reports the Unix user who saved the board. if you want to save author info in the PCB you probably can use attributes. In my code of honor a PCB designer who lays out an Open Source Hardware board deserves to have his/her name on the silk screen, at least on the bottom side if there is no room on the top component side. Once the fame/honor attribution of the OSH project contributor(s) has been secured in this manner, the header comment in the .pcb file becomes less important IMO. MS ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb option --fab-author not working
On Sun, Sep 20, 2009 at 2:00 PM, Michael Sokolov msoko...@ivan.harhan.org wrote: Ineiev ine...@gmail.com wrote: In my code of honor a PCB designer who lays out an Open Source Hardware board deserves to have his/her name on the silk screen If you layout a board and submit it to something like a Circuit Cellar Contest, you are not allowed to have any personal identify marks on the board, so that the judges remain neutral. Even in Open Source Hardware there are valid reasons for not wanting a name on the board. -- http://www.wearablesmartsensors.com/ http://www.softwaresafety.net/ http://www.designer-iii.com/ http://www.unusualresearch.com/ ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb option --fab-author not working
On Sun, Sep 20, 2009 at 06:00:11PM +, Michael Sokolov wrote: In my code of honor a PCB designer who lays out an Open Source Hardware board deserves to have his/her name on the silk screen, at least on the bottom side if there is no room on the top component side. I personally think author information is important enough to put in copper, not just silk. Also, don't forget to include the date, and either an internal documentation reference number or (the more modern alternative) a URL for board documentation. Finally, most people and organizations try to squeeze a logo on the board somewhere. I know I do. There are certainly other uses for documentation incorporated in the file but not part of the final artwork. - Larry ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb option --fab-author not working
If you layout a board and submit it to something like a Circuit Cellar Contest, you are not allowed to have any personal identify marks on the board, Not quite true. You can't have *visible* identifying marks, but it's OK to (for example) just blur out the name, or use a low enough resolution so that you can't quite make it out. My boards always say (C) 2009 DJ Delorie on them, but I asked CC and they said that was OK. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb option --fab-author not working
On Sat September 19 2009 12:10:40 pm Kai-Martin Knaak wrote: If I try to set the author variable with pcb --fab-author foobar the resulting pcb file still contains my user name read from the passwd file. ---(kaimartin)--- Same here, except when I set author as above and then export gerbers. Now in gerbv I see foobar as the author. But the pcb still shows my system username even after saving the pcb. -Mark Stanley ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb option --fab-author not working
On 9/19/09, Kai-Martin Knaak k...@familieknaak.de wrote: If I try to set the author variable with pcb --fab-author foobar the resulting pcb file still contains my user name read from the passwd file. But actually it does not claim this is fab author, it intentionally reports the Unix user who saved the board. if you want to save author info in the PCB you probably can use attributes. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
