Re: gEDA-user: Bug: Screenupdate on moving selected objects
Thank you, it's fixed at my system, now! Am 02.05.2011 00:54, schrieb Peter Clifton: On Sun, 2011-05-01 at 22:16 +0100, Peter Clifton wrote: On Sun, 2011-05-01 at 22:55 +0200, Felix Ruoff wrote: Hello! Since commit e323e4636ef7b7239003a41ba305221bc6d9bab1 'hid/gtk: Invalidate the damaged region, not the whole view' there is an error on moving selected objects. If you select an element (footprint, line, ...) and move it with a second klick+drag, just a small part of the view is rendered during moving/dragging. The remain of the screen is rendered white. Yep, I can reproduce it here.. I realised it was broken last night but haven't had a chance to fix the issue yet. ... Chances are that the underlying problem was existing, but our rather conservative policy of redrawing the whole screen every frame may have masked it. Should be fixed in git HEAD now. There were two bugs (I counted so far), both were my doing, and specific to the GTK/GDK rendering. One was failing to clear the clip-region of a graphics context we then went on to use in the expose handler (the cause of the non-painting you saw where the majority of the screen was rendered in the default widget colour). The second was more subtle, and I'd swapped the X and Y coordinate conversion macros (not their inputs) when calculating the region to update on screen - so it was wrong for any case where the board was flipped, or panned away from the (0,0) origin unequally in the X and Y directions. ___ geda-user mailing list [1]geda-user@moria.seul.org [2]http://www.seul.org/cgi-bin/mailman/listinfo/geda-user References 1. mailto:geda-user@moria.seul.org 2. http://www.seul.org/cgi-bin/mailman/listinfo/geda-user ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Bug: Screenupdate on moving selected objects
On Sun, 2011-05-01 at 22:16 +0100, Peter Clifton wrote: > On Sun, 2011-05-01 at 22:55 +0200, Felix Ruoff wrote: > > Hello! > >Since commit e323e4636ef7b7239003a41ba305221bc6d9bab1 'hid/gtk: > >Invalidate the damaged region, not the whole view' there is an error on > >moving selected objects. If you select an element (footprint, line, > >...) and move it with a second klick+drag, just a small part of the > >view is rendered during moving/dragging. The remain of the screen is > >rendered white. > > Yep, I can reproduce it here.. I realised it was broken last night but > haven't had a chance to fix the issue yet. ... > Chances are that the underlying problem was existing, but our rather > conservative policy of redrawing the whole screen every frame may have > masked it. Should be fixed in git HEAD now. There were two bugs (I counted so far), both were my doing, and specific to the GTK/GDK rendering. One was failing to clear the clip-region of a graphics context we then went on to use in the expose handler (the cause of the non-painting you saw where the majority of the screen was rendered in the default widget colour). The second was more subtle, and I'd swapped the X and Y coordinate conversion macros (not their inputs) when calculating the region to update on screen - so it was wrong for any case where the board was flipped, or panned away from the (0,0) origin unequally in the X and Y directions. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Bug: Screenupdate on moving selected objects
On Sun, 2011-05-01 at 22:55 +0200, Felix Ruoff wrote: > Hello! >Since commit e323e4636ef7b7239003a41ba305221bc6d9bab1 'hid/gtk: >Invalidate the damaged region, not the whole view' there is an error on >moving selected objects. If you select an element (footprint, line, >...) and move it with a second klick+drag, just a small part of the >view is rendered during moving/dragging. The remain of the screen is >rendered white. Yep, I can reproduce it here.. I realised it was broken last night but haven't had a chance to fix the issue yet. >I am really looking forward to have the gl features in the default-pcb! >The amount of work on committing patches is really impressive during >the last days, thank you! Hope, to find some time in the next days to >do some coding for pcb, too :-). Irritatingly the branch is still as long as ever! On the other hand, the architectural refactoring required is nearly done - just some re-shuffling of draw.c to be done now really. I've got some idea of what it needs to look like, but I hate designing APIs! I look forward to your patches. >I did not open a bug-report for this. I will do it, if it is not fixed >in the next days 'as a reminder'. Thanks for the reminder - sorry you had to take the trouble of bisecting to find which patch I broke it with! Chances are that the underlying problem was existing, but our rather conservative policy of redrawing the whole screen every frame may have masked it. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
gEDA-user: Bug: Screenupdate on moving selected objects
Hello! Since commit e323e4636ef7b7239003a41ba305221bc6d9bab1 'hid/gtk: Invalidate the damaged region, not the whole view' there is an error on moving selected objects. If you select an element (footprint, line, ...) and move it with a second klick+drag, just a small part of the view is rendered during moving/dragging. The remain of the screen is rendered white. I am really looking forward to have the gl features in the default-pcb! The amount of work on committing patches is really impressive during the last days, thank you! Hope, to find some time in the next days to do some coding for pcb, too :-). Kind regards, Felix I did not open a bug-report for this. I will do it, if it is not fixed in the next days 'as a reminder'. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
