Re: gEDA-user: PCB: option dumpmenu missing

2011-05-31 Thread Kai-Martin Knaak 
Felix Ruoff wrote:

 First thing: The patch does not apply to my git repository :-(.

:-| 


 Do you 
 have an actualized version of this patch, that fit to actual git head? 

No. I did not touch the subject since last year.


 Second thing: In the list of HIDs (line 311-323 of your patch) is the 
 gcode-HID missing.

The gcode HID is pretty new. First time I see it mentioned in the mailing 
list is november 2009. Seems like it had not made it to the repo when I
did the command line option patch.

 
 Third thing: I have started to include the first items of your patch by 
 hand to my code. The documentation-generation stops with the message
 /home/felix/Downloads/geda-git-source/pcb/doc//options.texi:6: `BOM 
 Creation' has no Up field (perhaps incorrect sectioning?).

IIRC, this means, that there is a section command missing in the texi 
code.


 Last thing: I think the same about the numbering and table-formatting as 
 DJ said in his message 
 http://thread.gmane.org/gmane.comp.cad.geda.user/29944/focus=30083. I 
 think, I would prefer the last solution he suggests (extracting to 
 multiple files), but this are just my 2 cent.

I agree, that this may be better. But it escapes me, why my patch has
to be perfect to be considered for application. Command line documentation
in the manual is as broken as can be. Anything would be better than the 
current list of bogus options. There is no hint how to get the real list 
of options, either. My patch not only produced a command line section 
with viable options. It also moved the documentation to the code, so it 
would have been easier to maintain. 
Still, it was rejected (after I had to bug the list twice for any reaction 
at all) because a different solution may be somewhat more elegant. If this
is the yardstick improvements must meet, then contribution to geda is beyond 
my ability. In any case, it clearly surpassed my frustration level. So I 
let go and directed my efforts to other projects else (not geda).

 ---)kaimartin(---

-- 
Kai-Martin Knaak
Email: k...@familieknaak.de
Öffentlicher PGP-Schlüssel:
http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53



___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-31 Thread Felix Ruoff 

Thanks for your reply!

Am 01.06.2011 00:51, schrieb Kai-Martin Knaak:

Second thing: In the list of HIDs (line 311-323 of your patch) is the
gcode-HID missing.

The gcode HID is pretty new. First time I see it mentioned in the mailing
list is november 2009. Seems like it had not made it to the repo when I
did the command line option patch.

Oh! I did not know, that this is such a new feature! (Used pcb the first 
time in summer 2010)

Third thing: I have started to include the first items of your patch by
hand to my code. The documentation-generation stops with the message
/home/felix/Downloads/geda-git-source/pcb/doc//options.texi:6: `BOM
Creation' has no Up field (perhaps incorrect sectioning?).

IIRC, this means, that there is a section command missing in the texi
code.



Thanks for the hint, I will try to figure out my mistake.

Last thing: I think the same about the numbering and table-formatting as
DJ said in his message
http://thread.gmane.org/gmane.comp.cad.geda.user/29944/focus=30083. I
think, I would prefer the last solution he suggests (extracting to
multiple files), but this are just my 2 cent.

I agree, that this may be better. But it escapes me, why my patch has
to be perfect to be considered for application. Command line documentation
in the manual is as broken as can be. Anything would be better than the
current list of bogus options.

Yes!


  [snip]

  ---)kaimartin(---
If you don't mind, I will rebase your patch and modify it to extract the 
docu-source to several files. Hope, this will get applied in the near 
future.


Kind regards,
Felix


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-27 Thread Felix Ruoff 

Hello Kai-Martin,

I have had a first look at your patch. You are right - nearly the whole 
documentation for the command-line actions is not up to date. So I 
think, the contend of your patch would improve the documentation a lot.


First thing: The patch does not apply to my git repository :-(. Do you 
have an actualized version of this patch, that fit to actual git head? 
Otherwise, I would hand-edit everything. No problem, but this will take 
some time.


Second thing: In the list of HIDs (line 311-323 of your patch) is the 
gcode-HID missing.


Third thing: I have started to include the first items of your patch by 
hand to my code. The documentation-generation stops with the message
/home/felix/Downloads/geda-git-source/pcb/doc//options.texi:6: `BOM 
Creation' has no Up field (perhaps incorrect sectioning?).


I have searched the internet for some time to fix this, but I didn't 
find a solution. Do you (or someone else here) have a hint for fixing this?


Last thing: I think the same about the numbering and table-formatting as 
DJ said in his message 
http://thread.gmane.org/gmane.comp.cad.geda.user/29944/focus=30083. I 
think, I would prefer the last solution he suggests (extracting to 
multiple files), but this are just my 2 cent.


Kind regards,
Felix

Am 26.05.2011 02:43, schrieb Kai-Martin Knaak:

Felix Ruoff wrote:


Later in that thread
(http://www.seul.org/pipermail/geda-user/2010-April/046781.html) you
said, that you will send the patches, but I can't find an attachment

I forgot to attach in that post and sent another one a few minutes
later:
   http://thread.gmane.org/gmane.comp.cad.geda.user/29944/focus=30083

The resulting section of the compiled manual is still available at
   http://lilalaser.de/tmp/pcb_commandline_options.pdf

---)kaimartin(---



___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread Felix Ruoff 

Hello,

in the pcb-documentation B.3 Menu Files and Defaults is the 
command-line option -dumpmenu described, but it did not work at my 
system. I have searched the source-code and just one boolean variable 
'DumpMenuFile' in global.h can be found. Did I miss something?


If someone of you confirms that this option is not avaiable, I will do a 
patch to remove this from docu and sourcecode.


Regards,
Felix


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread Kai-Martin Knaak 
Felix Ruoff wrote:

 in the pcb-documentation B.3 Menu Files and Defaults is the 
 command-line option -dumpmenu described,

Almost all the command line options described in the PCB manual are bogus.
Apparently, the options got a major rewrite sometime in the past which did not
make it into the documentation. 
 
Last year, I wrote a set patches to correct this and while at it, move the 
source of the information into the source. I introduced an additional 
parameter in the comment syntax to allow for arbitrary sequence in the 
compiled manual. The only developer who commented, did not like this. 
So the set of patches was not applied and the manual is still misleading
when it comes to command line options.

---)kaimartin(---
-- 
Kai-Martin Knaak  tel: +49-511-762-2895
Universität Hannover, Inst. für Quantenoptik  fax: +49-511-762-2211 
Welfengarten 1, 30167 Hannover   http://www.iqo.uni-hannover.de
GPG key:http://pgp.mit.edu:11371/pks/lookup?search=Knaak+kmkop=get



___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread Felix Ruoff 

Hello Kai-Martin,

Am 25.05.2011 16:32, schrieb Kai-Martin Knaak:
Last year, I wrote a set patches to correct this and while at it, move 
the

source of the information into the source. I introduced an additional
parameter in the comment syntax to allow for arbitrary sequence in the
compiled manual. The only developer who commented, did not like this.
So the set of patches was not applied and the manual is still misleading
when it comes to command line options.

---)kaimartin(---
I have no commit-access, so I can't commit your patches. But - I 
searched the mailing-archive and found this thread:


http://www.seul.org/pipermail/geda-user/2010-April/046634.html

with your first patch to expand the syntax. This was committed on 18 
April 2010 by DJ Delorie. Is this the mailing-thread you refer to?


Later in that thread 
(http://www.seul.org/pipermail/geda-user/2010-April/046781.html) you 
said, that you will send the patches, but I can't find an attachment 
(Perhaps, I am to blind...). I would really like to see this patches! 
For me, a good documentation is important :-). Perhaps you can point me 
to the patches or you can re-upload them to a new bug-report on launchpad?


Kind regards,
Felix


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread DJ Delorie 

I think that option is a leftover from my initial HID conversion.

It would have been lesstif-specific anyway, the gtk hid has its own
menu file (gpcb-menu.res, same locations)


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread Felix Ruoff 
A patch to remove this from documentation (and one variable from the 
source) is appended.

Kind regards,
Felix

Am 25.05.2011 19:11, schrieb DJ Delorie:

I think that option is a leftover from my initial HID conversion.

It would have been lesstif-specific anyway, the gtk hid has its own
menu file (gpcb-menu.res, same locations)


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

From 94458c63ae97135964c41f4966b9cdf65ee4ec27 Mon Sep 17 00:00:00 2001
From: Felix Ruoff fe...@posaunenmission.de
Date: Wed, 25 May 2011 14:36:34 +0200
Subject: [PATCH 50/50] Remove commandline-option 'dumpmenu' from docu and source

---
 doc/pcb.texi |7 ---
 src/global.h |1 -
 2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/doc/pcb.texi b/doc/pcb.texi
index ab02382..01d2687 100644
--- a/doc/pcb.texi
+++ b/doc/pcb.texi
@@ -5732,13 +5732,6 @@ application itself.  The master file for all this is the file
 used to create the internal menu definition as well as being installed
 in @file{$pcblibdir}.
 
-You can view the internal menu definition (the default) by running
-@file{pcb} with the @code{-dumpmenu} option, like this:
-
-@example
-pcb -dumpmenu
-@end example
-
 @c --- Appendix C ---
 @node Regular Expressions
 @appendix Element Search/Regular Expressions
diff --git a/src/global.h b/src/global.h
index 9ad5331..498e3f8 100644
--- a/src/global.h
+++ b/src/global.h
@@ -651,7 +651,6 @@ typedef struct			/* some resources... */
*GnetlistProgram,		/* gnetlist program name */
*MakeProgram,		/* make program name */
*InitialLayerStack;		/* If set, the initial layer stack is set to this */
-  bool DumpMenuFile;		/* dump internal menu definitions */
   LocationType PinoutOffsetX,	/* offset of origin */
 PinoutOffsetY;
   int PinoutTextOffsetX,	/* offset of text from pin center */
-- 
1.7.4.1



___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread DJ Delorie 

 A patch to remove this from documentation (and one variable from the 
 source) is appended.

Pushed.


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread Felix Ruoff 

Thank you!

Am 25.05.2011 19:21, schrieb DJ Delorie:

A patch to remove this from documentation (and one variable from the
source) is appended.

Pushed.


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user




___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: PCB: option dumpmenu missing

2011-05-25 Thread Kai-Martin Knaak 
Felix Ruoff wrote:

 Later in that thread 
 (http://www.seul.org/pipermail/geda-user/2010-April/046781.html) you 
 said, that you will send the patches, but I can't find an attachment 

I forgot to attach in that post and sent another one a few minutes 
later:
  http://thread.gmane.org/gmane.comp.cad.geda.user/29944/focus=30083

The resulting section of the compiled manual is still available at
  http://lilalaser.de/tmp/pcb_commandline_options.pdf

---)kaimartin(---
-- 
Kai-Martin Knaak
Email: k...@familieknaak.de
Öffentlicher PGP-Schlüssel:
http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53



___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user