Re: gEDA-user: gschem usability: expand the component tree after filtering
Hello,
I very like the feature Krzysztof introduced with his patch and would
like to have this feature in PCB, too.
The appended patch does exactly the same for pcb. The only modification
is, that the struct 'compselect' is called 'library_window' in pcb.
I have also done a feature request for this patch at
https://bugs.launchpad.net/pcb/+bug/753643.
Hope, some of you like this feature, too and hope to get it accepted.
Best regards,
Felix
Am 03.01.2011 00:52, schrieb Krzysztof Kościuszkiewicz:
All,
I found it annoying that I need to click through the whole component
tree after filtering the symbol file names. For some time I've been
running my copy with the change that expands the tree after the
filtering by name is done. This saves 1+ clicks in the most common
use-case: add a known symbol to the diagram.
The patch is here:
https://sourceforge.net/tracker/?func=detailaid=3149995group_id=161080atid=818428
Best regards,
From 9c552a71aaf457d648ad824af4101afffc960509 Mon Sep 17 00:00:00 2001
From: Felix Ruoff fe...@posaunenmission.de
Date: Thu, 7 Apr 2011 16:38:51 +0200
Subject: [PATCH] expand library tree after filtering
This patch changes the behavior of the library selection dialog.
After filtering by name is applied the tree view of matching components
is automatically expanded so that all leafs are immediately selectable.
The tree view is collapsed when the filter is cleared.
Patch is adapted from Krzysztof Kosciuszkiewicz's patch for gschem.
Closes-bug: lp-753643
---
src/hid/gtk/gui-library-window.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/hid/gtk/gui-library-window.c b/src/hid/gtk/gui-library-window.c
index b101576..8c8ae17 100644
--- a/src/hid/gtk/gui-library-window.c
+++ b/src/hid/gtk/gui-library-window.c
@@ -432,7 +432,16 @@ library_window_filter_timeout (gpointer data)
if (model != NULL)
{
+ const gchar *text = gtk_entry_get_text (library_window-entry_filter);
gtk_tree_model_filter_refilter ((GtkTreeModelFilter *) model);
+ if (strcmp (text, ) != 0)
+{
+ /* filter text not-empty */
+ gtk_tree_view_expand_all (library_window-libtreeview);
+} else {
+ /* filter text is empty, collapse expanded tree */
+ gtk_tree_view_collapse_all (library_window-libtreeview);
+}
}
/* return FALSE to remove the source */
--
1.7.1
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: gschem usability: expand the component tree after filtering
On Thu, Apr 07, 2011 at 04:59:12PM +0200, Felix Ruoff wrote: I have also done a feature request for this patch at https://bugs.launchpad.net/pcb/+bug/753643. Hope, some of you like this feature, too and hope to get it accepted. Pushed with changed patch title (added gtk/hid). Thanks! -- Krzysztof Kościuszkiewicz Simplicity is the ultimate sophistication -- Leonardo da Vinci ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: gschem usability: expand the component tree after filtering
Am 07.04.2011 21:35, schrieb Krzysztof Kościuszkiewicz: On Thu, Apr 07, 2011 at 04:59:12PM +0200, Felix Ruoff wrote: I have also done a feature request for this patch at https://bugs.launchpad.net/pcb/+bug/753643. Hope, some of you like this feature, too and hope to get it accepted. Pushed with changed patch title (added gtk/hid). Thanks! Thank you very much! This was really fast! ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: gschem usability: expand the component tree after filtering
2011/1/4 kai-martin knaak k...@familieknaak.de: +1 Every click that can be avoided for common tasks adds to the productivity. I hope, this patch will be accepted. Thanks to cooperation with Peter B it is already accepted. -- Krzysztof Kościuszkiewicz Simplicity is the ultimate sophistication -- Leonardo da Vinci ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: gschem usability: expand the component tree after filtering
On Tuesday 04 January 2011 08:59:26 Krzysztof Kościuszkiewicz wrote: 2011/1/4 kai-martin knaak k...@familieknaak.de: +1 Every click that can be avoided for common tasks adds to the productivity. I hope, this patch will be accepted. Thanks to cooperation with Peter B it is already accepted. Yes, I am being very proactive at the moment about giving prompt detailed feedback to patch submitters, and I am working with them to get patches ready quickly. :-) And Krzysztof's patch was obviously a good idea anyway. :-) Peter -- Peter Brett pe...@peter-b.co.uk Remote Sensing Research Group Surrey Space Centre signature.asc Description: This is a digitally signed message part. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: gschem usability: expand the component tree after filtering
Krzysztof Kościuszkiewicz wrote: I found it annoying that I need to click through the whole component tree after filtering the symbol file names. +1 Every click that can be avoided for common tasks adds to the productivity. I hope, this patch will be accepted. ---)kaimartin(--- -- Kai-Martin Knaak Öffentlicher PGP-Schlüssel: http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0x6C0B9F53 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
gEDA-user: gschem usability: expand the component tree after filtering
All, I found it annoying that I need to click through the whole component tree after filtering the symbol file names. For some time I've been running my copy with the change that expands the tree after the filtering by name is done. This saves 1+ clicks in the most common use-case: add a known symbol to the diagram. The patch is here: https://sourceforge.net/tracker/?func=detailaid=3149995group_id=161080atid=818428 Best regards, -- Krzysztof Kościuszkiewicz Simplicity is the ultimate sophistication -- Leonardo da Vinci ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
