Re: gEDA-user: "revert" vs "reload"
On Mon, 2011-09-05 at 21:55 +0100, Peter Clifton wrote:
> Looking at where I hooked up my code, I have hooked it up in a stupid
> place - the file monitoring is cancelled and re-wired every time PCB
> handles a menu action!
>
> It probably needs to hook up so it is only called upon the PCBChanged"
> action.
Gah - this causes fun and games. I turns out that we only missed our own
save action modifications to the PCB file because of the stupid place I
hooked up the code. (It cancelled and re-attached the file-monitor right
after any menu action - including File->Save of course).
I've pushed a few preliminaries (HID API) to git HEAD to allow the core
to notify us around a SavePCB() call, and to tell us if the filename of
the PCB has changed (e.g. File->SaveAs).
Unfortunately, I can't make it work for the SaveAs case. I'm sure I must
be missing something simple, but I just can't get the file monitors to
ignore changes to the new PCB file despite tracing the fact that we
delete the old file monitor, save the PCB (in the new filename), THEN
hook up the new file change monitor.
I'm _guessing_ that either the saved changes don't hit the disk
immediately, or GLib / GIO is helpfully caching the directory state from
before I hooked up the file monitor - then falsely detecting a change
(as we hook up the new file-monitor right after we wrote to the file).
Anyway, I'm not quite sure how to fix it. It might come down to not
disconnecting the file-change monitor, but adding a flag somewhere to
make the callback ignore the next change we get notified about (after a
save).
Anyway - if you fancy figuring out just what I'm doing wrong, the patch
(work in progress) against git HEAD is attached.
> We could consider splitting that action into "PCBChanged" and
> "PCBReverted" actions (or add arguments to the former), so the GUI can
> do different levels of UI resetting for load and revert.
I added a "revert" parameter to the PCBChanged action, so that should be
a good start for you looking into this. It appears there will be some
special casing in the HID to do, and possibly a bit of work in the core
to make sure it doesn't wipe out more state than it needs as it reloads
the board.
Obviously we need to be careful that we don't get PCB into an
inconsistent state reloading a changed board from disk whilst trying to
keep "some" view settings. Remember that we could notionally change
_anything_ in the PCB file we revert to.
Best wishes,
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)
From b3bf8f798e7daf4d9bbf4dac9d0c5725ac6ac911 Mon Sep 17 00:00:00 2001
From: Peter Clifton
Date: Mon, 5 Sep 2011 22:18:16 +0100
Subject: [PATCH] hid/gtk: Connect up the file-change monitor in a more
sensible place
I must have had a brain-fail when I hooked it up in the call which sets
the window title. NB: That also gets called after every menu operation!
Hook up the connection in the ghid_sync_with_new_layout() function,
which looks to be a much more appropriate place, however changing this
alone revealed another issue - we now get notified for changes WE make
to the files.
We were avoiding those events as the file-monitor was being reset before
it could pop up, at the end of the menu action which invoked the save).
Hook up to the new HID API (added in the previous commit) which allows
us to temporarily disconnect the file-monitor when PCB's core is saving
to the PCB file.
---
src/file.c |1 +
src/hid/gtk/gtkhid-main.c|3 +
src/hid/gtk/gui-top-window.c | 271 --
src/hid/gtk/gui.h|2 +
4 files changed, 159 insertions(+), 118 deletions(-)
diff --git a/src/file.c b/src/file.c
index be7f6a5..d31b157 100644
--- a/src/file.c
+++ b/src/file.c
@@ -358,6 +358,7 @@ SavePCB (char *file)
gui->notify_save_pcb (file, false);
retcode = WritePipe (file, true);
+ printf ("File changes hitting disk now\n");
gui->notify_save_pcb (file, true);
return retcode;
diff --git a/src/hid/gtk/gtkhid-main.c b/src/hid/gtk/gtkhid-main.c
index 89d50be..a855aa7 100644
--- a/src/hid/gtk/gtkhid-main.c
+++ b/src/hid/gtk/gtkhid-main.c
@@ -2170,6 +2170,9 @@ hid_gtk_init ()
ghid_hid.flush_debug_draw = ghid_flush_debug_draw;
ghid_hid.finish_debug_draw= ghid_finish_debug_draw;
+ ghid_hid.notify_save_pcb = ghid_notify_save_pcb;
+ ghid_hid.notify_filename_changed = ghid_notify_filename_changed;
+
hid_register_hid (&ghid_hid);
#include "gtk_lists.h"
}
diff --git a/src/hid/gtk/gui-top-window.c b/src/hid/gtk/gui-top-window.c
index 73bada5..1277da0 100644
--- a/src/hid/gtk/gui-top-window.c
+++ b/src/hid/gtk/gui-top-window.c
@@ -262,6 +262,130 @@ void ghid_hotkey_cb (int which)
(gpointer) ghid_hotkey_actions[which].node)
Re: gEDA-user: "revert" vs "reload"
On Tue, Sep 6, 2011 at 6:40 AM, Richard Barlow wrote: > I've made a couple of small modifications to the message that's > displayed to the user in the info bar[1]. It would also be good if when > reloading/reverting the file the state of the UI wasn't reset too, it's > quite annoying for all of the layers to be re-enabled if you're in the > middle of routing. I'll look into that later. +1 Very annoying with multi layer boards and a work flow that involves frequent changes to the PCB from gedit. Stephen Ecob Silicon On Inspiration Sydney Australia www.sioi.com.au $39 Spartan 6 board with 32MB DDR DRAM ? http://www.sioi.com.au/shop/product_info.php/products_id/47 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Mon, 2011-09-05 at 21:40 +0100, Richard Barlow wrote: > > Sorry Richard - I beat you to it - committed to git HEAD of PCB last > > night ;) I bumped PCB's GTK version requirement to 2.18. > > Haha, nice. I suspected you were working on this after seeing your > commits cleaning up gui-top-window.c. I see you've made a load more > modifications today bringing the code up to date, nice work. Yes - mostly taking advantage of the GTK 2.18 version bump to get rid of some deprecated APIs and other issues. (One day we'll be able to compile with GTK 3.0d!) > I've made a couple of small modifications to the message that's > displayed to the user in the info bar[1]. Note that if you hit the revert button, and PCB will still prompt you for further confirmation if you had unsaved changes. I deliberately copied the message text straight from gedit in order to try and keep it consistent with the rest of the desktop, but I'm not completely against changing it, so long as the new message still fits on the small-ish screens without undue wrapping/ > It would also be good if when reloading/reverting the file the state of the > UI wasn't reset too, it's > quite annoying for all of the layers to be re-enabled if you're in the > middle of routing. I'll look into that later. That would be handy. Looking at where I hooked up my code, I have hooked it up in a stupid place - the file monitoring is cancelled and re-wired every time PCB handles a menu action! It probably needs to hook up so it is only called upon the PCBChanged" action. We could consider splitting that action into "PCBChanged" and "PCBReverted" actions (or add arguments to the former), so the GUI can do different levels of UI resetting for load and revert. > > > I'm also planning on implementing the same behavior in gschem which > > > currently depends on GTK 2.10. > ... > > Please feel free to take any of the code I wrote to help you on the way > > with a gschem / gattrib version. I would love to see this consistently > > across the tools, yet didn't have time to do the gEDA parts at the > > moment. > > Cool, thanks. I asked Ales and DJ on IRC earlier, and we have a consensus that bumping the version requirement to GTK 2.18 is OK. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Mon, 2011-09-05 at 12:42 +0100, Peter Clifton wrote: > On Mon, 2011-09-05 at 12:09 +0100, Richard Barlow wrote: > > I've started implementing this[1] with a little help from the gedit > > source. Unfortunately the info bar widget that I've used was introduced > > in GTK 2.18 and PCB currently depends on GTK 2.12. Is there any argument > > against upping PCBs GTK version dependency to 2.18? It was released > > almost two years ago now (23rd Sept 2009). > > Sorry Richard - I beat you to it - committed to git HEAD of PCB last > night ;) I bumped PCB's GTK version requirement to 2.18. Haha, nice. I suspected you were working on this after seeing your commits cleaning up gui-top-window.c. I see you've made a load more modifications today bringing the code up to date, nice work. I've made a couple of small modifications to the message that's displayed to the user in the info bar[1]. It would also be good if when reloading/reverting the file the state of the UI wasn't reset too, it's quite annoying for all of the layers to be re-enabled if you're in the middle of routing. I'll look into that later. > > I'm also planning on implementing the same behavior in gschem which > > currently depends on GTK 2.10. ... > Please feel free to take any of the code I wrote to help you on the way > with a gschem / gattrib version. I would love to see this consistently > across the tools, yet didn't have time to do the gEDA parts at the > moment. Cool, thanks. Rich [1] git://srobo.org/~rbarlow/pcb.git signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Sep 5, 2011, at 10:49 AM, Peter Clifton wrote: > On Mon, 2011-09-05 at 10:38 -0700, Steven Michalske wrote: >> On Sep 5, 2011, at 9:34 AM, DJ Delorie wrote: > >>> Er, what gtk do the Mac builds use? >>> >> Macports is at 2.24.5 >> Fink is at 2.18.9 >> Homebrew is at 2.24.6 > > Do you happen to know if there are any builds of GTK 3.0 out there yet? > Macports has 3.0.5 Fink and homebrew do not. > -- > Peter Clifton > > Electrical Engineering Division, > Engineering Department, > University of Cambridge, > 9, JJ Thomson Avenue, > Cambridge > CB3 0FA > > Tel: +44 (0)7729 980173 - (No signal in the lab!) > Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) > > > ___ > geda-user mailing list > geda-user@moria.seul.org > http://www.seul.org/cgi-bin/mailman/listinfo/geda-user ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
> Macports is at 2.24.5 > Fink is at 2.18.9 > Homebrew is at 2.24.6 Thanks! ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Mon, 2011-09-05 at 10:38 -0700, Steven Michalske wrote: > On Sep 5, 2011, at 9:34 AM, DJ Delorie wrote: > > Er, what gtk do the Mac builds use? > > > Macports is at 2.24.5 > Fink is at 2.18.9 > Homebrew is at 2.24.6 Do you happen to know if there are any builds of GTK 3.0 out there yet? -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Sep 5, 2011, at 9:34 AM, DJ Delorie wrote: > >> I'm also planning on implementing the same behavior in gschem which >> currently depends on GTK 2.10. Any arguments to upping this to 2.18 too? > > Even the Windows builds use 2.20. I'd say, bump configure.ac to need > 2.18 - and do nothing else - and see if anyone trips over it. Then > we'll know if we need to work around it. > > Er, what gtk do the Mac builds use? > Macports is at 2.24.5 Fink is at 2.18.9 Homebrew is at 2.24.6 > > ___ > geda-user mailing list > geda-user@moria.seul.org > http://www.seul.org/cgi-bin/mailman/listinfo/geda-user ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
> I'm also planning on implementing the same behavior in gschem which > currently depends on GTK 2.10. Any arguments to upping this to 2.18 too? Even the Windows builds use 2.20. I'd say, bump configure.ac to need 2.18 - and do nothing else - and see if anyone trips over it. Then we'll know if we need to work around it. Er, what gtk do the Mac builds use? ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
Richard Barlow wrote: >> On Tue, 2011-08-30 at 01:46 +0200, Kai-Martin Knaak wrote: >> > With a number of recommended work-flows PCB and gschem do not >> > return to the last saved state. Instead, they update to the >> > current state of the source file. The gsch2pcb work-flow relies >> > on the ability to change the *.pcb file in the back of PCB. >> > Contrary to the meaning of the word "revert" the "revert" >> > action does not go back but forward. >> >> When the files that evince or gedit have open are changed, they pop up a >> bar across the top of the window with a reload button in it. Perhaps >> this is a solution that would fit in better. > > I've started implementing this[1] with a little help from the gedit > source. Nice! Hope to see it in the repo soon. ---<)kaimartin(>--- -- Kai-Martin Knaak tel: +49-511-762-2895 Universität Hannover, Inst. für Quantenoptik fax: +49-511-762-2211 Welfengarten 1, 30167 Hannover http://www.iqo.uni-hannover.de -> not happy with moderation of geda-user mailinglist ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Mon, 2011-09-05 at 12:09 +0100, Richard Barlow wrote: > On Wed, 2011-08-31 at 11:08 +0100, Rob Spanton wrote: > > On Tue, 2011-08-30 at 01:46 +0200, Kai-Martin Knaak wrote: > > > With a number of recommended work-flows PCB and gschem do not > > > return to the last saved state. Instead, they update to the > > > current state of the source file. The gsch2pcb work-flow relies > > > on the ability to change the *.pcb file in the back of PCB. > > > Contrary to the meaning of the word "revert" the "revert" > > > action does not go back but forward. > > > > When the files that evince or gedit have open are changed, they pop up a > > bar across the top of the window with a reload button in it. Perhaps > > this is a solution that would fit in better. > > I've started implementing this[1] with a little help from the gedit > source. Unfortunately the info bar widget that I've used was introduced > in GTK 2.18 and PCB currently depends on GTK 2.12. Is there any argument > against upping PCBs GTK version dependency to 2.18? It was released > almost two years ago now (23rd Sept 2009). Sorry Richard - I beat you to it - committed to git HEAD of PCB last night ;) I bumped PCB's GTK version requirement to 2.18. > I'm also planning on implementing the same behavior in gschem which > currently depends on GTK 2.10. Any arguments to upping this to 2.18 too? I probably ought not to do that unilaterally (like I just did for PCB), but _I_ would have no objection to it. Please feel free to take any of the code I wrote to help you on the way with a gschem / gattrib version. I would love to see this consistently across the tools, yet didn't have time to do the gEDA parts at the moment. Actually gattrib support might be tricky, since it opens multiple files and doesn't support reloading at the moment (?) - gschem support would be awesome. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Wed, 2011-08-31 at 11:08 +0100, Rob Spanton wrote: > On Tue, 2011-08-30 at 01:46 +0200, Kai-Martin Knaak wrote: > > With a number of recommended work-flows PCB and gschem do not > > return to the last saved state. Instead, they update to the > > current state of the source file. The gsch2pcb work-flow relies > > on the ability to change the *.pcb file in the back of PCB. > > Contrary to the meaning of the word "revert" the "revert" > > action does not go back but forward. > > When the files that evince or gedit have open are changed, they pop up a > bar across the top of the window with a reload button in it. Perhaps > this is a solution that would fit in better. I've started implementing this[1] with a little help from the gedit source. Unfortunately the info bar widget that I've used was introduced in GTK 2.18 and PCB currently depends on GTK 2.12. Is there any argument against upping PCBs GTK version dependency to 2.18? It was released almost two years ago now (23rd Sept 2009). I'm also planning on implementing the same behavior in gschem which currently depends on GTK 2.10. Any arguments to upping this to 2.18 too? Thanks, Rich [1] https://www.studentrobotics.org/~rbarlow/images/pcb_infobar1.png signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Wed, 2011-08-31 at 20:43 -0400, DJ Delorie wrote: > > > Given the nature of PCB, I'd suggest tying it to the "changed" flag of > > > the loaded PCB - so if you haven't edited it yet, you see "reload" but > > > if you have unsaved changes, you see "revert". > > > > Gah, PLEASE NO. > > Well, yeah, I wouldn't recommend magically changing menu buttons at > all, but it's better than trying to see if someone edited the file out > from under you when you're the one with the editor. Its a common practice for a lot of editors now, including vim (or at least gvim). I've lost count the number of times I've had the same schematic accidentally open twice by accident - for example. A warning when the file changes underneath me could be a huge bonus to know I need to _think_ before I save. More usefully, it would also make working between gschem and gattrib easier. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
> > Given the nature of PCB, I'd suggest tying it to the "changed" flag of > > the loaded PCB - so if you haven't edited it yet, you see "reload" but > > if you have unsaved changes, you see "revert". > > Gah, PLEASE NO. Well, yeah, I wouldn't recommend magically changing menu buttons at all, but it's better than trying to see if someone edited the file out from under you when you're the one with the editor. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Wed, 2011-08-31 at 19:44 -0400, DJ Delorie wrote: > > We would probably need the g_file_monitor_file API in GLib/GIO. > > Given the nature of PCB, I'd suggest tying it to the "changed" flag of > the loaded PCB - so if you haven't edited it yet, you see "reload" but > if you have unsaved changes, you see "revert". Gah, PLEASE NO. Just stick with the Gnome HIG specification and be done with it. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
> We would probably need the g_file_monitor_file API in GLib/GIO. Given the nature of PCB, I'd suggest tying it to the "changed" flag of the loaded PCB - so if you haven't edited it yet, you see "reload" but if you have unsaved changes, you see "revert". ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Wed, 2011-08-31 at 11:08 +0100, Rob Spanton wrote: > On Tue, 2011-08-30 at 01:46 +0200, Kai-Martin Knaak wrote: > > With a number of recommended work-flows PCB and gschem do not > > return to the last saved state. Instead, they update to the > > current state of the source file. The gsch2pcb work-flow relies > > on the ability to change the *.pcb file in the back of PCB. > > Contrary to the meaning of the word "revert" the "revert" > > action does not go back but forward. > > When the files that evince or gedit have open are changed, they pop up a > bar across the top of the window with a reload button in it. Perhaps > this is a solution that would fit in better. Would be nice to have. Perhaps file a feature-request on http://launchpad.net/pcb/+bugs We would probably need the g_file_monitor_file API in GLib/GIO. This is present (I think), since GLib 2.18. This corresponds to approximately GTK 2.16 and onwards. (From a quick scan of the git repository, GTK 2.16 requires at least GLIB 2.19.7). Regards, -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Tue, 2011-08-30 at 01:46 +0200, Kai-Martin Knaak wrote: > With a number of recommended work-flows PCB and gschem do not > return to the last saved state. Instead, they update to the > current state of the source file. The gsch2pcb work-flow relies > on the ability to change the *.pcb file in the back of PCB. > Contrary to the meaning of the word "revert" the "revert" > action does not go back but forward. When the files that evince or gedit have open are changed, they pop up a bar across the top of the window with a reload button in it. Perhaps this is a solution that would fit in better. Cheers, Rob signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
Peter Clifton wrote: > Picking GIMP and gedit as examples of popular, well written > applications, they both use "Revert". However, gimp is unlikely to be used like we do with *.sch and *.pcb files. That is, use third party tools to manipulate them and reload the result to the GUI. gedit solves the situation differently: It detects when the source file is changed. It then presents a modal dialog that asks whether, or not to reload. So the user will never have to use "revert" to update the text shown in the canvas of gedit. Would it be hard to implement this for PCB? > This is specified in the HIG: > > http://developer.gnome.org/hig-book/3.0/menus-standard.html.en > Not quite. The description to the revert item reads: "Reverts the document to the last saved state. Present the user with a warning that all changes will be lost, and offer the option of cancelling before reloading the file." With a number of recommended work-flows PCB and gschem do not return to the last saved state. Instead, they update to the current state of the source file. The gsch2pcb work-flow relies on the ability to change the *.pcb file in the back of PCB. Contrary to the meaning of the word "revert" the "revert" action does not go back but forward. Seen from that angle, my complaint with the current "revert" is that it does not conform to the gnome HIG. > So my preference is that we stick with "Revert" here. Ok, I won't prepare patches. ---<)kaimartin(>--- -- Kai-Martin Knaak Email: k...@familieknaak.de http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53 increasingly unhappy with moderation of geda-user ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: "revert" vs "reload"
On Mon, 2011-08-29 at 19:30 +0200, Kai-Martin Knaak wrote: > I like doing tricks with scripts or with the text editor. Some features of > gschem are not even accesssible via the GUI. The revert action in the file > to propagate the changes to the GUI. menu. However, under these circumstances > this is not a revert in the original meaning of the term. > > Proposal: Rename the menu item "revert" to the more neutral "reload". > This applies to both, PCB and gschem. > > Would this be appreciated? I tend to look at a couple of popular GNOME (/ GTK) apps as well as the GNOME HIG as guides to how GTK applications ought to look to be consistent on the desktop. Picking GIMP and gedit as examples of popular, well written applications, they both use "Revert". This is specified in the HIG: http://developer.gnome.org/hig-book/3.0/menus-standard.html.en So my preference is that we stick with "Revert" here. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
gEDA-user: "revert" vs "reload"
I like doing tricks with scripts or with the text editor. Some features of gschem are not even accesssible via the GUI. The revert action in the file to propagate the changes to the GUI. menu. However, under these circumstances this is not a revert in the original meaning of the term. Proposal: Rename the menu item "revert" to the more neutral "reload". This applies to both, PCB and gschem. Would this be appreciated? ---<)kaimartin(>--- -- Kai-Martin Knaak tel: +49-511-762-2895 Universität Hannover, Inst. für Quantenoptik fax: +49-511-762-2211 Welfengarten 1, 30167 Hannover http://www.iqo.uni-hannover.de -> not happy with moderation of geda-user mailinglist ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
