[Geeqie-devel] Revisiting file_data_free: assertion failed: (fd->sidecar_files == NULL)
Hello everyone! This post is related to Geeqie crashing in an assertion in file_data_unref (see subject line). In addition to perusing more of the source code, I've received helpful --debug output from a bug reporter, who can reproduce the issue with a few attempts, while I don't manage to reproduce it: filedata.c:718: file_data_unref: deleting '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG', parent '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jpg' ** ERROR:filedata.c:676:file_data_free: assertion failed: (fd->sidecar_files == NULL) This has been encountered during loading images from an SD card. As one can see, it added a file (*.JPG) as its own sidecar file (*.jpg), and file_data_unref cannot cope with that. This is because in filedata.c file_data_check_sidecars() and check_case_insensitive_ext() a case-insensitive fstat is performed for files with a generated list of potential sidecar file name extensions. This gives wrong results on a case-insensitive file-system and apparently adds .jpg as a sidecar file for .JPG. layout.c:2204: 0.341570 (+0.033411) layout_new: end filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' 1 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' 0 0 filedata.c:655: file_data_ref (2): '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' @ filedata.c:398 filedata.c:428: file_data_pool hit: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPg' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JpG' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.Jpg' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jPG' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jPg' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jpG' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jpg' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.CR2' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.Cr2' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.cR2' 0 0 filedata.c:390: file_data_new: '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.cr2' 0 0 As a work-around, I've inserted a file ext comparison directly in file_data_check_sidecars(), but I could imagine adding another one in file_data_unref(). What do you think? Regards, Michael -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] file operations very slow
Hi Klaus I guess that this is not a situation that arises all that often, I didn't know if this was known about. At least for me it is not so bad and it will be a nice surprise when one day I find it fixed :-) Stair -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] file operations very slow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Am Fr den 4. Mär 2011 um 11:55 schrieb stair: > If you compare 2 file sets with many (100s) duplicates using 'Find > Duplicate', select the group of duplicates you want to delete and then > choose delete then the behaviour I described in my original post is still > there i.e. the delete process starts very slowly and speeds up as the > number of deletions remaining shrinks That's true. I have this on my personal todo list. What I can say is, that it was not the case with gqview. I know why this happens. What I do not know is how to fix it. Maybe I will do a bisec once. The problem is, that I have so many thinks on my list but the time I have available is very limited. (I also have to be in the right moods.) Regards Klaus - -- Klaus Ethgenhttp://www.ethgen.ch/ pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQEVAwUBTXDIjJ+OKpjRpO3lAQpZIAf+Kd3FiYkR5gTA2JBZFzlAB6ektU9oT+rv 0H4rtgrZm/DlpEro33xKAy9Cr4By3YgY/I3HnrCkBWc5Qbf+QidDx95ytC2Oa+Yv SmKXTzMmNL/1mKS/vcmD4AhNiKv6yYSME5DPfCnOA3M5H8KspwWMoLSlTci79DbY wGdtTV9FTZ1o2P3K6tqSb1QZeUjSe3Z5FOT12hux7k/2dKqll4kZW0XGF2/73h8Y +/LWNTIHSrOCKvdQdER2CQ63G3tsosWikEPcerjfs1dbAcSHKNoVPgo1nqR4qOd7 QqW40eECVYf1KRIcI7AHssTwbq0qIYpk1Dm8KIos+mtSe6mI9TvhlQ== =Egsf -END PGP SIGNATURE- -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] file operations very slow
I had thought that this issue was fixed but actually it is only part fixed. If you compare 2 file sets with many (100s) duplicates using 'Find Duplicate', select the group of duplicates you want to delete and then choose delete then the behaviour I described in my original post is still there i.e. the delete process starts very slowly and speeds up as the number of deletions remaining shrinks Vladimir's fix only fixed the case where files are selected in the image list and then deleted Stair -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
